You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/01/30 05:18:45 UTC

[GitHub] [pulsar] Technoboy- commented on pull request #14030: [Broker] Make PersistentTopicsBase#internalCreateNonPartitionedTopic async.

Technoboy- commented on pull request #14030:
URL: https://github.com/apache/pulsar/pull/14030#issuecomment-1025072828


   > Another, I have two suggestions:
   > 
   > * Remove asyncResponse from the internal method, and unified exception and result handling are performed at the controller layer, which makes the internal method purer.
   > * Have you checked to see if there is a test for the modified method?
   
   Yes, right.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org