You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/04/15 11:30:00 UTC
[GitHub] [spark] panbingkun opened a new pull request, #36211: [SPARK-38738][SQL][TESTS] Test the error class: INVALID_FRACTION_OF_SECOND
panbingkun opened a new pull request, #36211:
URL: https://github.com/apache/spark/pull/36211
## What changes were proposed in this pull request?
This pr aims to add one test for the error class INVALID_FRACTION_OF_SECOND to QueryExecutionErrorsSuite, it's a followup of [SPARK-37935](https://issues.apache.org/jira/browse/SPARK-37935).
### Why are the changes needed?
Add one test for the error class INVALID_FRACTION_OF_SECOND to QueryExecutionErrorsSuite.
### Does this PR introduce any user-facing change?
No
### How was this patch tested?
- Manual test：
```
build/sbt "sql/testOnly *QueryExecutionErrorsSuite*"
```
All tests passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #36211: [SPARK-38738][SQL][TESTS] Test the error class: INVALID_FRACTION_OF_SECOND
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on PR #36211:
URL: https://github.com/apache/spark/pull/36211#issuecomment-1100208272
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #36211: [SPARK-38738][SQL][TESTS] Test the error class: INVALID_FRACTION_OF_SECOND
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on PR #36211:
URL: https://github.com/apache/spark/pull/36211#issuecomment-1100731745
+1, LGTM. Checked the test locally. Merging to master.
Thank you, @panbingkun.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on a diff in pull request #36211: [SPARK-38738][SQL][TESTS] Test the error class: INVALID_FRACTION_OF_SECOND
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on code in PR #36211:
URL: https://github.com/apache/spark/pull/36211#discussion_r851659673
##########
sql/core/src/test/scala/org/apache/spark/sql/errors/QueryExecutionErrorsSuite.scala:
##########
@@ -388,4 +388,16 @@ class QueryExecutionErrorsSuite extends QueryTest
|""".stripMargin)
}
}
+
+ test("INVALID_FRACTION_OF_SECOND: make_timestamp failure - the fraction of sec must be zero") {
Review Comment:
let's not add so much details in the title:
```suggestion
test("INVALID_FRACTION_OF_SECOND: in the function make_timestamp") {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk closed pull request #36211: [SPARK-38738][SQL][TESTS] Test the error class: INVALID_FRACTION_OF_SECOND
Posted by GitBox <gi...@apache.org>.
MaxGekk closed pull request #36211: [SPARK-38738][SQL][TESTS] Test the error class: INVALID_FRACTION_OF_SECOND
URL: https://github.com/apache/spark/pull/36211
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org