You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by matrosov-nikita <gi...@git.apache.org> on 2017/06/21 12:10:49 UTC
[GitHub] cordova-android pull request #388: Suppress line 'Picked up _JAVA_OPTIONS' f...
GitHub user matrosov-nikita opened a pull request:
https://github.com/apache/cordova-android/pull/388
Suppress line 'Picked up _JAVA_OPTIONS' from stderr
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
android
### What does this PR do?
If `_JAVA_OPTIONS` variable is defined, cordova outputs `Picked up _JAVA_OPTIONS: -Xmx512M` to stderr, it's interpreted to be an error, but actually, it's not an error. We should suppress this line for `runGradleWrapper` similar to `build`(https://issues.apache.org/jira/browse/CB-9971).
### What testing has been done on this change?
fix auto-test for GradleBuilder logic
### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/matrosov-nikita/cordova-android suppress-java-unwanted-info
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-android/pull/388.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #388
----
commit 0013df243e8de5aa869b433562967fa80d041092
Author: Nikita Matrosov <v-...@microsoft.com>
Date: 2017-06-20T07:21:39Z
Suppress line 'Picked up _JAVA_OPTIONS' in stderr
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #388: CB-9971: Suppressed unwanted java stderr output ...
Posted by matrosov-nikita <gi...@git.apache.org>.
Github user matrosov-nikita commented on the issue:
https://github.com/apache/cordova-android/pull/388
@filmaj, is it good to merge?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #388: Suppress line 'Picked up _JAVA_OPTIONS' from std...
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-android/pull/388
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/388?src=pr&el=h1) Report
> Merging [#388](https://codecov.io/gh/apache/cordova-android/pull/388?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/3a6e898b12eac31dfc16a4c526dfba8fab158723?src=pr&el=desc) will **decrease** coverage by `0.03%`.
> The diff coverage is `18.18%`.
[](https://codecov.io/gh/apache/cordova-android/pull/388?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #388 +/- ##
==========================================
- Coverage 39.52% 39.48% -0.04%
==========================================
Files 16 16
Lines 1551 1555 +4
Branches 277 277
==========================================
+ Hits 613 614 +1
- Misses 938 941 +3
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/388?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...in/templates/cordova/lib/builders/GradleBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/388?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9HcmFkbGVCdWlsZGVyLmpz) | `20.13% <18.18%> (+0.13%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/388?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/388?src=pr&el=footer). Last update [3a6e898...0013df2](https://codecov.io/gh/apache/cordova-android/pull/388?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #388: CB-9971: Suppressed unwanted java stderr output ...
Posted by filmaj <gi...@git.apache.org>.
Github user filmaj commented on the issue:
https://github.com/apache/cordova-android/pull/388
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android pull request #388: CB-9971: Suppressed unwanted java stderr ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-android/pull/388
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org