[GitHub] [spark] jchen5 commented on a diff in pull request #42559: [SPARK-44871][SQL] Fix percentile_disc behaviour

["jchen5 (via GitHub)" <gi...@apache.org>]

jchen5 commented on code in PR #42559:
URL: https://github.com/apache/spark/pull/42559#discussion_r1298450515


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/percentiles.scala:
##########
@@ -222,6 +230,30 @@ abstract class PercentileBase
     }
   }

Review Comment:
   Can we add a comment in the old getPercentile discrete codepath that it's only used when the legacy flag is set



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org