You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/08/29 15:52:02 UTC

[GitHub] [fineract] habiletec opened a new pull request #1307: Description Field while creating share product should not be mandatory#2591

habiletec opened a new pull request #1307:
URL: https://github.com/apache/fineract/pull/1307


   mandatory#2591
   
   ## Description
   Describe the changes made and why they were made. Ignore if these details are present on the associated Jira ticket
   
   ## Checklist
   Please make sure these boxes are checked before submitting your pull request - thanks!
   
   - [ ] Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API.
   
   - [ ] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed.
   
   - [ ] API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm has been updated with details of any API changes.
   
   - [ ] Integration tests have been created/updated for verifying the changes made.
   
   - [ ] All Integrations tests are passing with the new commits.
   
   - [ ] Submission is not a "code dump".  (Large changes can be made "in repository" via a branch.  Ask on the list.)
   
   Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] vorburger commented on pull request #1307: Description Field while creating share product should not be mandatory#2591

Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1307:
URL: https://github.com/apache/fineract/pull/1307#issuecomment-706686955


   @habiletec ping, are you still interested in this, and willing to change this PR to make this change in a new SQL migration script, instead of by changing an existing old one and raise a JIRA issue about this, or shall we close this PR?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] github-actions[bot] commented on pull request #1307: Description Field while creating share product should not be mandatory#2591

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #1307:
URL: https://github.com/apache/fineract/pull/1307#issuecomment-700355949


   This pull request seems to be stale.  Are you still planning to work on it?  We will automatically close it in 30 days.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] vorburger commented on pull request #1307: Description Field while creating share product should not be mandatory#2591

Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1307:
URL: https://github.com/apache/fineract/pull/1307#issuecomment-683343568


   @habiletec could you raise a JIRA issue about this first? Also, could you make this change in a new SQL migration script, instead of by changing an existing old one? Thanks!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] github-actions[bot] closed pull request #1307: Description Field while creating share product should not be mandatory#2591

Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #1307:
URL: https://github.com/apache/fineract/pull/1307


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org