[jira] [Commented] (FLINK-4192) Move Metrics API to separate module

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-4192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15370881#comment-15370881 ] 

ASF GitHub Bot commented on FLINK-4192:
---------------------------------------

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/2226

    [FLINK-4192] - Move Metrics API to separate module

    This PR moves several metrics-related classes into a new module.
    
    The new module is located under `flink-metrics/flink-metrics-core`.
    
    Most of the changes are related to
    * renaming of `MetricRegistry` to `InternalMetricRegistry`
     * a new `MetricRegistry` interface was added
    * replacing usages of `Configuration` with a new `MetricConfig`
    
    Changes unrelated to the above are as follows:
    * obviously, creating a new module and adjusting dependencies
    * some tests were refactored to properly close the registry
    * `getScopeComponents/-String()` was moved from `AbstractMetricGroup` to `MetricGroup`
    * fixed a small typo in `Scheduled`  interface
    
    I have verified that it compiles and works for example.The tests in flink-core pass as well, I'll leave the rest to travis.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink metrics_4th_of_july

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2226.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2226
    
----

----


> Move Metrics API to separate module
> -----------------------------------
>
>                 Key: FLINK-4192
>                 URL: https://issues.apache.org/jira/browse/FLINK-4192
>             Project: Flink
>          Issue Type: Improvement
>          Components: Metrics
>    Affects Versions: 1.1.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>             Fix For: 1.1.0
>
>
> All metrics code currently resides in flink-core. If a user implements a reporter and wants a fat jar it will now have to include the entire flink-core module.
> Instead, we could move several interfaces into a separate module.
> These interfaces to move include:
> * Counter, Gauge, Histogram(Statistics)
> * MetricGroup
> * MetricReporter, Scheduled, AbstractReporter
> In addition a new MetricRegistry interface will be required as well as a replacement for the Configuration.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)