[jira] [Commented] (TEZ-1741) App view.

["Prakash Ramachandran (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TEZ-1741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14204020#comment-14204020 ] 

Prakash Ramachandran commented on TEZ-1741:
-------------------------------------------

[~Sreenath] This does not apply cleanly on TEZ-8 branch. The variables like env, application etc that I see in the patch (being modified) seems to be missing from the TEZ-8 branch.

couple of minor comments 

- are the console logs required? seems like left behind from debugging. its spamming the logs. 
- This is a typo?
{code:title=tez-app-configs-controller.js}
configs = configs = this.get('configs').content
{code}
- in loadEntites function why is 'that' being used? shouldn't it be this.key etc. as its not a callback.

> App view.
> ---------
>
>                 Key: TEZ-1741
>                 URL: https://issues.apache.org/jira/browse/TEZ-1741
>             Project: Apache Tez
>          Issue Type: Sub-task
>            Reporter: Sreenath Somarajapuram
>            Assignee: Sreenath Somarajapuram
>         Attachments: TEZ-1741.1.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)