You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iotdb.apache.org by ja...@apache.org on 2022/11/29 12:04:20 UTC
[iotdb] 01/01: Change user or network error log to warn log
This is an automated email from the ASF dual-hosted git repository.
jackietien pushed a commit to branch ChangeLogLevel
in repository https://gitbox.apache.org/repos/asf/iotdb.git
commit f27ad19973da1c8399c538fb0a9b57b3be604f7a
Author: JackieTien97 <ja...@gmail.com>
AuthorDate: Tue Nov 29 20:04:05 2022 +0800
Change user or network error log to warn log
---
.../execution/exchange/MPPDataExchangeManager.java | 6 ++---
.../db/mpp/execution/exchange/SinkHandle.java | 6 ++---
.../db/mpp/execution/exchange/SourceHandle.java | 4 ++--
.../fragment/FragmentInstanceManager.java | 4 ++--
.../execution/schedule/AbstractDriverThread.java | 2 +-
.../iotdb/db/mpp/plan/analyze/AnalyzeVisitor.java | 12 +++++-----
.../mpp/plan/analyze/ClusterPartitionFetcher.java | 2 +-
.../db/mpp/plan/execution/QueryExecution.java | 2 +-
.../scheduler/FixedRateFragInsStateTracker.java | 2 +-
.../scheduler/FragmentInstanceDispatcherImpl.java | 2 +-
.../service/thrift/impl/ClientRPCServiceImpl.java | 2 +-
.../impl/DataNodeInternalRPCServiceImpl.java | 28 +++++++++++-----------
12 files changed, 36 insertions(+), 36 deletions(-)
diff --git a/server/src/main/java/org/apache/iotdb/db/mpp/execution/exchange/MPPDataExchangeManager.java b/server/src/main/java/org/apache/iotdb/db/mpp/execution/exchange/MPPDataExchangeManager.java
index 61e0d46310..9f7ccf8455 100644
--- a/server/src/main/java/org/apache/iotdb/db/mpp/execution/exchange/MPPDataExchangeManager.java
+++ b/server/src/main/java/org/apache/iotdb/db/mpp/execution/exchange/MPPDataExchangeManager.java
@@ -130,7 +130,7 @@ public class MPPDataExchangeManager implements IMPPDataExchangeManager {
((SinkHandle) sinkHandles.get(e.getSourceFragmentInstanceId()))
.acknowledgeTsBlock(e.getStartSequenceId(), e.getEndSequenceId());
} catch (Throwable t) {
- logger.error(
+ logger.warn(
"ack TsBlock [{}, {}) failed.", e.getStartSequenceId(), e.getEndSequenceId(), t);
throw t;
}
@@ -246,7 +246,7 @@ public class MPPDataExchangeManager implements IMPPDataExchangeManager {
@Override
public void onFailure(ISourceHandle sourceHandle, Throwable t) {
- logger.error("Source handle failed due to: ", t);
+ logger.warn("Source handle failed due to: ", t);
if (onFailureCallback != null) {
onFailureCallback.call(t);
}
@@ -297,7 +297,7 @@ public class MPPDataExchangeManager implements IMPPDataExchangeManager {
@Override
public void onFailure(ISinkHandle sinkHandle, Throwable t) {
// TODO: (xingtanzjr) should we remove the sinkHandle from MPPDataExchangeManager ?
- logger.error("Sink handle failed due to", t);
+ logger.warn("Sink handle failed due to", t);
if (onFailureCallback != null) {
onFailureCallback.call(t);
}
diff --git a/server/src/main/java/org/apache/iotdb/db/mpp/execution/exchange/SinkHandle.java b/server/src/main/java/org/apache/iotdb/db/mpp/execution/exchange/SinkHandle.java
index 5c37286c78..d92171b029 100644
--- a/server/src/main/java/org/apache/iotdb/db/mpp/execution/exchange/SinkHandle.java
+++ b/server/src/main/java/org/apache/iotdb/db/mpp/execution/exchange/SinkHandle.java
@@ -363,7 +363,7 @@ public class SinkHandle implements ISinkHandle {
client.onNewDataBlockEvent(newDataBlockEvent);
break;
} catch (Throwable e) {
- logger.error("Failed to send new data block event, attempt times: {}", attempt, e);
+ logger.warn("Failed to send new data block event, attempt times: {}", attempt, e);
if (attempt == MAX_ATTEMPT_TIMES) {
sinkHandleListener.onFailure(SinkHandle.this, e);
}
@@ -403,9 +403,9 @@ public class SinkHandle implements ISinkHandle {
client.onEndOfDataBlockEvent(endOfDataBlockEvent);
break;
} catch (Throwable e) {
- logger.error("Failed to send end of data block event, attempt times: {}", attempt, e);
+ logger.warn("Failed to send end of data block event, attempt times: {}", attempt, e);
if (attempt == MAX_ATTEMPT_TIMES) {
- logger.error("Failed to send end of data block event after all retry", e);
+ logger.warn("Failed to send end of data block event after all retry", e);
sinkHandleListener.onFailure(SinkHandle.this, e);
return;
}
diff --git a/server/src/main/java/org/apache/iotdb/db/mpp/execution/exchange/SourceHandle.java b/server/src/main/java/org/apache/iotdb/db/mpp/execution/exchange/SourceHandle.java
index db9ea594d6..c672383ca3 100644
--- a/server/src/main/java/org/apache/iotdb/db/mpp/execution/exchange/SourceHandle.java
+++ b/server/src/main/java/org/apache/iotdb/db/mpp/execution/exchange/SourceHandle.java
@@ -421,7 +421,7 @@ public class SourceHandle implements ISourceHandle {
break;
} catch (Throwable e) {
- logger.error(
+ logger.warn(
"failed to get data block [{}, {}), attempt times: {}",
startSequenceId,
endSequenceId,
@@ -485,7 +485,7 @@ public class SourceHandle implements ISourceHandle {
client.onAcknowledgeDataBlockEvent(acknowledgeDataBlockEvent);
break;
} catch (Throwable e) {
- logger.error(
+ logger.warn(
"failed to send ack data block event [{}, {}), attempt times: {}",
startSequenceId,
endSequenceId,
diff --git a/server/src/main/java/org/apache/iotdb/db/mpp/execution/fragment/FragmentInstanceManager.java b/server/src/main/java/org/apache/iotdb/db/mpp/execution/fragment/FragmentInstanceManager.java
index fbee7f88d9..db653ff690 100644
--- a/server/src/main/java/org/apache/iotdb/db/mpp/execution/fragment/FragmentInstanceManager.java
+++ b/server/src/main/java/org/apache/iotdb/db/mpp/execution/fragment/FragmentInstanceManager.java
@@ -128,7 +128,7 @@ public class FragmentInstanceManager {
failedInstances,
instance.getTimeOut());
} catch (Throwable t) {
- logger.error("error when create FragmentInstanceExecution.", t);
+ logger.warn("error when create FragmentInstanceExecution.", t);
stateMachine.failed(t);
return null;
}
@@ -179,7 +179,7 @@ public class FragmentInstanceManager {
failedInstances,
instance.getTimeOut());
} catch (Throwable t) {
- logger.error("Execute error caused by ", t);
+ logger.warn("Execute error caused by ", t);
stateMachine.failed(t);
return null;
}
diff --git a/server/src/main/java/org/apache/iotdb/db/mpp/execution/schedule/AbstractDriverThread.java b/server/src/main/java/org/apache/iotdb/db/mpp/execution/schedule/AbstractDriverThread.java
index 4a4101da85..1fae6e0115 100644
--- a/server/src/main/java/org/apache/iotdb/db/mpp/execution/schedule/AbstractDriverThread.java
+++ b/server/src/main/java/org/apache/iotdb/db/mpp/execution/schedule/AbstractDriverThread.java
@@ -59,7 +59,7 @@ public abstract class AbstractDriverThread extends Thread implements Closeable {
try {
next = queue.poll();
} catch (InterruptedException e) {
- logger.error("Executor " + this.getName() + " failed to poll driver task from queue");
+ logger.warn("Executor " + this.getName() + " failed to poll driver task from queue");
Thread.currentThread().interrupt();
break;
}
diff --git a/server/src/main/java/org/apache/iotdb/db/mpp/plan/analyze/AnalyzeVisitor.java b/server/src/main/java/org/apache/iotdb/db/mpp/plan/analyze/AnalyzeVisitor.java
index 7bc61ec849..5d27adb255 100644
--- a/server/src/main/java/org/apache/iotdb/db/mpp/plan/analyze/AnalyzeVisitor.java
+++ b/server/src/main/java/org/apache/iotdb/db/mpp/plan/analyze/AnalyzeVisitor.java
@@ -285,7 +285,7 @@ public class AnalyzeVisitor extends StatementVisitor<Analysis, MPPQueryContext>
analyzeDataPartition(analysis, queryStatement, schemaTree);
} catch (StatementAnalyzeException e) {
- logger.error("Meet error when analyzing the query statement: ", e);
+ logger.warn("Meet error when analyzing the query statement: ", e);
throw new StatementAnalyzeException(
"Meet error when analyzing the query statement: " + e.getMessage());
}
@@ -1734,7 +1734,7 @@ public class AnalyzeVisitor extends StatementVisitor<Analysis, MPPQueryContext>
device2IsAligned);
loadTsFileStatement.addTsFileResource(resource);
} catch (Exception e) {
- logger.error(String.format("Parse file %s to resource error.", tsFile.getPath()), e);
+ logger.warn(String.format("Parse file %s to resource error.", tsFile.getPath()), e);
throw new SemanticException(
String.format("Parse file %s to resource error", tsFile.getPath()));
}
@@ -1757,7 +1757,7 @@ public class AnalyzeVisitor extends StatementVisitor<Analysis, MPPQueryContext>
verifySchema(schemaTree, device2Schemas, device2IsAligned);
}
} catch (Exception e) {
- logger.error("Auto create or verify schema error.", e);
+ logger.warn("Auto create or verify schema error.", e);
throw new SemanticException(
String.format(
"Auto create or verify schema error when executing statement %s.",
@@ -1919,8 +1919,8 @@ public class AnalyzeVisitor extends StatementVisitor<Analysis, MPPQueryContext>
IoTDBDescriptor.getInstance().getConfig().getQueryTimeoutThreshold());
if (result.status.code != TSStatusCode.SUCCESS_STATUS.getStatusCode()
&& result.status.code != TSStatusCode.DATABASE_ALREADY_EXISTS.getStatusCode()) {
- logger.error(String.format("Create Database error, statement: %s.", statement));
- logger.error(String.format("Create database result status : %s.", result.status));
+ logger.warn(
+ "Create Database error, statement: {}, result status is: {}", statement, result.status);
throw new LoadFileException(
String.format("Can not execute create database statement: %s", statement));
}
@@ -1988,7 +1988,7 @@ public class AnalyzeVisitor extends StatementVisitor<Analysis, MPPQueryContext>
entry.getKey(),
schema2TsFile.get(conflictSchema).getPath(),
conflictSchema);
- logger.error(msg);
+ logger.warn(msg);
throw new VerifyMetadataException(msg);
}
}
diff --git a/server/src/main/java/org/apache/iotdb/db/mpp/plan/analyze/ClusterPartitionFetcher.java b/server/src/main/java/org/apache/iotdb/db/mpp/plan/analyze/ClusterPartitionFetcher.java
index b803893288..42e379beb9 100644
--- a/server/src/main/java/org/apache/iotdb/db/mpp/plan/analyze/ClusterPartitionFetcher.java
+++ b/server/src/main/java/org/apache/iotdb/db/mpp/plan/analyze/ClusterPartitionFetcher.java
@@ -116,7 +116,7 @@ public class ClusterPartitionFetcher implements IPartitionFetcher {
}
return schemaPartition;
} catch (TException | IOException e) {
- logger.error("Get Schema Partition error", e);
+ logger.warn("Get Schema Partition error", e);
throw new StatementAnalyzeException(
"An error occurred when executing getSchemaPartition():" + e.getMessage());
}
diff --git a/server/src/main/java/org/apache/iotdb/db/mpp/plan/execution/QueryExecution.java b/server/src/main/java/org/apache/iotdb/db/mpp/plan/execution/QueryExecution.java
index a18061e6db..7cfa0a3fa1 100644
--- a/server/src/main/java/org/apache/iotdb/db/mpp/plan/execution/QueryExecution.java
+++ b/server/src/main/java/org/apache/iotdb/db/mpp/plan/execution/QueryExecution.java
@@ -219,7 +219,7 @@ public class QueryExecution implements IQueryExecution {
try {
Thread.sleep(RETRY_INTERVAL_IN_MS);
} catch (InterruptedException e) {
- logger.error("interrupted when waiting retry");
+ logger.warn("interrupted when waiting retry");
Thread.currentThread().interrupt();
}
retryCount++;
diff --git a/server/src/main/java/org/apache/iotdb/db/mpp/plan/scheduler/FixedRateFragInsStateTracker.java b/server/src/main/java/org/apache/iotdb/db/mpp/plan/scheduler/FixedRateFragInsStateTracker.java
index 00023af34c..613e0011ba 100644
--- a/server/src/main/java/org/apache/iotdb/db/mpp/plan/scheduler/FixedRateFragInsStateTracker.java
+++ b/server/src/main/java/org/apache/iotdb/db/mpp/plan/scheduler/FixedRateFragInsStateTracker.java
@@ -133,7 +133,7 @@ public class FixedRateFragInsStateTracker extends AbstractFragInsStateTracker {
}
} catch (TException | IOException e) {
// TODO: do nothing ?
- logger.error("error happened while fetching query state", e);
+ logger.warn("error happened while fetching query state", e);
}
}
}
diff --git a/server/src/main/java/org/apache/iotdb/db/mpp/plan/scheduler/FragmentInstanceDispatcherImpl.java b/server/src/main/java/org/apache/iotdb/db/mpp/plan/scheduler/FragmentInstanceDispatcherImpl.java
index ea0585fe4e..a6a0604f50 100644
--- a/server/src/main/java/org/apache/iotdb/db/mpp/plan/scheduler/FragmentInstanceDispatcherImpl.java
+++ b/server/src/main/java/org/apache/iotdb/db/mpp/plan/scheduler/FragmentInstanceDispatcherImpl.java
@@ -192,7 +192,7 @@ public class FragmentInstanceDispatcherImpl implements IFragInstanceDispatcher {
String.format("unknown query type [%s]", instance.getType())));
}
} catch (IOException | TException e) {
- logger.error("can't connect to node {}", endPoint, e);
+ logger.warn("can't connect to node {}", endPoint, e);
TSStatus status = new TSStatus();
status.setCode(TSStatusCode.SYNC_CONNECTION_ERROR.getStatusCode());
status.setMessage("can't connect to node " + endPoint);
diff --git a/server/src/main/java/org/apache/iotdb/db/service/thrift/impl/ClientRPCServiceImpl.java b/server/src/main/java/org/apache/iotdb/db/service/thrift/impl/ClientRPCServiceImpl.java
index c27e40ff79..0f1ef48f78 100644
--- a/server/src/main/java/org/apache/iotdb/db/service/thrift/impl/ClientRPCServiceImpl.java
+++ b/server/src/main/java/org/apache/iotdb/db/service/thrift/impl/ClientRPCServiceImpl.java
@@ -868,7 +868,7 @@ public class ClientRPCServiceImpl implements IClientRPCServiceWithHandler {
addOperationLatency(Operation.EXECUTE_ONE_SQL_IN_BATCH, t2);
results.add(result.status);
} catch (Exception e) {
- LOGGER.error("Error occurred when executing executeBatchStatement: ", e);
+ LOGGER.warn("Error occurred when executing executeBatchStatement: ", e);
TSStatus status =
onQueryException(e, "\"" + statement + "\". " + OperationType.EXECUTE_BATCH_STATEMENT);
if (status.getCode() != TSStatusCode.INTERNAL_SERVER_ERROR.getStatusCode()) {
diff --git a/server/src/main/java/org/apache/iotdb/db/service/thrift/impl/DataNodeInternalRPCServiceImpl.java b/server/src/main/java/org/apache/iotdb/db/service/thrift/impl/DataNodeInternalRPCServiceImpl.java
index 58bdd13413..c60382ce76 100644
--- a/server/src/main/java/org/apache/iotdb/db/service/thrift/impl/DataNodeInternalRPCServiceImpl.java
+++ b/server/src/main/java/org/apache/iotdb/db/service/thrift/impl/DataNodeInternalRPCServiceImpl.java
@@ -245,7 +245,7 @@ public class DataNodeInternalRPCServiceImpl implements IDataNodeRPCService.Iface
try {
groupId = ConsensusGroupId.Factory.createFromTConsensusGroupId(req.getConsensusGroupId());
} catch (Throwable t) {
- LOGGER.error("Deserialize ConsensusGroupId failed. ", t);
+ LOGGER.warn("Deserialize ConsensusGroupId failed. ", t);
TSendFragmentInstanceResp resp = new TSendFragmentInstanceResp(false);
resp.setMessage("Deserialize ConsensusGroupId failed: " + t.getMessage());
return resp;
@@ -257,7 +257,7 @@ public class DataNodeInternalRPCServiceImpl implements IDataNodeRPCService.Iface
try {
fragmentInstance = FragmentInstance.deserializeFrom(req.fragmentInstance.body);
} catch (Throwable t) {
- LOGGER.error("Deserialize FragmentInstance failed.", t);
+ LOGGER.warn("Deserialize FragmentInstance failed.", t);
TSendFragmentInstanceResp resp = new TSendFragmentInstanceResp(false);
resp.setMessage("Deserialize FragmentInstance failed: " + t.getMessage());
return resp;
@@ -506,7 +506,7 @@ public class DataNodeInternalRPCServiceImpl implements IDataNodeRPCService.Iface
result.appendFullPath(path);
}
} catch (MetadataException e) {
- LOGGER.error(e.getMessage(), e);
+ LOGGER.warn(e.getMessage(), e);
resp.setStatus(RpcUtils.getStatus(e.getErrorCode(), e.getMessage()));
return resp;
}
@@ -753,7 +753,7 @@ public class DataNodeInternalRPCServiceImpl implements IDataNodeRPCService.Iface
}
result += schemaRegion.countPathsUsingTemplate(req.getTemplateId(), filteredPatternTree);
} catch (MetadataException e) {
- LOGGER.error(e.getMessage(), e);
+ LOGGER.warn(e.getMessage(), e);
resp.setStatus(RpcUtils.getStatus(e.getErrorCode(), e.getMessage()));
return resp;
} finally {
@@ -1021,7 +1021,7 @@ public class DataNodeInternalRPCServiceImpl implements IDataNodeRPCService.Iface
result += gauge.value();
}
} catch (Exception e) {
- LOGGER.error("Failed to get memory from metric because {}", e.getMessage());
+ LOGGER.warn("Failed to get memory from metric because: ", e);
return 0;
}
return result;
@@ -1208,7 +1208,7 @@ public class DataNodeInternalRPCServiceImpl implements IDataNodeRPCService.Iface
}
if (!resp.isSuccess()) {
- LOGGER.error(
+ LOGGER.warn(
"[ChangeRegionLeader] Failed to change the leader of RegionGroup: {}",
regionId,
resp.getException());
@@ -1231,7 +1231,7 @@ public class DataNodeInternalRPCServiceImpl implements IDataNodeRPCService.Iface
if (regionId instanceof SchemaRegionId) {
return SchemaRegionConsensusImpl.getInstance().isLeader(regionId);
}
- LOGGER.error("region {} type is illegal", regionId);
+ LOGGER.warn("region {} type is illegal", regionId);
return false;
}
@@ -1359,7 +1359,7 @@ public class DataNodeInternalRPCServiceImpl implements IDataNodeRPCService.Iface
try {
TriggerManagementService.getInstance().activeTrigger(req.triggerName);
} catch (Exception e) {
- LOGGER.error(
+ LOGGER.warn(
"Error occurred during active trigger instance for trigger: {}. The cause is {}.",
req.triggerName,
e);
@@ -1374,7 +1374,7 @@ public class DataNodeInternalRPCServiceImpl implements IDataNodeRPCService.Iface
try {
TriggerManagementService.getInstance().inactiveTrigger(req.triggerName);
} catch (Exception e) {
- LOGGER.error(
+ LOGGER.warn(
"Error occurred when try to inactive trigger instance for trigger: {}. The cause is {}. ",
req.triggerName,
e);
@@ -1390,7 +1390,7 @@ public class DataNodeInternalRPCServiceImpl implements IDataNodeRPCService.Iface
try {
TriggerManagementService.getInstance().dropTrigger(req.triggerName, req.needToDeleteJarFile);
} catch (Exception e) {
- LOGGER.error(
+ LOGGER.warn(
"Error occurred when dropping trigger instance for trigger: {}. The cause is {}.",
req.triggerName,
e);
@@ -1406,7 +1406,7 @@ public class DataNodeInternalRPCServiceImpl implements IDataNodeRPCService.Iface
TriggerManagementService.getInstance()
.updateLocationOfStatefulTrigger(req.triggerName, req.newLocation);
} catch (Exception e) {
- LOGGER.error(
+ LOGGER.warn(
"Error occurred when updating Location for trigger: {}. The cause is {}.",
req.triggerName,
e);
@@ -1470,7 +1470,7 @@ public class DataNodeInternalRPCServiceImpl implements IDataNodeRPCService.Iface
resp = SchemaRegionConsensusImpl.getInstance().createPeer(regionId, peers);
}
if (!resp.isSuccess()) {
- LOGGER.error(
+ LOGGER.warn(
"{}, CreateNewRegionPeer error, peers: {}, regionId: {}, errorMessage",
REGION_MIGRATE_PROCESS,
peers,
@@ -1512,7 +1512,7 @@ public class DataNodeInternalRPCServiceImpl implements IDataNodeRPCService.Iface
try {
TimeUnit.SECONDS.sleep(20);
} catch (InterruptedException e) {
- LOGGER.error("Meets InterruptedException in stopDataNode RPC method");
+ LOGGER.warn("Meets InterruptedException in stopDataNode RPC method");
} finally {
LOGGER.info("Executing system.exit(0) in stopDataNode RPC method after 20 seconds");
System.exit(0);
@@ -1524,7 +1524,7 @@ public class DataNodeInternalRPCServiceImpl implements IDataNodeRPCService.Iface
DataNode.getInstance().stop();
status.setMessage("stop datanode succeed");
} catch (Exception e) {
- LOGGER.error("Stop Data Node error", e);
+ LOGGER.warn("Stop Data Node error", e);
status.setCode(TSStatusCode.DATANODE_STOP_ERROR.getStatusCode());
status.setMessage(e.getMessage());
}