You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Brandon Williams (JIRA)" <ji...@apache.org> on 2010/01/07 18:55:18 UTC

[jira] Commented: (CASSANDRA-675) TcpReader is slow because of using Exception handling in the normal path

    [ https://issues.apache.org/jira/browse/CASSANDRA-675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12797709#action_12797709 ] 

Brandon Williams commented on CASSANDRA-675:
--------------------------------------------

I received the following traceback on the bootstrapping node during bootstrap:

WARN - Problem reading from socket connected to : java.nio.channels.SocketChannel[closed]
java.lang.NullPointerException
        at org.apache.cassandra.net.TcpConnection$ReadWorkItem.run(TcpConnection.java:438)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
        at java.lang.Thread.run(Thread.java:636)
INFO - Closing errored connection java.nio.channels.SocketChannel[closed]
WARN - Problem reading from socket connected to : java.nio.channels.SocketChannel[closed]
java.lang.NullPointerException
        at org.apache.cassandra.net.TcpConnection$ReadWorkItem.run(TcpConnection.java:438)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
        at java.lang.Thread.run(Thread.java:636)
INFO - Closing errored connection java.nio.channels.SocketChannel[closed]

I also bootstrapped without this patch and this traceback did not occur.

I also saw good improvement with CL.One writes with this patch.

> TcpReader is slow because of using Exception handling in the normal path
> ------------------------------------------------------------------------
>
>                 Key: CASSANDRA-675
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-675
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.9
>            Reporter: Jun Rao
>            Assignee: Jun Rao
>             Fix For: 0.9
>
>         Attachments: issue675.patchv1
>
>
> TcpReader has the overhead of 1-2ms per message reading. This makes quorum reads too slow.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.