You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudberry.apache.org by "gfphoenix78 (via GitHub)" <gi...@apache.org> on 2026/06/01 01:33:38 UTC

Re: [PR] Fix PAX CException stack overflow by pass-by-reference and shrinking … [cloudberry]

gfphoenix78 commented on code in PR #1770:
URL: https://github.com/apache/cloudberry/pull/1770#discussion_r3331275367


##########
contrib/pax_storage/src/cpp/exceptions/CException.cc:
##########
@@ -206,7 +206,7 @@ void ErrorMessage::AppendV(const char *format, va_list ap) noexcept {
 const char *ErrorMessage::Message() const noexcept { return &message_[0]; }
 int ErrorMessage::Length() const noexcept { return index_; }
 
-void CException::Raise(CException ex, bool reraise) {
+void CException::Raise(CException &ex, bool reraise) {

Review Comment:
   The internal buffer will be filled the stack trace, which should be writable.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org