You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@livy.apache.org by GitBox <gi...@apache.org> on 2019/09/26 02:36:48 UTC
[GitHub] [incubator-livy] codecov-io edited a comment on issue #231:
[LIVY-356][SERVER]Add LDAP authentication for livy-server.
codecov-io edited a comment on issue #231: [LIVY-356][SERVER]Add LDAP authentication for livy-server.
URL: https://github.com/apache/incubator-livy/pull/231#issuecomment-534468593
# [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/231?src=pr&el=h1) Report
> Merging [#231](https://codecov.io/gh/apache/incubator-livy/pull/231?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-livy/commit/b8251eb9b3d63c77c61a5950dee5958b654d9633?src=pr&el=desc) will **decrease** coverage by `0.33%`.
> The diff coverage is `50.39%`.
[](https://codecov.io/gh/apache/incubator-livy/pull/231?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #231 +/- ##
============================================
- Coverage 68.37% 68.03% -0.34%
- Complexity 921 937 +16
============================================
Files 100 101 +1
Lines 5729 5856 +127
Branches 871 889 +18
============================================
+ Hits 3917 3984 +67
- Misses 1247 1296 +49
- Partials 565 576 +11
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-livy/pull/231?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...main/scala/org/apache/livy/server/LivyServer.scala](https://codecov.io/gh/apache/incubator-livy/pull/231/diff?src=pr&el=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zZXJ2ZXIvTGl2eVNlcnZlci5zY2FsYQ==) | `32.87% <0%> (-3.09%)` | `11 <0> (ø)` | |
| [...rver/src/main/scala/org/apache/livy/LivyConf.scala](https://codecov.io/gh/apache/incubator-livy/pull/231/diff?src=pr&el=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9MaXZ5Q29uZi5zY2FsYQ==) | `95.97% <100%> (+0.1%)` | `21 <0> (ø)` | :arrow_down: |
| [...vy/server/auth/LdapAuthenticationHandlerImpl.scala](https://codecov.io/gh/apache/incubator-livy/pull/231/diff?src=pr&el=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zZXJ2ZXIvYXV0aC9MZGFwQXV0aGVudGljYXRpb25IYW5kbGVySW1wbC5zY2FsYQ==) | `55.66% <55.66%> (ø)` | `13 <13> (?)` | |
| [...ain/scala/org/apache/livy/utils/SparkYarnApp.scala](https://codecov.io/gh/apache/incubator-livy/pull/231/diff?src=pr&el=tree#diff-c2VydmVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS91dGlscy9TcGFya1lhcm5BcHAuc2NhbGE=) | `66.01% <0%> (-1.31%)` | `40% <0%> (ø)` | |
| [...ain/java/org/apache/livy/rsc/driver/RSCDriver.java](https://codecov.io/gh/apache/incubator-livy/pull/231/diff?src=pr&el=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9kcml2ZXIvUlNDRHJpdmVyLmphdmE=) | `80.08% <0%> (+2.11%)` | `43% <0%> (+2%)` | :arrow_up: |
| [...cala/org/apache/livy/scalaapi/ScalaJobHandle.scala](https://codecov.io/gh/apache/incubator-livy/pull/231/diff?src=pr&el=tree#diff-c2NhbGEtYXBpL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zY2FsYWFwaS9TY2FsYUpvYkhhbmRsZS5zY2FsYQ==) | `55.88% <0%> (+2.94%)` | `7% <0%> (ø)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-livy/pull/231?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/231?src=pr&el=footer). Last update [b8251eb...f5f79dd](https://codecov.io/gh/apache/incubator-livy/pull/231?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services