You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "dqhl76 (via GitHub)" <gi...@apache.org> on 2023/08/16 09:08:11 UTC
[GitHub] [incubator-opendal] dqhl76 opened a new pull request, #2873: misc(service/webdav): Add docker-compose file to simplify the CI
dqhl76 opened a new pull request, #2873:
URL: https://github.com/apache/incubator-opendal/pull/2873
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] dqhl76 commented on pull request #2873: refactor(service/webdav): Add docker-compose file to simplify the CI
Posted by "dqhl76 (via GitHub)" <gi...@apache.org>.
dqhl76 commented on PR #2873:
URL: https://github.com/apache/incubator-opendal/pull/2873#issuecomment-1694634846
The upstream PR https://github.com/dgraziotin/docker-nginx-webdav-nononsense/pull/95 successfully merged!
@Xuanwo All checks passed. Could you please take a look again? Thanks!
https://github.com/apache/incubator-opendal/actions/runs/5990445081/job/16247756194?pr=2873
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] dqhl76 commented on a diff in pull request #2873: refactor(service/webdav): Add docker-compose file to simplify the CI
Posted by "dqhl76 (via GitHub)" <gi...@apache.org>.
dqhl76 commented on code in PR #2873:
URL: https://github.com/apache/incubator-opendal/pull/2873#discussion_r1296048763
##########
core/src/services/webdav/fixtures/docker-compose-webdav-with-auth.yml:
##########
@@ -23,7 +23,7 @@ services:
ports:
- "8080:80"
volumes:
- - ./data:/data
+ - ./webdav-data:/data
Review Comment:
Wow, I have learnt from it https://docs.docker.com/compose/compose-file/07-volumes/#example.
Thanks for telling me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on a diff in pull request #2873: refactor(service/webdav): Add docker-compose file to simplify the CI
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #2873:
URL: https://github.com/apache/incubator-opendal/pull/2873#discussion_r1296024918
##########
core/src/services/webdav/fixtures/docker-compose-webdav-with-auth.yml:
##########
@@ -23,7 +23,7 @@ services:
ports:
- "8080:80"
volumes:
- - ./data:/data
+ - ./webdav-data:/data
Review Comment:
Hi, here is some misunderstanding.
My previous comment is `webdav-data:/data` instead of `./webdav-data:/data`. They are different behavior at docker-compose side and don't need to create a webdav-data folder by hand.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on pull request #2873: refactor(service/webdav): Add docker-compose file to simplify the CI
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on PR #2873:
URL: https://github.com/apache/incubator-opendal/pull/2873#issuecomment-1684832787
> I introduced a Dockerfile to solve the permission problem.
It's more like a upstream bug to me. I prefer to submit an issue to https://github.com/dgraziotin/docker-nginx-webdav-nononsense and fix it there.
We should create the dir and set the permission first before mark it as a volumn.
https://github.com/dgraziotin/docker-nginx-webdav-nononsense/blob/main/Dockerfile#L136-L137
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] dqhl76 commented on a diff in pull request #2873: refactor(service/webdav): Add docker-compose file to simplify the CI
Posted by "dqhl76 (via GitHub)" <gi...@apache.org>.
dqhl76 commented on code in PR #2873:
URL: https://github.com/apache/incubator-opendal/pull/2873#discussion_r1295640584
##########
core/src/services/webdav/fixtures/docker-compose-webdav-with-empty-passwd.yml:
##########
@@ -0,0 +1,29 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+version: '3.8'
+
+services:
+ webdav:
+ image: dgraziotin/nginx-webdav-nononsense
+ ports:
+ - "8080:80"
+ volumes:
+ - ./data:/data
Review Comment:
Seems removing will cause docker have problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] dqhl76 commented on pull request #2873: refactor(service/webdav): Add docker-compose file to simplify the CI
Posted by "dqhl76 (via GitHub)" <gi...@apache.org>.
dqhl76 commented on PR #2873:
URL: https://github.com/apache/incubator-opendal/pull/2873#issuecomment-1683845331
@Xuanwo Could you please take a look again?
I introduced a Dockerfile to solve the permission problem.
I was not sure if it is the perfect way to solve that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] dqhl76 commented on a diff in pull request #2873: refactor(service/webdav): Add docker-compose file to simplify the CI
Posted by "dqhl76 (via GitHub)" <gi...@apache.org>.
dqhl76 commented on code in PR #2873:
URL: https://github.com/apache/incubator-opendal/pull/2873#discussion_r1295640584
##########
core/src/services/webdav/fixtures/docker-compose-webdav-with-empty-passwd.yml:
##########
@@ -0,0 +1,29 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+version: '3.8'
+
+services:
+ webdav:
+ image: dgraziotin/nginx-webdav-nononsense
+ ports:
+ - "8080:80"
+ volumes:
+ - ./data:/data
Review Comment:
Seems removing will cause docker have problems. https://github.com/apache/incubator-opendal/actions/runs/5877080995/job/15936499613?pr=2873. Roll back firstly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] dqhl76 commented on a diff in pull request #2873: refactor(service/webdav): Add docker-compose file to simplify the CI
Posted by "dqhl76 (via GitHub)" <gi...@apache.org>.
dqhl76 commented on code in PR #2873:
URL: https://github.com/apache/incubator-opendal/pull/2873#discussion_r1296081652
##########
core/src/services/webdav/fixtures/docker-compose-webdav-with-auth.yml:
##########
@@ -23,7 +23,7 @@ services:
ports:
- "8080:80"
volumes:
- - ./data:/data
+ - ./webdav-data:/data
Review Comment:
This works, we succesfully make the image happy without manually creating new directories.
But this will cause some permission issues, I'll take a look at it tomorrow, comments are welcome!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] dqhl76 commented on a diff in pull request #2873: refact(service/webdav): Add docker-compose file to simplify the CI
Posted by "dqhl76 (via GitHub)" <gi...@apache.org>.
dqhl76 commented on code in PR #2873:
URL: https://github.com/apache/incubator-opendal/pull/2873#discussion_r1295632392
##########
core/src/services/webdav/fixtures/docker-compose-webdav-with-empty-passwd.yml:
##########
@@ -0,0 +1,29 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+version: '3.8'
+
+services:
+ webdav:
+ image: dgraziotin/nginx-webdav-nononsense
+ ports:
+ - "8080:80"
+ volumes:
+ - ./data:/data
Review Comment:
Removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on a diff in pull request #2873: refactor(service/webdav): Add docker-compose file to simplify the CI
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #2873:
URL: https://github.com/apache/incubator-opendal/pull/2873#discussion_r1295676377
##########
core/src/services/webdav/fixtures/docker-compose-webdav-with-empty-passwd.yml:
##########
@@ -0,0 +1,29 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+version: '3.8'
+
+services:
+ webdav:
+ image: dgraziotin/nginx-webdav-nononsense
+ ports:
+ - "8080:80"
+ volumes:
+ - ./data:/data
Review Comment:
We can use `webdav-data:/data` instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] dqhl76 commented on pull request #2873: refactor(service/webdav): Add docker-compose file to simplify the CI
Posted by "dqhl76 (via GitHub)" <gi...@apache.org>.
dqhl76 commented on PR #2873:
URL: https://github.com/apache/incubator-opendal/pull/2873#issuecomment-1684942749
Ok. I will open an issue on the upstream later and ask them if I can fix it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] dqhl76 commented on pull request #2873: refactor(service/webdav): Add docker-compose file to simplify the CI
Posted by "dqhl76 (via GitHub)" <gi...@apache.org>.
dqhl76 commented on PR #2873:
URL: https://github.com/apache/incubator-opendal/pull/2873#issuecomment-1691053638
wait for https://github.com/dgraziotin/docker-nginx-webdav-nononsense/pull/95
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo commented on a diff in pull request #2873: refact(service/webdav): Add docker-compose file to simplify the CI
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on code in PR #2873:
URL: https://github.com/apache/incubator-opendal/pull/2873#discussion_r1295627053
##########
core/src/services/webdav/fixtures/docker-compose-webdav-with-empty-passwd.yml:
##########
@@ -0,0 +1,29 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+version: '3.8'
+
+services:
+ webdav:
+ image: dgraziotin/nginx-webdav-nononsense
+ ports:
+ - "8080:80"
+ volumes:
+ - ./data:/data
Review Comment:
```suggestion
```
We don't need to mount `./data` into container (since we don't need to read it).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-opendal] Xuanwo merged pull request #2873: refactor(service/webdav): Add docker-compose file to simplify the CI
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo merged PR #2873:
URL: https://github.com/apache/incubator-opendal/pull/2873
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org