You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/07/15 21:31:49 UTC

[GitHub] [incubator-druid] gianm commented on issue #8084: Add more excempt tags for stalebot; Make stalebot to close PRs/issues in 21 days rather than in 7/14 days

gianm commented on issue #8084: Add more excempt tags for stalebot; Make stalebot to close PRs/issues in 21 days rather than in 7/14 days
URL: https://github.com/apache/incubator-druid/pull/8084#issuecomment-511578153
 
 
   What's the rationale behind adding this set of exempt labels? (I don't think this was well explored in the linked thread.) I think it's likely that at least one of these labels would be set by a committer on pretty much every issue and PR they touch (especially the "Area" labels but also ones like "Improvement"), which IMO defeats the purpose of the stalebot for PRs. I don't think we really want a PR to stay open forever just because someone gave it an "Area" label, but then in the end it lost momentum.
   
   If the idea is to keep _issues_ open forever with these labels (i.e. keep properly categorized issues open forever) then it would be better to exempt these labels for issues only (not PRs).
   
   The closing timeout changes (to 4 weeks) sound good to me.
   
   The committer-instructions changes look good too -- thanks.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org