You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/12/29 03:01:05 UTC
[GitHub] [skywalking-client-js] Fine0830 opened a new pull request #29: docs: update readme
Fine0830 opened a new pull request #29:
URL: https://github.com/apache/skywalking-client-js/pull/29
Update readme
Signed-off-by: Qiuxia Fan <qi...@apache.org>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-client-js] wu-sheng commented on a change in pull request #29: docs: update readme
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #29:
URL: https://github.com/apache/skywalking-client-js/pull/29#discussion_r549551938
##########
File path: README.md
##########
@@ -52,6 +52,7 @@ The register method supports the following parameters.
|enableSPA|Boolean|Monitor the page hashchange event and report PV, which is suitable for single page application scenarios|false|false|
|autoTracePerf|Boolean|Support sending of performance data automatically.|false|true|
|vue|Boolean|Support vue errors monitoring|false|true|
+Notice: In tracing data requests, the service parameter is `service + '<browser>'`.
Review comment:
This breaks the markdown. https://github.com/apache/skywalking-client-js/blob/0980bf66bf60d6a83a782b6aca9836b35b71755b/README.md
You could add this into the `service` row directly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-client-js] wu-sheng merged pull request #29: docs: update readme
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #29:
URL: https://github.com/apache/skywalking-client-js/pull/29
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org