You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by bu...@apache.org on 2016/09/22 01:07:48 UTC

[Bug 60162] New: VBAMacroReader misses macro in one test ppt

https://bz.apache.org/bugzilla/show_bug.cgi?id=60162

            Bug ID: 60162
           Summary: VBAMacroReader misses macro in one test ppt
           Product: POI
           Version: unspecified
          Hardware: PC
                OS: Windows NT
            Status: NEW
          Severity: normal
          Priority: P2
         Component: POI Overall
          Assignee: dev@poi.apache.org
          Reporter: tallison@mitre.org

Created attachment 34289
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=34289&action=edit
file from TIKA-2069

While working on TIKA-2069, I found that I wasn't able to extract macros from a
test ppt file that I generated.  May be user error in generating the test file.
 However, POI successfully extracted macros from the original 'pptm' file that
I saved as ppt.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[Bug 60162] VBAMacroReader misses macro in one test ppt

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60162

Tim Allison <ta...@mitre.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED

--- Comment #4 from Tim Allison <ta...@mitre.org> ---
Y, so it wasn't just Yegor, but just about the entire POI team already knew
this...

Thanks to Javen for pointing 59302 out to me.  Sorry for the duplicate!

*** This bug has been marked as a duplicate of bug 59302 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[Bug 60162] VBAMacroReader misses macro in one test ppt

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60162

--- Comment #1 from Tim Allison <ta...@mitre.org> ---
"Sub Embolden()" and "Sub Italicize" should show up in the text of the macros.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[Bug 60162] VBAMacroReader misses macro in one test ppt

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60162

--- Comment #3 from Tim Allison <ta...@mitre.org> ---
As always, Yegor had already figured this out:

https://bz.apache.org/bugzilla/show_bug.cgi?id=43376

:)

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[Bug 60162] VBAMacroReader misses macro in one test ppt

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=60162

--- Comment #2 from Tim Allison <ta...@mitre.org> ---
The macros are stored in a POIFS within an ExOleObjStg within the "PowerPoint
Document".  Brilliant!!! 

If you add this to the end of buildRecords() in HSLFSlideShowImpl:

        for (Record r : _records) {
            if (r.getRecordType() == 4113) {
                ExOleObjStg exOleObjStg = (ExOleObjStg) r;
                try {
                    NPOIFSFileSystem npoifs = new
POIFSFileSystem(exOleObjStg.getData());
                    VBAMacroReader reader = new VBAMacroReader(npoifs);
                    System.out.println(reader.readMacros());
                } catch (IOException e) {
                    e.printStackTrace();
                }

            }
        }

The macros are correctly read.

Recommendations for the least smelly way to extract these?  Unlike the other
document formats, this requires a full parse of the document, we can't just
pass in the parent POIFs.

Add a getMacros() to HSLFSlideShowImpl for now?

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org