[GitHub] srowen commented on a change in pull request #3497: SPARK-4170 [CORE] Closure problems when running Scala app that "extends App"

[GitBox <gi...@apache.org>]

srowen commented on a change in pull request #3497: SPARK-4170 [CORE] Closure problems when running Scala app that "extends App"
URL: https://github.com/apache/spark/pull/3497#discussion_r258483515
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala
 ##########
 @@ -345,6 +345,11 @@ object SparkSubmit {
         System.exit(CLASS_NOT_FOUND_EXIT_STATUS)
     }
 
+    // SPARK-4170
+    if (classOf[scala.App].isAssignableFrom(mainClass)) {
 
 Review comment:
   `scala.App` is a trait, not an object, and there is no `scala.App$` class in the generated bytecode. Can you clarify?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org