You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "jackwener (via GitHub)" <gi...@apache.org> on 2023/05/29 15:55:59 UTC
[GitHub] [arrow-datafusion] jackwener commented on a diff in pull request #6414: Rewrite large OR chains as IN lists
jackwener commented on code in PR #6414:
URL: https://github.com/apache/arrow-datafusion/pull/6414#discussion_r1209433928
##########
datafusion/optimizer/src/simplify_expressions/expr_simplifier.rs:
##########
@@ -325,6 +327,75 @@ impl<'a> ConstEvaluator<'a> {
}
}
+/// Combine multiple OR expressions into a single IN list expression if possible
Review Comment:
Can we put it into a new file?
Because there will be more optimization about `expression`, which will make this file very long.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org