You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/07/05 13:26:33 UTC
[GitHub] [rocketmq-connect] yhx-coder opened a new pull request, #184: Clean up duplicate methods
yhx-coder opened a new pull request, #184:
URL: https://github.com/apache/rocketmq-connect/pull/184
## What is the purpose of the change
Clean up some duplicate methods in org.apache.rocketmq.connect.runtime.connectorwrapper
## Brief changelog
both in the `startSourceTask()` and `starkSinkTask()`, `public KeyValue configs()` is redundant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Clean up duplicate methods [rocketmq-connect]
Posted by "RockteMQ-AI (via GitHub)" <gi...@apache.org>.
RockteMQ-AI commented on PR #184:
URL: https://github.com/apache/rocketmq-connect/pull/184#issuecomment-5608750261
**Issue Evaluation**
Category: `enhancement` (code cleanup) | Status: **Stale — Needs Champion**
This issue describes cleaning up duplicate methods in the codebase. Opened July 2022, no activity since.
**Assessment:**
- Code deduplication is a valid maintenance task
- The description reads more like a PR summary than an issue report
- No specific files, methods, or modules are identified for cleanup
**Recommendation:** If still relevant, please provide:
1. Specific classes/methods that contain duplicated logic
2. Proposed refactoring approach
3. Or convert this to a PR with the actual changes
If no activity occurs, this issue may be closed as stale.
---
*Automated evaluation by @RockteMQ-AI*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-connect] odbozhou merged pull request #184: Clean up duplicate methods
Posted by GitBox <gi...@apache.org>.
odbozhou merged PR #184:
URL: https://github.com/apache/rocketmq-connect/pull/184
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org