[GitHub] [airflow] eladkal commented on a diff in pull request #28950: Sensor for Databricks partition and table changes

["eladkal (via GitHub)" <gi...@apache.org>]

eladkal commented on code in PR #28950:
URL: https://github.com/apache/airflow/pull/28950#discussion_r1118152187


##########
airflow/providers/databricks/provider.yaml:
##########
@@ -92,6 +92,12 @@ hooks:
     python-modules:
       - airflow.providers.databricks.hooks.databricks_sql
 
+sensors:
+  - integration-name: Databricks SQL
+    python-modules:
+      - airflow.providers.databricks.sensors.databricks_sql
+      - airflow.providers.databricks.sensors.databricks_partition
+      - airflow.providers.databricks.sensors.databricks_table_changes

Review Comment:
   Please lets remove the `databricks_` prefix from files names (also in the tests), these files are in the databricks provider there is no need for the prefix (also to be compliant with AIP-21)



##########
docs/spelling_wordlist.txt:
##########
@@ -339,6 +339,9 @@ dask
 dat
 Databricks
 databricks
+DatabricksPartitionSensor
+DatabricksSqlSensor
+DatabricksTableChangesSensor

Review Comment:
   These are probably not necessary. Use code double quotes (like we do in other places and the doc build will pass fine)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org