Re: Review Request 11981: Adding base support for NVP security groups to the NVP API

[Amogh Vasekar <am...@citrix.com>]

> On June 20, 2013, 6:40 a.m., Prasanna Santhanam wrote:
> > Minor nitpick : our code conventions recommend the method naming to not use underscore. so it's lowerCaseAndNoUnderscores()
> > 
> > http://cloudstack.apache.org/develop/coding-conventions.html
> 
> Animesh Chaturvedi wrote:
>     Hugo can you review this patch
> 
> Chiradeep Vittal wrote:
>     Agree with Prasanna's comment.

Reminder - 

Hi,
This request has been pending for long. Please take the time to address the comments raised. Thanks!


- Amogh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11981/#review22157
-----------------------------------------------------------


On June 19, 2013, 9:28 p.m., Adrian Steer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11981/
> -----------------------------------------------------------
> 
> (Updated June 19, 2013, 9:28 p.m.)
> 
> 
> Review request for cloudstack and Hugo Trippaers.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> This is initial version of API implementation of security groups within the NVP API
> 
> 
> Diffs
> -----
> 
>   plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/LogicalSwitchPort.java c571458 
>   plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/NiciraAddressPairs.java PRE-CREATION 
>   plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/NiciraLogicalPortRule.java PRE-CREATION 
>   plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/NiciraNvpApi.java 12fa6c0 
>   plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/NiciraSecurityProfile.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/11981/diff/
> 
> 
> Testing
> -------
> 
> Compile testing
> 
> 
> Thanks,
> 
> Adrian Steer
> 
>