You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/09/22 16:38:18 UTC
[GitHub] [nifi] pvillard31 opened a new pull request #4544: NIFI-7834 - InvokeAWSGatewayAPI should not be annotated with @Trigger…
pvillard31 opened a new pull request #4544:
URL: https://github.com/apache/nifi/pull/4544
…WhenEmpty
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
#### Description of PR
_Enables X functionality; fixes bug NIFI-YYYY._
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `main`)?
- [ ] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] Have you verified that the full build is successful on JDK 8?
- [ ] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] ottobackwards commented on a change in pull request #4544: NIFI-7834 - InvokeAWSGatewayAPI should not be annotated with @Trigger…
Posted by GitBox <gi...@apache.org>.
ottobackwards commented on a change in pull request #4544:
URL: https://github.com/apache/nifi/pull/4544#discussion_r492901966
##########
File path: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/wag/InvokeAWSGatewayApi.java
##########
@@ -52,7 +51,6 @@
import java.util.UUID;
import java.util.concurrent.TimeUnit;
Review comment:
I don't understand why this isn't valid. I put this there, if I recall because you may use this processor to read the data from an api to start a flow. I thought this annotation was valid for that case. Was I mistaken?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] markap14 commented on a change in pull request #4544: NIFI-7834 - InvokeAWSGatewayAPI should not be annotated with @Trigger…
Posted by GitBox <gi...@apache.org>.
markap14 commented on a change in pull request #4544:
URL: https://github.com/apache/nifi/pull/4544#discussion_r492906992
##########
File path: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/wag/InvokeAWSGatewayApi.java
##########
@@ -52,7 +51,6 @@
import java.util.UUID;
import java.util.concurrent.TimeUnit;
Review comment:
@ottobackwards the annotation is not needed for that. The @TriggerWhenEmpty annotation is only used if you want the processor to be triggered when there is an incoming connection and the incoming connection has no data. It's rarely needed. One example of where it is needed is MergeContent. In that case, there's a timeout that is configured, and so if you have 1,000 FlowFiles come in and get batched together, but no more data comes in for 24 hours, MergeContent should still be triggered so that it can timeout the 'bin' and create the merged FlowFile.
So in this case, consider a flow like GenerateFlowFile -> InvokeAWSGatewayAPI. And GenerateFlowFile runs every 30 minutes. InvokeAWSGatewayAPI is scheduled with Run Schedule of 0 seconds because it should run immediately and constantly when there is data. But because there is a `@TriggerWhenEmpty` annotation, InvokeAWSGatewayAPI is getting triggered constantly (even when there is no data queued up) and pounding the API service, which can be both inefficient and expensive.
So if there is no incoming connection, the processor will still get triggered even without the annotation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] markap14 merged pull request #4544: NIFI-7834 - InvokeAWSGatewayAPI should not be annotated with @Trigger…
Posted by GitBox <gi...@apache.org>.
markap14 merged pull request #4544:
URL: https://github.com/apache/nifi/pull/4544
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] markap14 commented on pull request #4544: NIFI-7834 - InvokeAWSGatewayAPI should not be annotated with @Trigger…
Posted by GitBox <gi...@apache.org>.
markap14 commented on pull request #4544:
URL: https://github.com/apache/nifi/pull/4544#issuecomment-696946674
Thanks @pvillard31 , looks good to me. +1 merged to main.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] markap14 merged pull request #4544: NIFI-7834 - InvokeAWSGatewayAPI should not be annotated with @Trigger…
Posted by GitBox <gi...@apache.org>.
markap14 merged pull request #4544:
URL: https://github.com/apache/nifi/pull/4544
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] markap14 commented on pull request #4544: NIFI-7834 - InvokeAWSGatewayAPI should not be annotated with @Trigger…
Posted by GitBox <gi...@apache.org>.
markap14 commented on pull request #4544:
URL: https://github.com/apache/nifi/pull/4544#issuecomment-696946674
Thanks @pvillard31 , looks good to me. +1 merged to main.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] markap14 commented on a change in pull request #4544: NIFI-7834 - InvokeAWSGatewayAPI should not be annotated with @Trigger…
Posted by GitBox <gi...@apache.org>.
markap14 commented on a change in pull request #4544:
URL: https://github.com/apache/nifi/pull/4544#discussion_r492906992
##########
File path: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/wag/InvokeAWSGatewayApi.java
##########
@@ -52,7 +51,6 @@
import java.util.UUID;
import java.util.concurrent.TimeUnit;
Review comment:
@ottobackwards the annotation is not needed for that. The @TriggerWhenEmpty annotation is only used if you want the processor to be triggered when there is an incoming connection and the incoming connection has no data. It's rarely needed. One example of where it is needed is MergeContent. In that case, there's a timeout that is configured, and so if you have 1,000 FlowFiles come in and get batched together, but no more data comes in for 24 hours, MergeContent should still be triggered so that it can timeout the 'bin' and create the merged FlowFile.
So in this case, consider a flow like GenerateFlowFile -> InvokeAWSGatewayAPI. And GenerateFlowFile runs every 30 minutes. InvokeAWSGatewayAPI is scheduled with Run Schedule of 0 seconds because it should run immediately and constantly when there is data. But because there is a `@TriggerWhenEmpty` annotation, InvokeAWSGatewayAPI is getting triggered constantly (even when there is no data queued up) and pounding the API service, which can be both inefficient and expensive.
So if there is no incoming connection, the processor will still get triggered even without the annotation.
##########
File path: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/wag/InvokeAWSGatewayApi.java
##########
@@ -52,7 +51,6 @@
import java.util.UUID;
import java.util.concurrent.TimeUnit;
Review comment:
No worries, thanks @ottobackwards
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] markap14 commented on a change in pull request #4544: NIFI-7834 - InvokeAWSGatewayAPI should not be annotated with @Trigger…
Posted by GitBox <gi...@apache.org>.
markap14 commented on a change in pull request #4544:
URL: https://github.com/apache/nifi/pull/4544#discussion_r492911083
##########
File path: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/wag/InvokeAWSGatewayApi.java
##########
@@ -52,7 +51,6 @@
import java.util.UUID;
import java.util.concurrent.TimeUnit;
Review comment:
No worries, thanks @ottobackwards
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] ottobackwards commented on a change in pull request #4544: NIFI-7834 - InvokeAWSGatewayAPI should not be annotated with @Trigger…
Posted by GitBox <gi...@apache.org>.
ottobackwards commented on a change in pull request #4544:
URL: https://github.com/apache/nifi/pull/4544#discussion_r492901966
##########
File path: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/wag/InvokeAWSGatewayApi.java
##########
@@ -52,7 +51,6 @@
import java.util.UUID;
import java.util.concurrent.TimeUnit;
Review comment:
I don't understand why this isn't valid. I put this there, if I recall because you may use this processor to read the data from an api to start a flow. I thought this annotation was valid for that case. Was I mistaken?
##########
File path: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/wag/InvokeAWSGatewayApi.java
##########
@@ -52,7 +51,6 @@
import java.util.UUID;
import java.util.concurrent.TimeUnit;
Review comment:
Did a problem with this get reported?
##########
File path: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/wag/InvokeAWSGatewayApi.java
##########
@@ -52,7 +51,6 @@
import java.util.UUID;
import java.util.concurrent.TimeUnit;
Review comment:
Ok, I miss understood the annotation then, sorry.
+1 fwiw.
##########
File path: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/wag/InvokeAWSGatewayApi.java
##########
@@ -52,7 +51,6 @@
import java.util.UUID;
import java.util.concurrent.TimeUnit;
Review comment:
And thanks for the detailed explaination
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] ottobackwards commented on a change in pull request #4544: NIFI-7834 - InvokeAWSGatewayAPI should not be annotated with @Trigger…
Posted by GitBox <gi...@apache.org>.
ottobackwards commented on a change in pull request #4544:
URL: https://github.com/apache/nifi/pull/4544#discussion_r492910829
##########
File path: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/wag/InvokeAWSGatewayApi.java
##########
@@ -52,7 +51,6 @@
import java.util.UUID;
import java.util.concurrent.TimeUnit;
Review comment:
And thanks for the detailed explaination
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] ottobackwards commented on a change in pull request #4544: NIFI-7834 - InvokeAWSGatewayAPI should not be annotated with @Trigger…
Posted by GitBox <gi...@apache.org>.
ottobackwards commented on a change in pull request #4544:
URL: https://github.com/apache/nifi/pull/4544#discussion_r492909630
##########
File path: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/wag/InvokeAWSGatewayApi.java
##########
@@ -52,7 +51,6 @@
import java.util.UUID;
import java.util.concurrent.TimeUnit;
Review comment:
Ok, I miss understood the annotation then, sorry.
+1 fwiw.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] ottobackwards commented on a change in pull request #4544: NIFI-7834 - InvokeAWSGatewayAPI should not be annotated with @Trigger…
Posted by GitBox <gi...@apache.org>.
ottobackwards commented on a change in pull request #4544:
URL: https://github.com/apache/nifi/pull/4544#discussion_r492902281
##########
File path: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/wag/InvokeAWSGatewayApi.java
##########
@@ -52,7 +51,6 @@
import java.util.UUID;
import java.util.concurrent.TimeUnit;
Review comment:
Did a problem with this get reported?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org