[GitHub] [brooklyn-ui] algairim commented on a change in pull request #314: Adjust arc coordinates after the rotation of member-spec item

[GitBox <gi...@apache.org>]

algairim commented on a change in pull request #314:
URL: https://github.com/apache/brooklyn-ui/pull/314#discussion_r804821616



##########
File path: ui-modules/blueprint-composer/app/components/util/d3-blueprint.js
##########
@@ -831,26 +832,45 @@ export function D3Blueprint(container, options) {
 
         let relationArcs = _relationArcs.selectAll('.relation').data(arcsData, (d) => getPathId(d));
 
+        // Returns node coordinates with adjustment for member spec rotation if present.
+        const getNodeCoordinates = (entity) => {
+            let _node = nodeForEntity(entity);
+            let _x = _node.x;
+            let _y = _node.y;
+
+            if (entity.isMemberSpec()) {
+                _y += _configHolder.nodes.memberspec.circle.cy;

Review comment:
       This is what was happening before, member spec goes down on _Y_  axis by `_configHolder.nodes.memberspec.circle.cy` amount, and this becomes a radius for rotation when parent node gets a children.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org