You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org> on 2026/05/13 13:18:45 UTC
[Impala-ASF-CR] WIP IMPALA-14985 Cleanup tests with unused 'vector' in EE tests
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/24296
Change subject: WIP IMPALA-14985 Cleanup tests with unused 'vector' in EE tests
......................................................................
WIP IMPALA-14985 Cleanup tests with unused 'vector' in EE tests
Change-Id: I8e2a8fe333e33a906178a0821eb554890be26132
---
M tests/catalog_service/test_large_num_partitions.py
M tests/custom_cluster/test_codegen_cache.py
M tests/custom_cluster/test_custom_statestore.py
M tests/custom_cluster/test_disable_features.py
M tests/custom_cluster/test_external_planner.py
M tests/custom_cluster/test_hedged_reads.py
M tests/custom_cluster/test_iceberg_strict_data.py
M tests/custom_cluster/test_jvm_mem_tracking.py
M tests/custom_cluster/test_krpc_mem_usage.py
M tests/custom_cluster/test_krpc_metrics.py
M tests/custom_cluster/test_krpc_options.py
M tests/custom_cluster/test_parquet_max_page_header.py
M tests/custom_cluster/test_scheduler_locality.py
M tests/custom_cluster/test_shared_tzdb.py
M tests/custom_cluster/test_udf_concurrency.py
M tests/metadata/test_hdfs_permissions.py
M tests/metadata/test_last_ddl_time_update.py
M tests/metadata/test_metadata_query_statements.py
M tests/metadata/test_partition_metadata.py
M tests/metadata/test_recover_partitions.py
M tests/query_test/test_acid.py
M tests/query_test/test_avro_schema_resolution.py
M tests/query_test/test_cast_with_format.py
M tests/query_test/test_codegen.py
M tests/query_test/test_compressed_formats.py
M tests/query_test/test_ext_data_sources.py
M tests/query_test/test_insert_parquet.py
M tests/query_test/test_io_metrics.py
M tests/query_test/test_query_opts.py
M tests/unittests/test_result_verifier.py
30 files changed, 51 insertions(+), 51 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/24296/1
--
To view, visit http://gerrit.cloudera.org:8080/24296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8e2a8fe333e33a906178a0821eb554890be26132
Gerrit-Change-Number: 24296
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
[Impala-ASF-CR] IMPALA-14985: Cleanup tests with unused 'vector' in EE tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24296 )
Change subject: IMPALA-14985: Cleanup tests with unused 'vector' in EE tests
......................................................................
Patch Set 3: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/13485/
--
To view, visit http://gerrit.cloudera.org:8080/24296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e2a8fe333e33a906178a0821eb554890be26132
Gerrit-Change-Number: 24296
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 May 2026 13:16:44 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] WIP IMPALA-14985: Cleanup tests with unused 'vector' in EE tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24296 )
Change subject: WIP IMPALA-14985: Cleanup tests with unused 'vector' in EE tests
......................................................................
Patch Set 6:
(2 comments)
gerrit-auto-critic failed. You can reproduce it locally using command:
python3 bin/jenkins/critique-gerrit-review.py --dryrun
To run it, you might need a virtual env with Python3's venv installed.
http://gerrit.cloudera.org:8080/#/c/24296/6/tests/query_test/test_compressed_formats.py
File tests/query_test/test_compressed_formats.py:
http://gerrit.cloudera.org:8080/#/c/24296/6/tests/query_test/test_compressed_formats.py@29
PS6, Line 29: from tests.common.skip import SkipIfFS, SkipIfExploration
flake8: F401 'tests.common.skip.SkipIfFS' imported but unused
http://gerrit.cloudera.org:8080/#/c/24296/6/tests/query_test/test_join_queries.py
File tests/query_test/test_join_queries.py:
http://gerrit.cloudera.org:8080/#/c/24296/6/tests/query_test/test_join_queries.py@223
PS6, Line 223: @SkipIfExploration.is_not_exhaustive()
flake8: E302 expected 2 blank lines, found 1
--
To view, visit http://gerrit.cloudera.org:8080/24296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e2a8fe333e33a906178a0821eb554890be26132
Gerrit-Change-Number: 24296
Gerrit-PatchSet: 6
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 May 2026 21:42:34 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] WIP IMPALA-14985: Cleanup tests with unused 'vector' in EE tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24296 )
Change subject: WIP IMPALA-14985: Cleanup tests with unused 'vector' in EE tests
......................................................................
Patch Set 5:
(2 comments)
gerrit-auto-critic failed. You can reproduce it locally using command:
python3 bin/jenkins/critique-gerrit-review.py --dryrun
To run it, you might need a virtual env with Python3's venv installed.
http://gerrit.cloudera.org:8080/#/c/24296/5/tests/query_test/test_compressed_formats.py
File tests/query_test/test_compressed_formats.py:
http://gerrit.cloudera.org:8080/#/c/24296/5/tests/query_test/test_compressed_formats.py@29
PS5, Line 29: from tests.common.skip import SkipIfFS, SkipIfExploration
flake8: F401 'tests.common.skip.SkipIfFS' imported but unused
http://gerrit.cloudera.org:8080/#/c/24296/5/tests/query_test/test_join_queries.py
File tests/query_test/test_join_queries.py:
http://gerrit.cloudera.org:8080/#/c/24296/5/tests/query_test/test_join_queries.py@223
PS5, Line 223: @SkipIfExploration.is_not_exhaustive()
flake8: E302 expected 2 blank lines, found 1
--
To view, visit http://gerrit.cloudera.org:8080/24296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e2a8fe333e33a906178a0821eb554890be26132
Gerrit-Change-Number: 24296
Gerrit-PatchSet: 5
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 May 2026 21:11:38 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14985: Cleanup tests with unused 'vector' in EE tests
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24296 )
Change subject: IMPALA-14985: Cleanup tests with unused 'vector' in EE tests
......................................................................
Patch Set 3:
The only test failed was query_test.test_compressed_formats.TestLargeCompressedFile, which was actually changed and is not a known flaky test. I was unable to reproduce it and it is probably rare flakyness unrelated to this change.
--
To view, visit http://gerrit.cloudera.org:8080/24296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e2a8fe333e33a906178a0821eb554890be26132
Gerrit-Change-Number: 24296
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 May 2026 09:01:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14985 Cleanup tests with unused 'vector' in EE tests
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24296
to look at the new patch set (#2).
Change subject: IMPALA-14985 Cleanup tests with unused 'vector' in EE tests
......................................................................
IMPALA-14985 Cleanup tests with unused 'vector' in EE tests
Having 'vector' argument leads to running a test as parametrized,
so running it with multiple parameter vectors. These parameters
don't affect how queries run unless passed to functions like
run_test_case() explicitly.
Note that unused 'vector's can give the false impression of
affecting the query options of queries run by default clients
as query option CLIENT_IDENTIFIER is actually modifed based
on the parameter vector using pytest hook pytest_runtest_logstart
and connections' clear_configuration and create_connection functions.
Change-Id: I8e2a8fe333e33a906178a0821eb554890be26132
---
M tests/catalog_service/test_large_num_partitions.py
M tests/custom_cluster/test_codegen_cache.py
M tests/custom_cluster/test_custom_statestore.py
M tests/custom_cluster/test_disable_features.py
M tests/custom_cluster/test_external_planner.py
M tests/custom_cluster/test_hedged_reads.py
M tests/custom_cluster/test_iceberg_strict_data.py
M tests/custom_cluster/test_jvm_mem_tracking.py
M tests/custom_cluster/test_krpc_mem_usage.py
M tests/custom_cluster/test_krpc_metrics.py
M tests/custom_cluster/test_krpc_options.py
M tests/custom_cluster/test_parquet_max_page_header.py
M tests/custom_cluster/test_scheduler_locality.py
M tests/custom_cluster/test_shared_tzdb.py
M tests/custom_cluster/test_tuple_cache.py
M tests/custom_cluster/test_udf_concurrency.py
M tests/metadata/test_hdfs_permissions.py
M tests/metadata/test_last_ddl_time_update.py
M tests/metadata/test_metadata_query_statements.py
M tests/metadata/test_partition_metadata.py
M tests/metadata/test_recover_partitions.py
M tests/query_test/test_acid.py
M tests/query_test/test_avro_schema_resolution.py
M tests/query_test/test_cast_with_format.py
M tests/query_test/test_codegen.py
M tests/query_test/test_compressed_formats.py
M tests/query_test/test_ext_data_sources.py
M tests/query_test/test_insert_parquet.py
M tests/query_test/test_io_metrics.py
M tests/query_test/test_query_opts.py
M tests/unittests/test_result_verifier.py
31 files changed, 52 insertions(+), 52 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/24296/2
--
To view, visit http://gerrit.cloudera.org:8080/24296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8e2a8fe333e33a906178a0821eb554890be26132
Gerrit-Change-Number: 24296
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-14985: Cleanup tests with unused 'vector' in EE tests
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24296 )
Change subject: IMPALA-14985: Cleanup tests with unused 'vector' in EE tests
......................................................................
IMPALA-14985: Cleanup tests with unused 'vector' in EE tests
Having 'vector' argument leads to running a test as parametrized,
so running it with multiple parameter vectors. These parameters
don't affect how queries run unless passed to functions like
run_test_case() explicitly.
Note that unused 'vector's can give the false impression of
affecting the query options of queries run by default clients
as query option CLIENT_IDENTIFIER is actually modifed based
on the parameter vector using pytest hook pytest_runtest_logstart
and connections' clear_configuration and create_connection functions.
One example (TestIOMetrics) was found where the intention was to
pass num_nodes=1 but this didn't happen.
A test bug found during this change is that there were test classes
where "skip if not exhaustive" logic was implemented within
add_test_dimensions(), but this didn't affect non-parametrized
tests that were still run in core builds. This is fixed by
checking exploration strategy elsewhere.
The change also cleans up add_test_dimensions() functions which
are not used as the test class has no test function with
'vector' parameter.
Testing:
- passed exhaustive tests
Generated by: copilot + Claude Sonnet 4.6
Change-Id: I8e2a8fe333e33a906178a0821eb554890be26132
Reviewed-on: http://gerrit.cloudera.org:8080/24296
Reviewed-by: Noemi Pap-Takacs <np...@cloudera.com>
Tested-by: Csaba Ringhofer <cs...@cloudera.com>
---
M tests/catalog_service/test_catalog_service_client.py
M tests/catalog_service/test_large_num_partitions.py
M tests/custom_cluster/test_codegen_cache.py
M tests/custom_cluster/test_custom_statestore.py
M tests/custom_cluster/test_disable_features.py
M tests/custom_cluster/test_external_planner.py
M tests/custom_cluster/test_hedged_reads.py
M tests/custom_cluster/test_iceberg_strict_data.py
M tests/custom_cluster/test_jvm_mem_tracking.py
M tests/custom_cluster/test_krpc_mem_usage.py
M tests/custom_cluster/test_krpc_metrics.py
M tests/custom_cluster/test_krpc_options.py
M tests/custom_cluster/test_parquet_max_page_header.py
M tests/custom_cluster/test_partition.py
M tests/custom_cluster/test_permanent_udfs.py
M tests/custom_cluster/test_query_log.py
M tests/custom_cluster/test_scheduler_locality.py
M tests/custom_cluster/test_shared_tzdb.py
M tests/custom_cluster/test_sys_db.py
M tests/custom_cluster/test_tuple_cache.py
M tests/custom_cluster/test_udf_concurrency.py
M tests/metadata/test_compute_stats.py
M tests/metadata/test_hdfs_permissions.py
M tests/metadata/test_hms_integration.py
M tests/metadata/test_last_ddl_time_update.py
M tests/metadata/test_load.py
M tests/metadata/test_metadata_query_statements.py
M tests/metadata/test_partition_metadata.py
M tests/metadata/test_recover_partitions.py
M tests/metadata/test_recursive_listing.py
M tests/metadata/test_refresh_partition.py
M tests/metadata/test_reuse_partitions.py
M tests/metadata/test_show_create_table.py
M tests/metadata/test_stale_metadata.py
M tests/metadata/test_testcase_builder.py
M tests/metadata/test_views_compatibility.py
M tests/query_test/test_acid.py
M tests/query_test/test_avro_schema_resolution.py
M tests/query_test/test_cast_with_format.py
M tests/query_test/test_codegen.py
M tests/query_test/test_compressed_formats.py
M tests/query_test/test_ext_data_sources.py
M tests/query_test/test_fetch.py
M tests/query_test/test_insert.py
M tests/query_test/test_insert_parquet.py
M tests/query_test/test_io_metrics.py
M tests/query_test/test_join_queries.py
M tests/query_test/test_query_opts.py
M tests/stress/test_acid_stress.py
M tests/stress/test_ddl_stress.py
M tests/stress/test_insert_stress.py
M tests/stress/test_merge_stress.py
M tests/stress/test_update_stress.py
M tests/unittests/test_result_verifier.py
54 files changed, 79 insertions(+), 372 deletions(-)
Approvals:
Noemi Pap-Takacs: Looks good to me, approved
Csaba Ringhofer: Verified
--
To view, visit http://gerrit.cloudera.org:8080/24296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8e2a8fe333e33a906178a0821eb554890be26132
Gerrit-Change-Number: 24296
Gerrit-PatchSet: 8
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
[Impala-ASF-CR] IMPALA-14985: Cleanup tests with unused 'vector' in EE tests
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24296
to look at the new patch set (#7).
Change subject: IMPALA-14985: Cleanup tests with unused 'vector' in EE tests
......................................................................
IMPALA-14985: Cleanup tests with unused 'vector' in EE tests
Having 'vector' argument leads to running a test as parametrized,
so running it with multiple parameter vectors. These parameters
don't affect how queries run unless passed to functions like
run_test_case() explicitly.
Note that unused 'vector's can give the false impression of
affecting the query options of queries run by default clients
as query option CLIENT_IDENTIFIER is actually modifed based
on the parameter vector using pytest hook pytest_runtest_logstart
and connections' clear_configuration and create_connection functions.
One example (TestIOMetrics) was found where the intention was to
pass num_nodes=1 but this didn't happen.
A test bug found during this change is that there were test classes
where "skip if not exhaustive" logic was implemented within
add_test_dimensions(), but this didn't affect non-parametrized
tests that were still run in core builds. This is fixed by
checking exploration strategy elsewhere.
The change also cleans up add_test_dimensions() functions which
are not used as the test class has no test function with
'vector' parameter.
Testing:
- passed exhaustive tests
Generated by: copilot + Claude Sonnet 4.6
Change-Id: I8e2a8fe333e33a906178a0821eb554890be26132
---
M tests/catalog_service/test_catalog_service_client.py
M tests/catalog_service/test_large_num_partitions.py
M tests/custom_cluster/test_codegen_cache.py
M tests/custom_cluster/test_custom_statestore.py
M tests/custom_cluster/test_disable_features.py
M tests/custom_cluster/test_external_planner.py
M tests/custom_cluster/test_hedged_reads.py
M tests/custom_cluster/test_iceberg_strict_data.py
M tests/custom_cluster/test_jvm_mem_tracking.py
M tests/custom_cluster/test_krpc_mem_usage.py
M tests/custom_cluster/test_krpc_metrics.py
M tests/custom_cluster/test_krpc_options.py
M tests/custom_cluster/test_parquet_max_page_header.py
M tests/custom_cluster/test_partition.py
M tests/custom_cluster/test_permanent_udfs.py
M tests/custom_cluster/test_query_log.py
M tests/custom_cluster/test_scheduler_locality.py
M tests/custom_cluster/test_shared_tzdb.py
M tests/custom_cluster/test_sys_db.py
M tests/custom_cluster/test_tuple_cache.py
M tests/custom_cluster/test_udf_concurrency.py
M tests/metadata/test_compute_stats.py
M tests/metadata/test_hdfs_permissions.py
M tests/metadata/test_hms_integration.py
M tests/metadata/test_last_ddl_time_update.py
M tests/metadata/test_load.py
M tests/metadata/test_metadata_query_statements.py
M tests/metadata/test_partition_metadata.py
M tests/metadata/test_recover_partitions.py
M tests/metadata/test_recursive_listing.py
M tests/metadata/test_refresh_partition.py
M tests/metadata/test_reuse_partitions.py
M tests/metadata/test_show_create_table.py
M tests/metadata/test_stale_metadata.py
M tests/metadata/test_testcase_builder.py
M tests/metadata/test_views_compatibility.py
M tests/query_test/test_acid.py
M tests/query_test/test_avro_schema_resolution.py
M tests/query_test/test_cast_with_format.py
M tests/query_test/test_codegen.py
M tests/query_test/test_compressed_formats.py
M tests/query_test/test_ext_data_sources.py
M tests/query_test/test_fetch.py
M tests/query_test/test_insert.py
M tests/query_test/test_insert_parquet.py
M tests/query_test/test_io_metrics.py
M tests/query_test/test_join_queries.py
M tests/query_test/test_query_opts.py
M tests/stress/test_acid_stress.py
M tests/stress/test_ddl_stress.py
M tests/stress/test_insert_stress.py
M tests/stress/test_merge_stress.py
M tests/stress/test_update_stress.py
M tests/unittests/test_result_verifier.py
54 files changed, 79 insertions(+), 372 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/24296/7
--
To view, visit http://gerrit.cloudera.org:8080/24296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8e2a8fe333e33a906178a0821eb554890be26132
Gerrit-Change-Number: 24296
Gerrit-PatchSet: 7
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] WIP IMPALA-14985 Cleanup tests with unused 'vector' in EE tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24296 )
Change subject: WIP IMPALA-14985 Cleanup tests with unused 'vector' in EE tests
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/22407/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/24296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e2a8fe333e33a906178a0821eb554890be26132
Gerrit-Change-Number: 24296
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 May 2026 13:38:11 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] WIP IMPALA-14985: Cleanup tests with unused 'vector' in EE tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24296 )
Change subject: WIP IMPALA-14985: Cleanup tests with unused 'vector' in EE tests
......................................................................
Patch Set 6: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/24296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e2a8fe333e33a906178a0821eb554890be26132
Gerrit-Change-Number: 24296
Gerrit-PatchSet: 6
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 15 May 2026 02:06:38 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] WIP IMPALA-14985: Cleanup tests with unused 'vector' in EE tests
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24296 )
Change subject: WIP IMPALA-14985: Cleanup tests with unused 'vector' in EE tests
......................................................................
Patch Set 6: Code-Review+1
(2 comments)
http://gerrit.cloudera.org:8080/#/c/24296/6/tests/metadata/test_last_ddl_time_update.py
File tests/metadata/test_last_ddl_time_update.py:
http://gerrit.cloudera.org:8080/#/c/24296/6/tests/metadata/test_last_ddl_time_update.py@32
PS6, Line 32: if cls.exploration_strategy() != 'exhaustive' and not IS_S3:
nit: could probably be a @SkipIf condition.
http://gerrit.cloudera.org:8080/#/c/24296/6/tests/query_test/test_io_metrics.py
File tests/query_test/test_io_metrics.py:
http://gerrit.cloudera.org:8080/#/c/24296/6/tests/query_test/test_io_metrics.py@53
PS6, Line 53: query_options={'num_nodes': 1})
Does this effectively change the test?
--
To view, visit http://gerrit.cloudera.org:8080/24296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e2a8fe333e33a906178a0821eb554890be26132
Gerrit-Change-Number: 24296
Gerrit-PatchSet: 6
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 15 May 2026 15:30:19 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14985 Cleanup tests with unused 'vector' in EE tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24296 )
Change subject: IMPALA-14985 Cleanup tests with unused 'vector' in EE tests
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/22408/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/24296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e2a8fe333e33a906178a0821eb554890be26132
Gerrit-Change-Number: 24296
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 May 2026 14:13:22 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14985: Cleanup tests with unused 'vector' in EE tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24296 )
Change subject: IMPALA-14985: Cleanup tests with unused 'vector' in EE tests
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/13494/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/24296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e2a8fe333e33a906178a0821eb554890be26132
Gerrit-Change-Number: 24296
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 May 2026 19:52:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14985 Cleanup tests with unused 'vector' in EE tests
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24296 )
Change subject: IMPALA-14985 Cleanup tests with unused 'vector' in EE tests
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/24296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e2a8fe333e33a906178a0821eb554890be26132
Gerrit-Change-Number: 24296
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 May 2026 16:02:23 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] WIP IMPALA-14985 Cleanup tests with unused 'vector' in EE tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24296 )
Change subject: WIP IMPALA-14985 Cleanup tests with unused 'vector' in EE tests
......................................................................
Patch Set 1:
(1 comment)
gerrit-auto-critic failed. You can reproduce it locally using command:
python3 bin/jenkins/critique-gerrit-review.py --dryrun
To run it, you might need a virtual env with Python3's venv installed.
http://gerrit.cloudera.org:8080/#/c/24296/1/tests/query_test/test_insert_parquet.py
File tests/query_test/test_insert_parquet.py:
http://gerrit.cloudera.org:8080/#/c/24296/1/tests/query_test/test_insert_parquet.py@326
PS1, Line 326: t
flake8: U100 Unused argument 'tmpdir'
--
To view, visit http://gerrit.cloudera.org:8080/24296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e2a8fe333e33a906178a0821eb554890be26132
Gerrit-Change-Number: 24296
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 May 2026 13:21:02 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14985: Cleanup tests with unused 'vector' in EE tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24296 )
Change subject: IMPALA-14985: Cleanup tests with unused 'vector' in EE tests
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/13485/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/24296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e2a8fe333e33a906178a0821eb554890be26132
Gerrit-Change-Number: 24296
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 May 2026 09:03:02 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14985: Cleanup tests with unused 'vector' in EE tests
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24296 )
Change subject: IMPALA-14985: Cleanup tests with unused 'vector' in EE tests
......................................................................
Patch Set 7:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/24296/6/tests/metadata/test_last_ddl_time_update.py
File tests/metadata/test_last_ddl_time_update.py:
http://gerrit.cloudera.org:8080/#/c/24296/6/tests/metadata/test_last_ddl_time_update.py@32
PS6, Line 32: if cls.exploration_strategy() != 'exhaustive' and not IS_S3:
> nit: could probably be a @SkipIf condition.
I would prefer to keep it as it is for now.
There could be another patch "SkipIf rationalization" that replaces common skip conditions with SkipIf
I plan to do this for setup_class(cls) functions that do nothing else than call super and skip if not exhaustive, but could add some other changes too.
http://gerrit.cloudera.org:8080/#/c/24296/6/tests/query_test/test_io_metrics.py
File tests/query_test/test_io_metrics.py:
http://gerrit.cloudera.org:8080/#/c/24296/6/tests/query_test/test_io_metrics.py@53
PS6, Line 53: query_options={'num_nodes': 1})
> Does this effectively change the test?
Yes, now the num_nodes=1 is actually applied to the test. I agree with the original intention of making the test more stable this way.
--
To view, visit http://gerrit.cloudera.org:8080/24296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e2a8fe333e33a906178a0821eb554890be26132
Gerrit-Change-Number: 24296
Gerrit-PatchSet: 7
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 19 May 2026 11:46:46 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-14985 Cleanup tests with unused 'vector' in EE tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24296 )
Change subject: IMPALA-14985 Cleanup tests with unused 'vector' in EE tests
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/13473/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/24296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e2a8fe333e33a906178a0821eb554890be26132
Gerrit-Change-Number: 24296
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 May 2026 13:50:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14985 Cleanup tests with unused 'vector' in EE tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24296 )
Change subject: IMPALA-14985 Cleanup tests with unused 'vector' in EE tests
......................................................................
Patch Set 2: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/13473/
--
To view, visit http://gerrit.cloudera.org:8080/24296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e2a8fe333e33a906178a0821eb554890be26132
Gerrit-Change-Number: 24296
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 13 May 2026 18:26:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14985: Cleanup tests with unused 'vector' in EE tests
Posted by "Noemi Pap-Takacs (Code Review)" <ge...@cloudera.org>.
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/24296 )
Change subject: IMPALA-14985: Cleanup tests with unused 'vector' in EE tests
......................................................................
Patch Set 7: Code-Review+2
Thanks for investigating this!
--
To view, visit http://gerrit.cloudera.org:8080/24296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e2a8fe333e33a906178a0821eb554890be26132
Gerrit-Change-Number: 24296
Gerrit-PatchSet: 7
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Comment-Date: Tue, 19 May 2026 12:04:01 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] WIP IMPALA-14985: Cleanup tests with unused 'vector' in EE tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24296 )
Change subject: WIP IMPALA-14985: Cleanup tests with unused 'vector' in EE tests
......................................................................
Patch Set 6:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/22438/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/24296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e2a8fe333e33a906178a0821eb554890be26132
Gerrit-Change-Number: 24296
Gerrit-PatchSet: 6
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 May 2026 22:01:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] WIP IMPALA-14985: Cleanup tests with unused 'vector' in EE tests
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24296 )
Change subject: WIP IMPALA-14985: Cleanup tests with unused 'vector' in EE tests
......................................................................
Patch Set 6:
> The only test failed was query_test.test_compressed_formats.TestLargeCompressedFile,
> which was actually changed and is not a known flaky test. I was
> unable to reproduce it and it is probably rare flakyness unrelated
> to this change.
It turned out that this test only ran is exhaustive mode before my change as add_test_dimensions() contained the exhaustive test and it was not called for tests without vector.
My guess is that it failed in dockerized builds which had less memory, while exhaustive tests were not run as dockerized.
--
To view, visit http://gerrit.cloudera.org:8080/24296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e2a8fe333e33a906178a0821eb554890be26132
Gerrit-Change-Number: 24296
Gerrit-PatchSet: 6
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 May 2026 21:55:40 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14985: Cleanup tests with unused 'vector' in EE tests
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24296
to look at the new patch set (#3).
Change subject: IMPALA-14985: Cleanup tests with unused 'vector' in EE tests
......................................................................
IMPALA-14985: Cleanup tests with unused 'vector' in EE tests
Having 'vector' argument leads to running a test as parametrized,
so running it with multiple parameter vectors. These parameters
don't affect how queries run unless passed to functions like
run_test_case() explicitly.
Note that unused 'vector's can give the false impression of
affecting the query options of queries run by default clients
as query option CLIENT_IDENTIFIER is actually modifed based
on the parameter vector using pytest hook pytest_runtest_logstart
and connections' clear_configuration and create_connection functions.
Change-Id: I8e2a8fe333e33a906178a0821eb554890be26132
---
M tests/catalog_service/test_large_num_partitions.py
M tests/custom_cluster/test_codegen_cache.py
M tests/custom_cluster/test_custom_statestore.py
M tests/custom_cluster/test_disable_features.py
M tests/custom_cluster/test_external_planner.py
M tests/custom_cluster/test_hedged_reads.py
M tests/custom_cluster/test_iceberg_strict_data.py
M tests/custom_cluster/test_jvm_mem_tracking.py
M tests/custom_cluster/test_krpc_mem_usage.py
M tests/custom_cluster/test_krpc_metrics.py
M tests/custom_cluster/test_krpc_options.py
M tests/custom_cluster/test_parquet_max_page_header.py
M tests/custom_cluster/test_scheduler_locality.py
M tests/custom_cluster/test_shared_tzdb.py
M tests/custom_cluster/test_tuple_cache.py
M tests/custom_cluster/test_udf_concurrency.py
M tests/metadata/test_hdfs_permissions.py
M tests/metadata/test_last_ddl_time_update.py
M tests/metadata/test_metadata_query_statements.py
M tests/metadata/test_partition_metadata.py
M tests/metadata/test_recover_partitions.py
M tests/query_test/test_acid.py
M tests/query_test/test_avro_schema_resolution.py
M tests/query_test/test_cast_with_format.py
M tests/query_test/test_codegen.py
M tests/query_test/test_compressed_formats.py
M tests/query_test/test_ext_data_sources.py
M tests/query_test/test_insert_parquet.py
M tests/query_test/test_io_metrics.py
M tests/query_test/test_query_opts.py
M tests/unittests/test_result_verifier.py
31 files changed, 52 insertions(+), 52 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/24296/3
--
To view, visit http://gerrit.cloudera.org:8080/24296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8e2a8fe333e33a906178a0821eb554890be26132
Gerrit-Change-Number: 24296
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] WIP IMPALA-14985: Cleanup tests with unused 'vector' in EE tests
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24296
to look at the new patch set (#6).
Change subject: WIP IMPALA-14985: Cleanup tests with unused 'vector' in EE tests
......................................................................
WIP IMPALA-14985: Cleanup tests with unused 'vector' in EE tests
Having 'vector' argument leads to running a test as parametrized,
so running it with multiple parameter vectors. These parameters
don't affect how queries run unless passed to functions like
run_test_case() explicitly.
Note that unused 'vector's can give the false impression of
affecting the query options of queries run by default clients
as query option CLIENT_IDENTIFIER is actually modifed based
on the parameter vector using pytest hook pytest_runtest_logstart
and connections' clear_configuration and create_connection functions.
One example (TestIOMetrics) was found where the intention was to
pass num_nodes=1 but this didn't happen.
A test bug found during this change is that there were test classes
where "skip if not exhaustive" logic was implemented within
add_test_dimensions(), but this didn't affect non-parametrized
tests that were still run in core builds. This is fixed by
checking exploration strategy elsewhere.
The change also cleans up add_test_dimensions() functions which
are not used as the test class has no test function with
'vector' parameter.
TODO: no tests ran yet
Generated by: copilot + Claude Sonnet 4.6
Change-Id: I8e2a8fe333e33a906178a0821eb554890be26132
---
M tests/catalog_service/test_catalog_service_client.py
M tests/catalog_service/test_large_num_partitions.py
M tests/custom_cluster/test_codegen_cache.py
M tests/custom_cluster/test_custom_statestore.py
M tests/custom_cluster/test_disable_features.py
M tests/custom_cluster/test_external_planner.py
M tests/custom_cluster/test_hedged_reads.py
M tests/custom_cluster/test_iceberg_strict_data.py
M tests/custom_cluster/test_jvm_mem_tracking.py
M tests/custom_cluster/test_krpc_mem_usage.py
M tests/custom_cluster/test_krpc_metrics.py
M tests/custom_cluster/test_krpc_options.py
M tests/custom_cluster/test_parquet_max_page_header.py
M tests/custom_cluster/test_partition.py
M tests/custom_cluster/test_permanent_udfs.py
M tests/custom_cluster/test_query_log.py
M tests/custom_cluster/test_scheduler_locality.py
M tests/custom_cluster/test_shared_tzdb.py
M tests/custom_cluster/test_sys_db.py
M tests/custom_cluster/test_tuple_cache.py
M tests/custom_cluster/test_udf_concurrency.py
M tests/metadata/test_compute_stats.py
M tests/metadata/test_hdfs_permissions.py
M tests/metadata/test_hms_integration.py
M tests/metadata/test_last_ddl_time_update.py
M tests/metadata/test_load.py
M tests/metadata/test_metadata_query_statements.py
M tests/metadata/test_partition_metadata.py
M tests/metadata/test_recover_partitions.py
M tests/metadata/test_recursive_listing.py
M tests/metadata/test_refresh_partition.py
M tests/metadata/test_reuse_partitions.py
M tests/metadata/test_show_create_table.py
M tests/metadata/test_stale_metadata.py
M tests/metadata/test_testcase_builder.py
M tests/metadata/test_views_compatibility.py
M tests/query_test/test_acid.py
M tests/query_test/test_avro_schema_resolution.py
M tests/query_test/test_cast_with_format.py
M tests/query_test/test_codegen.py
M tests/query_test/test_compressed_formats.py
M tests/query_test/test_ext_data_sources.py
M tests/query_test/test_fetch.py
M tests/query_test/test_insert.py
M tests/query_test/test_insert_parquet.py
M tests/query_test/test_io_metrics.py
M tests/query_test/test_join_queries.py
M tests/query_test/test_query_opts.py
M tests/stress/test_acid_stress.py
M tests/stress/test_ddl_stress.py
M tests/stress/test_insert_stress.py
M tests/stress/test_merge_stress.py
M tests/stress/test_update_stress.py
M tests/unittests/test_result_verifier.py
54 files changed, 79 insertions(+), 372 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/24296/6
--
To view, visit http://gerrit.cloudera.org:8080/24296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8e2a8fe333e33a906178a0821eb554890be26132
Gerrit-Change-Number: 24296
Gerrit-PatchSet: 6
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] WIP IMPALA-14985: Cleanup tests with unused 'vector' in EE tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24296 )
Change subject: WIP IMPALA-14985: Cleanup tests with unused 'vector' in EE tests
......................................................................
Patch Set 6:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/13495/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/24296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e2a8fe333e33a906178a0821eb554890be26132
Gerrit-Change-Number: 24296
Gerrit-PatchSet: 6
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 May 2026 21:41:12 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14985: Cleanup tests with unused 'vector' in EE tests
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24296 )
Change subject: IMPALA-14985: Cleanup tests with unused 'vector' in EE tests
......................................................................
Patch Set 7: Verified+1
Thanks for the reviews!
Carrying verified +1 as last change was commit message only.
--
To view, visit http://gerrit.cloudera.org:8080/24296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e2a8fe333e33a906178a0821eb554890be26132
Gerrit-Change-Number: 24296
Gerrit-PatchSet: 7
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Comment-Date: Tue, 19 May 2026 13:19:37 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14985: Cleanup tests with unused 'vector' in EE tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24296 )
Change subject: IMPALA-14985: Cleanup tests with unused 'vector' in EE tests
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/22422/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/24296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e2a8fe333e33a906178a0821eb554890be26132
Gerrit-Change-Number: 24296
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 May 2026 09:22:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-14985: Cleanup tests with unused 'vector' in EE tests
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24296
to look at the new patch set (#4).
Change subject: IMPALA-14985: Cleanup tests with unused 'vector' in EE tests
......................................................................
IMPALA-14985: Cleanup tests with unused 'vector' in EE tests
Having 'vector' argument leads to running a test as parametrized,
so running it with multiple parameter vectors. These parameters
don't affect how queries run unless passed to functions like
run_test_case() explicitly.
Note that unused 'vector's can give the false impression of
affecting the query options of queries run by default clients
as query option CLIENT_IDENTIFIER is actually modifed based
on the parameter vector using pytest hook pytest_runtest_logstart
and connections' clear_configuration and create_connection functions.
Change-Id: I8e2a8fe333e33a906178a0821eb554890be26132
---
M tests/catalog_service/test_large_num_partitions.py
M tests/custom_cluster/test_codegen_cache.py
M tests/custom_cluster/test_custom_statestore.py
M tests/custom_cluster/test_disable_features.py
M tests/custom_cluster/test_external_planner.py
M tests/custom_cluster/test_hedged_reads.py
M tests/custom_cluster/test_iceberg_strict_data.py
M tests/custom_cluster/test_jvm_mem_tracking.py
M tests/custom_cluster/test_krpc_mem_usage.py
M tests/custom_cluster/test_krpc_metrics.py
M tests/custom_cluster/test_krpc_options.py
M tests/custom_cluster/test_parquet_max_page_header.py
M tests/custom_cluster/test_scheduler_locality.py
M tests/custom_cluster/test_shared_tzdb.py
M tests/custom_cluster/test_tuple_cache.py
M tests/custom_cluster/test_udf_concurrency.py
M tests/metadata/test_hdfs_permissions.py
M tests/metadata/test_last_ddl_time_update.py
M tests/metadata/test_metadata_query_statements.py
M tests/metadata/test_partition_metadata.py
M tests/metadata/test_recover_partitions.py
M tests/query_test/test_acid.py
M tests/query_test/test_avro_schema_resolution.py
M tests/query_test/test_cast_with_format.py
M tests/query_test/test_codegen.py
M tests/query_test/test_compressed_formats.py
M tests/query_test/test_ext_data_sources.py
M tests/query_test/test_insert_parquet.py
M tests/query_test/test_io_metrics.py
M tests/query_test/test_query_opts.py
M tests/unittests/test_result_verifier.py
31 files changed, 53 insertions(+), 52 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/24296/4
--
To view, visit http://gerrit.cloudera.org:8080/24296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8e2a8fe333e33a906178a0821eb554890be26132
Gerrit-Change-Number: 24296
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-14985: Cleanup tests with unused 'vector' in EE tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24296 )
Change subject: IMPALA-14985: Cleanup tests with unused 'vector' in EE tests
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/22432/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/24296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e2a8fe333e33a906178a0821eb554890be26132
Gerrit-Change-Number: 24296
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 May 2026 20:14:44 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] WIP IMPALA-14985: Cleanup tests with unused 'vector' in EE tests
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24296 )
Change subject: WIP IMPALA-14985: Cleanup tests with unused 'vector' in EE tests
......................................................................
Patch Set 5:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/22437/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/24296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e2a8fe333e33a906178a0821eb554890be26132
Gerrit-Change-Number: 24296
Gerrit-PatchSet: 5
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 14 May 2026 21:31:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] WIP IMPALA-14985: Cleanup tests with unused 'vector' in EE tests
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24296
to look at the new patch set (#5).
Change subject: WIP IMPALA-14985: Cleanup tests with unused 'vector' in EE tests
......................................................................
WIP IMPALA-14985: Cleanup tests with unused 'vector' in EE tests
Having 'vector' argument leads to running a test as parametrized,
so running it with multiple parameter vectors. These parameters
don't affect how queries run unless passed to functions like
run_test_case() explicitly.
Note that unused 'vector's can give the false impression of
affecting the query options of queries run by default clients
as query option CLIENT_IDENTIFIER is actually modifed based
on the parameter vector using pytest hook pytest_runtest_logstart
and connections' clear_configuration and create_connection functions.
A test bug found during this change is that there were test classes
where "skip if not exhaustive" logic was implemented within
add_test_dimensions(), but this didn't affect non-parametrized
tests that were still run in core builds. This is fixed by
checking exploration strategy elsewhere.
The change also cleansup add_test_dimensions() functions which
are not used as the test class has no test function with
'vector' parameter.
TODO: found some tests that may not run as intended and need
more investigation
Change-Id: I8e2a8fe333e33a906178a0821eb554890be26132
---
M tests/catalog_service/test_catalog_service_client.py
M tests/catalog_service/test_large_num_partitions.py
M tests/custom_cluster/test_codegen_cache.py
M tests/custom_cluster/test_custom_statestore.py
M tests/custom_cluster/test_disable_features.py
M tests/custom_cluster/test_external_planner.py
M tests/custom_cluster/test_hedged_reads.py
M tests/custom_cluster/test_iceberg_strict_data.py
M tests/custom_cluster/test_jvm_mem_tracking.py
M tests/custom_cluster/test_krpc_mem_usage.py
M tests/custom_cluster/test_krpc_metrics.py
M tests/custom_cluster/test_krpc_options.py
M tests/custom_cluster/test_parquet_max_page_header.py
M tests/custom_cluster/test_partition.py
M tests/custom_cluster/test_permanent_udfs.py
M tests/custom_cluster/test_query_log.py
M tests/custom_cluster/test_scheduler_locality.py
M tests/custom_cluster/test_shared_tzdb.py
M tests/custom_cluster/test_sys_db.py
M tests/custom_cluster/test_tuple_cache.py
M tests/custom_cluster/test_udf_concurrency.py
M tests/metadata/test_compute_stats.py
M tests/metadata/test_hdfs_permissions.py
M tests/metadata/test_hms_integration.py
M tests/metadata/test_last_ddl_time_update.py
M tests/metadata/test_load.py
M tests/metadata/test_metadata_query_statements.py
M tests/metadata/test_partition_metadata.py
M tests/metadata/test_recover_partitions.py
M tests/metadata/test_recursive_listing.py
M tests/metadata/test_refresh_partition.py
M tests/metadata/test_reuse_partitions.py
M tests/metadata/test_show_create_table.py
M tests/metadata/test_stale_metadata.py
M tests/metadata/test_testcase_builder.py
M tests/metadata/test_views_compatibility.py
M tests/query_test/test_acid.py
M tests/query_test/test_avro_schema_resolution.py
M tests/query_test/test_cast_with_format.py
M tests/query_test/test_codegen.py
M tests/query_test/test_compressed_formats.py
M tests/query_test/test_ext_data_sources.py
M tests/query_test/test_fetch.py
M tests/query_test/test_insert.py
M tests/query_test/test_insert_parquet.py
M tests/query_test/test_io_metrics.py
M tests/query_test/test_join_queries.py
M tests/query_test/test_query_opts.py
M tests/stress/test_acid_stress.py
M tests/stress/test_ddl_stress.py
M tests/stress/test_insert_stress.py
M tests/stress/test_merge_stress.py
M tests/unittests/test_result_verifier.py
53 files changed, 77 insertions(+), 350 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/24296/5
--
To view, visit http://gerrit.cloudera.org:8080/24296
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8e2a8fe333e33a906178a0821eb554890be26132
Gerrit-Change-Number: 24296
Gerrit-PatchSet: 5
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>