You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@drill.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/05/26 18:33:00 UTC
[jira] [Commented] (DRILL-8237) Limit is not pushed down to scan for MSSQL
[ https://issues.apache.org/jira/browse/DRILL-8237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17542631#comment-17542631 ]
ASF GitHub Bot commented on DRILL-8237:
---------------------------------------
vvysotskyi opened a new pull request, #2564:
URL: https://github.com/apache/drill/pull/2564
# [DRILL-8237](https://issues.apache.org/jira/browse/DRILL-8237): Limit is not pushed down to scan for MSSQL
## Description
Adjusted the cost of `DrillJdbcSort` to handle the case when the original limit was split
## Documentation
NA
## Testing
All unit tests passed, enabled disabled test which is fixed with these changes.
> Limit is not pushed down to scan for MSSQL
> ------------------------------------------
>
> Key: DRILL-8237
> URL: https://issues.apache.org/jira/browse/DRILL-8237
> Project: Apache Drill
> Issue Type: Bug
> Reporter: Vova Vysotskyi
> Assignee: Vova Vysotskyi
> Priority: Major
>
> [~dzamo] has noticed that the following test case will fail
> {code:java}
> @Test
> public void testLimitPushDownWithOffset() throws Exception {
> String query = "select person_id, first_name from mssql.dbo.person limit 100 offset 10";
> queryBuilder()
> .sql(query)
> .planMatcher()
> .include("Jdbc\\(.*SELECT TOP \\(110\\)")
> .include("Limit\\(")
> .match();
> }
> {code}
> because the limit wasn't pushed down.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)