You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@geode.apache.org by kl...@apache.org on 2016/12/20 17:52:52 UTC
geode git commit: GEODE-2167: fix
BundledJarsJUnitTest.verifyBundledJarsHaveNotChanged on Windows
Repository: geode
Updated Branches:
refs/heads/develop 7c243346e -> 4067ddcb9
GEODE-2167: fix BundledJarsJUnitTest.verifyBundledJarsHaveNotChanged on Windows
expectedJarFile path should be set on Windows properly.
* reworded commit message [klund]
* this closes #308 [klund]
Project: http://git-wip-us.apache.org/repos/asf/geode/repo
Commit: http://git-wip-us.apache.org/repos/asf/geode/commit/4067ddcb
Tree: http://git-wip-us.apache.org/repos/asf/geode/tree/4067ddcb
Diff: http://git-wip-us.apache.org/repos/asf/geode/diff/4067ddcb
Branch: refs/heads/develop
Commit: 4067ddcb9353e1c3e826ec690e9ef97cc998c2c6
Parents: 7c24334
Author: Kai Jiang <ji...@gmail.com>
Authored: Fri Dec 9 01:32:11 2016 -0800
Committer: Kirk Lund <kl...@apache.org>
Committed: Tue Dec 20 09:52:21 2016 -0800
----------------------------------------------------------------------
geode-assembly/.gitignore | 1 +
.../src/test/java/org/apache/geode/util/test/TestUtil.java | 9 +++++++--
2 files changed, 8 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/geode/blob/4067ddcb/geode-assembly/.gitignore
----------------------------------------------------------------------
diff --git a/geode-assembly/.gitignore b/geode-assembly/.gitignore
new file mode 100644
index 0000000..fb03fbe
--- /dev/null
+++ b/geode-assembly/.gitignore
@@ -0,0 +1 @@
+bundled_jars.txt
\ No newline at end of file
http://git-wip-us.apache.org/repos/asf/geode/blob/4067ddcb/geode-core/src/test/java/org/apache/geode/util/test/TestUtil.java
----------------------------------------------------------------------
diff --git a/geode-core/src/test/java/org/apache/geode/util/test/TestUtil.java b/geode-core/src/test/java/org/apache/geode/util/test/TestUtil.java
index abc51ef..927008b 100644
--- a/geode-core/src/test/java/org/apache/geode/util/test/TestUtil.java
+++ b/geode-core/src/test/java/org/apache/geode/util/test/TestUtil.java
@@ -19,6 +19,7 @@ import java.io.IOException;
import java.net.URISyntaxException;
import java.net.URL;
+import org.apache.commons.lang.SystemUtils;
import org.apache.geode.internal.FileUtil;
public class TestUtil {
@@ -46,11 +47,15 @@ public class TestUtil {
File tmpFile = File.createTempFile(filename, null);
tmpFile.deleteOnExit();
FileUtil.copy(resource, tmpFile);
- return tmpFile.getAbsolutePath();
+ return compatibleWithWindows(tmpFile.getAbsolutePath());
}
- return path;
+ return compatibleWithWindows(path);
} catch (URISyntaxException | IOException e) {
throw new RuntimeException("Failed getting path to resource " + name, e);
}
}
+
+ private static String compatibleWithWindows(String path) {
+ return SystemUtils.IS_OS_WINDOWS ? path.substring(1) : path;
+ }
}