[GitHub] [spark] cloud-fan commented on a change in pull request #27939: [SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #27939: [SPARK-31176][SQL] Remove support for 'e'/'c' as datetime pattern charactar
URL: https://github.com/apache/spark/pull/27939#discussion_r394084462
 
 

 ##########
 File path: sql/core/src/test/resources/sql-tests/inputs/datetime.sql
 ##########
 @@ -100,3 +100,10 @@ select to_timestamp("12.12342019-10-06S10:11", "ss.SSSSyyyy-MM-dd'S'HH:mm");
 select to_timestamp("12.1232019-10-06S10:11", "ss.SSSSyyyy-MM-dd'S'HH:mm");
 select to_timestamp("12.1232019-10-06S10:11", "ss.SSSSyy-MM-dd'S'HH:mm");
 select to_timestamp("12.1234019-10-06S10:11", "ss.SSSSy-MM-dd'S'HH:mm");
+
+select to_timestamp("2019-10-06S", "yyyy-MM-dd'S'");
+select to_timestamp("S2019-10-06", "'S'yyyy-MM-dd");
+
+select date_format(timestamp '2019-10-06', 'yyyy-MM-dd eeee');
+select date_format(timestamp '2019-10-06', 'yyyy-MM-dd cccc');
+select date_format(timestamp '2019-10-06', 'yyyy-MM-dd uuuu');
 
 Review comment:
   we can add a test of `uuee` to demonstrate the problem?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org