You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2022/08/31 03:13:38 UTC

[kudu-CR] WIP [tests] added one more test for soft delete table

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18932


Change subject: WIP [tests] added one more test for soft delete table
......................................................................

WIP [tests] added one more test for soft delete table

This patch adds a new MasterHmsTest.AlterAndDeleteTableWhenHmsEnabled
test scenario to check that altering and dropping table works as
expected when HMS integration is enabled after adding soft-delete
table functionality.

WIP:
  * add test to make sure `kudu table delete` works by default
    when HMS integration is enabled

Change-Id: I360d81c2f64ac07cd342ddb882aa72ee50b820bc
---
M src/kudu/integration-tests/master_hms-itest.cc
M src/kudu/master/catalog_manager.cc
2 files changed, 30 insertions(+), 6 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/32/18932/1
-- 
To view, visit http://gerrit.cloudera.org:8080/18932
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I360d81c2f64ac07cd342ddb882aa72ee50b820bc
Gerrit-Change-Number: 18932
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>

[kudu-CR] WIP [tests] added one more test for soft delete table

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.

Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/18932 )

Change subject: WIP [tests] added one more test for soft delete table
......................................................................


Patch Set 1: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18932
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I360d81c2f64ac07cd342ddb882aa72ee50b820bc
Gerrit-Change-Number: 18932
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 31 Aug 2022 03:25:50 +0000
Gerrit-HasComments: No

[kudu-CR] [tools] fix backward compatibility in `kudu table delete`

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.

Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18932 )

Change subject: [tools] fix backward compatibility in `kudu table delete`
......................................................................

[tools] fix backward compatibility in `kudu table delete`

[1] introduced incompatibility into the `kudu table delete` CLI tool
by setting --reserve_seconds to non-zero by default.  With that,
the tool started trying to soft-delete tables by default, which lead
to unexpected failures when HMS integration was enabled.

This patch addresses the issue by changing the default value of
--reserve_seconds to 0.  In addition, this patch adds a few test
scenarios to check that dropping a table works as expected when HMS
integration is enabled after the soft-delete functionality for tables
has been introduced.

This is a follow-up to [1].

[1] https://github.com/apache/kudu/commit/7b6b6b636818d3e22a3939fde77689dce84e88b2

Change-Id: I360d81c2f64ac07cd342ddb882aa72ee50b820bc
Reviewed-on: http://gerrit.cloudera.org:8080/18932
Tested-by: Kudu Jenkins
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
Reviewed-by: Attila Bukor <ab...@apache.org>
---
M src/kudu/integration-tests/master_hms-itest.cc
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_table.cc
4 files changed, 58 insertions(+), 9 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Abhishek Chennaka: Looks good to me, but someone else must approve
  Attila Bukor: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/18932
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I360d81c2f64ac07cd342ddb882aa72ee50b820bc
Gerrit-Change-Number: 18932
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>

[kudu-CR] [tools] fix backward compatibility in `kudu table delete`

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.

Hello Kudu Jenkins, Abhishek Chennaka, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18932

to look at the new patch set (#3).

Change subject: [tools] fix backward compatibility in `kudu table delete`
......................................................................

[tools] fix backward compatibility in `kudu table delete`

[1] introduced incompatibility into the `kudu table delete` CLI tool
by setting --reserve_seconds to non-zero by default.  With that,
the tool started trying to soft-delete tables by default, which lead
to unexpected failures when HMS integration was enabled.

This patch addresses the issue by changing the default value of
--reserve_seconds to 0.  In addition, this patch adds a few test
scenarios to check that dropping a table works as expected when HMS
integration is enabled after the soft-delete functionality for tables
has been introduced.

This is a follow-up to [1].

[1] https://github.com/apache/kudu/commit/7b6b6b636818d3e22a3939fde77689dce84e88b2

Change-Id: I360d81c2f64ac07cd342ddb882aa72ee50b820bc
---
M src/kudu/integration-tests/master_hms-itest.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_table.cc
3 files changed, 54 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/32/18932/3
-- 
To view, visit http://gerrit.cloudera.org:8080/18932
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I360d81c2f64ac07cd342ddb882aa72ee50b820bc
Gerrit-Change-Number: 18932
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [tests] fix backward compatibility in `kudu table delete`

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.

Hello Kudu Jenkins, Abhishek Chennaka, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18932

to look at the new patch set (#2).

Change subject: [tests] fix backward compatibility in `kudu table delete`
......................................................................

[tests] fix backward compatibility in `kudu table delete`

[1] introduced incompatibility into the `kudu table delete` CLI tool
by setting --reserve_seconds to non-zero by default.  With that,
the tool started trying to soft-delete tables by default, which lead
to unexpected failures when HMS integration was enabled.

This patch addresses the issue by changing the default value of
--reserve_seconds to 0.  In addition, this patch adds a few test
scenarios to check that dropping a table works as expected when HMS
integration is enabled after the soft-delete functionality for tables
has been introduced.

This is a follow-up to [1].

[1] https://github.com/apache/kudu/commit/7b6b6b636818d3e22a3939fde77689dce84e88b2

Change-Id: I360d81c2f64ac07cd342ddb882aa72ee50b820bc
---
M src/kudu/integration-tests/master_hms-itest.cc
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool_action_table.cc
3 files changed, 54 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/32/18932/2
-- 
To view, visit http://gerrit.cloudera.org:8080/18932
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I360d81c2f64ac07cd342ddb882aa72ee50b820bc
Gerrit-Change-Number: 18932
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [tools] fix backward compatibility in `kudu table delete`

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.

Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18932 )

Change subject: [tools] fix backward compatibility in `kudu table delete`
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18932
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I360d81c2f64ac07cd342ddb882aa72ee50b820bc
Gerrit-Change-Number: 18932
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Tue, 06 Sep 2022 17:50:47 +0000
Gerrit-HasComments: No

[kudu-CR] [tools] fix backward compatibility in `kudu table delete`

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.

Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/18932 )

Change subject: [tools] fix backward compatibility in `kudu table delete`
......................................................................


Patch Set 3: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18932
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I360d81c2f64ac07cd342ddb882aa72ee50b820bc
Gerrit-Change-Number: 18932
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Wed, 31 Aug 2022 04:43:01 +0000
Gerrit-HasComments: No

[kudu-CR] [tools] fix backward compatibility in `kudu table delete`

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.

Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/18932 )

Change subject: [tools] fix backward compatibility in `kudu table delete`
......................................................................


Patch Set 4: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18932
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I360d81c2f64ac07cd342ddb882aa72ee50b820bc
Gerrit-Change-Number: 18932
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Comment-Date: Thu, 01 Sep 2022 04:01:57 +0000
Gerrit-HasComments: No