You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Praveen Adlakha <ad...@gmail.com> on 2015/12/31 12:32:47 UTC
Review Request 41830: dependency API sets totalResults as 0 by default
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41830/
-----------------------------------------------------------
Review request for Falcon.
Bugs: falcon-1710
https://issues.apache.org/jira/browse/falcon-1710
Repository: falcon-git
Description
-------
dependency API sets totalResults as 0 by default
Diffs
-----
client/src/main/java/org/apache/falcon/resource/EntityList.java f581691
Diff: https://reviews.apache.org/r/41830/diff/
Testing
-------
dataqa@blr-test-129:/usr/local/falcon/falcon-0.9-SNAPSHOT$ bin/falcon entity -type process -name DWH-CI-daily-supply2 -dependency
2
(feed) feed1 - [Input]
(cluster) local
Thanks,
Praveen Adlakha
Re: Review Request 41830: dependency API sets totalResults as 0 by
default
Posted by pavan kumar kolamuri <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41830/#review112501
-----------------------------------------------------------
client/src/main/java/org/apache/falcon/resource/EntityList.java (line 144)
<https://reviews.apache.org/r/41830/#comment172957>
Yes, these small things can be easily caught if we have unit tests on this.
- pavan kumar kolamuri
On Dec. 31, 2015, 11:32 a.m., Praveen Adlakha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41830/
> -----------------------------------------------------------
>
> (Updated Dec. 31, 2015, 11:32 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: falcon-1710
> https://issues.apache.org/jira/browse/falcon-1710
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> dependency API sets totalResults as 0 by default
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/falcon/resource/EntityList.java f581691
>
> Diff: https://reviews.apache.org/r/41830/diff/
>
>
> Testing
> -------
>
> dataqa@blr-test-129:/usr/local/falcon/falcon-0.9-SNAPSHOT$ bin/falcon entity -type process -name DWH-CI-daily-supply2 -dependency
> 2
> (feed) feed1 - [Input]
> (cluster) local
>
>
> Thanks,
>
> Praveen Adlakha
>
>
Re: Review Request 41830: dependency API sets totalResults as 0 by
default
Posted by Pallavi Rao <pa...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41830/#review112492
-----------------------------------------------------------
client/src/main/java/org/apache/falcon/resource/EntityList.java (line 144)
<https://reviews.apache.org/r/41830/#comment172939>
Patch looks good. Can you also update the UT, EntityManagerTest.testGetEntityList() to add the length check? Might need to add a getter for totalResults.
- Pallavi Rao
On Dec. 31, 2015, 11:32 a.m., Praveen Adlakha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41830/
> -----------------------------------------------------------
>
> (Updated Dec. 31, 2015, 11:32 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: falcon-1710
> https://issues.apache.org/jira/browse/falcon-1710
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> dependency API sets totalResults as 0 by default
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/falcon/resource/EntityList.java f581691
>
> Diff: https://reviews.apache.org/r/41830/diff/
>
>
> Testing
> -------
>
> dataqa@blr-test-129:/usr/local/falcon/falcon-0.9-SNAPSHOT$ bin/falcon entity -type process -name DWH-CI-daily-supply2 -dependency
> 2
> (feed) feed1 - [Input]
> (cluster) local
>
>
> Thanks,
>
> Praveen Adlakha
>
>
Re: Review Request 41830: dependency API sets totalResults as 0 by
default
Posted by Pallavi Rao <pa...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41830/#review112806
-----------------------------------------------------------
Ship it!
Ship It!
- Pallavi Rao
On Jan. 5, 2016, 9:39 a.m., Praveen Adlakha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41830/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2016, 9:39 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: falcon-1710
> https://issues.apache.org/jira/browse/falcon-1710
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> dependency API sets totalResults as 0 by default
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/falcon/resource/EntityList.java f581691
> prism/src/test/java/org/apache/falcon/resource/EntityManagerTest.java 99a537d
>
> Diff: https://reviews.apache.org/r/41830/diff/
>
>
> Testing
> -------
>
> dataqa@blr-test-129:/usr/local/falcon/falcon-0.9-SNAPSHOT$ bin/falcon entity -type process -name DWH-CI-daily-supply2 -dependency
> 2
> (feed) feed1 - [Input]
> (cluster) local
>
>
> Thanks,
>
> Praveen Adlakha
>
>
Re: Review Request 41830: dependency API sets totalResults as 0 by
default
Posted by Balu Vellanki <bv...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41830/#review112938
-----------------------------------------------------------
Ship it!
Ship It!
- Balu Vellanki
On Jan. 5, 2016, 9:39 a.m., Praveen Adlakha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41830/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2016, 9:39 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: falcon-1710
> https://issues.apache.org/jira/browse/falcon-1710
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> dependency API sets totalResults as 0 by default
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/falcon/resource/EntityList.java f581691
> prism/src/test/java/org/apache/falcon/resource/EntityManagerTest.java 99a537d
>
> Diff: https://reviews.apache.org/r/41830/diff/
>
>
> Testing
> -------
>
> dataqa@blr-test-129:/usr/local/falcon/falcon-0.9-SNAPSHOT$ bin/falcon entity -type process -name DWH-CI-daily-supply2 -dependency
> 2
> (feed) feed1 - [Input]
> (cluster) local
>
>
> Thanks,
>
> Praveen Adlakha
>
>
Re: Review Request 41830: dependency API sets totalResults as 0 by
default
Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41830/#review112859
-----------------------------------------------------------
Ship it!
Ship It!
- Ajay Yadava
On Jan. 5, 2016, 9:39 a.m., Praveen Adlakha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41830/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2016, 9:39 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: falcon-1710
> https://issues.apache.org/jira/browse/falcon-1710
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> dependency API sets totalResults as 0 by default
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/falcon/resource/EntityList.java f581691
> prism/src/test/java/org/apache/falcon/resource/EntityManagerTest.java 99a537d
>
> Diff: https://reviews.apache.org/r/41830/diff/
>
>
> Testing
> -------
>
> dataqa@blr-test-129:/usr/local/falcon/falcon-0.9-SNAPSHOT$ bin/falcon entity -type process -name DWH-CI-daily-supply2 -dependency
> 2
> (feed) feed1 - [Input]
> (cluster) local
>
>
> Thanks,
>
> Praveen Adlakha
>
>
Re: Review Request 41830: dependency API sets totalResults as 0 by
default
Posted by Praveen Adlakha <ad...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41830/
-----------------------------------------------------------
(Updated Jan. 5, 2016, 9:39 a.m.)
Review request for Falcon.
Bugs: falcon-1710
https://issues.apache.org/jira/browse/falcon-1710
Repository: falcon-git
Description
-------
dependency API sets totalResults as 0 by default
Diffs (updated)
-----
client/src/main/java/org/apache/falcon/resource/EntityList.java f581691
prism/src/test/java/org/apache/falcon/resource/EntityManagerTest.java 99a537d
Diff: https://reviews.apache.org/r/41830/diff/
Testing
-------
dataqa@blr-test-129:/usr/local/falcon/falcon-0.9-SNAPSHOT$ bin/falcon entity -type process -name DWH-CI-daily-supply2 -dependency
2
(feed) feed1 - [Input]
(cluster) local
Thanks,
Praveen Adlakha