[jira] [Commented] (OPENJPA-2733) Subquery parameters are incorrectly assigned

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OPENJPA-2733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16768288#comment-16768288 ] 

ASF subversion and git services commented on OPENJPA-2733:
----------------------------------------------------------

Commit 80736f6e9d38dfb180c89cec6cb2916341165a5c in openjpa's branch refs/heads/master from Mark Struberg
[ https://gitbox.apache.org/repos/asf?p=openjpa.git;h=80736f6 ]

OPENJPA-2733 subquery parameters are incorrectly assigned

patch submitted by Pawel Veselov - thanks!


> Subquery parameters are incorrectly assigned
> --------------------------------------------
>
>                 Key: OPENJPA-2733
>                 URL: https://issues.apache.org/jira/browse/OPENJPA-2733
>             Project: OpenJPA
>          Issue Type: Bug
>          Components: kernel
>    Affects Versions: 2.4.2
>            Reporter: Pawel Veselov
>            Assignee: Mark Struberg
>            Priority: Major
>         Attachments: 1.diff
>
>
> When parameters are used both outside and inside a sub-query, the parameter values are overwritten by other parameters.
> I did write up a test case, and provided *a* patch, but this patch has problems with replacing where clauses. Once a where clause is replaced, in either the root, or a sub query, params have to be cleaned up, but that doesn't clear out the _where property, which means they will not be rebuilt. But there are no tests that would catch that so far. That probably should be an extension of TestEdit#testEditParameterizedPredicateRemoved



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)