You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/04 16:26:56 UTC

[GitHub] [arrow] Dandandan commented on pull request #9090: ARROW-11123: [Rust] Use cast kernel to simplify csv parser

Dandandan commented on pull request #9090:
URL: https://github.com/apache/arrow/pull/9090#issuecomment-754074455


   I think this needs to be done to fully implement this PR:
   
   - [ ] Implement cast that returns an error on parsing errors instead of null
   - [ ] Implement `cast(utf8, bool)` to remove remaining parser function
   - [ ] Some (cast) / stringarray ( https://github.com/apache/arrow/pull/9016 ) perf. improvements to avoid performance hit
   
   I think an eventual performance benefit is that it makes it easier to get rid of the (slow) `StringRecord` eventually as we can just load bytes on the go, maybe we could even directly append to the array as a buffer without intermediate copies and extra allocations as we do currently.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org