[GitHub] elek commented on a change in pull request #462: HDDS-764. Run S3 smoke tests with replication STANDARD.

[GitBox <gi...@apache.org>]

elek commented on a change in pull request #462: HDDS-764. Run S3 smoke tests with replication STANDARD.
URL: https://github.com/apache/hadoop/pull/462#discussion_r249377544
 
 

 ##########
 File path: hadoop-ozone/dist/src/main/smoketest/test.sh
 ##########
 @@ -24,6 +23,41 @@ mkdir -p "$DIR/$RESULT_DIR"
 #Should be writeable from the docker containers where user is different.
 chmod ogu+w "$DIR/$RESULT_DIR"
 
+## @description wait until 3 datanodes are up (or 30 seconds)
+## @param the docker-compose file
+wait_for_datanodes(){
+
+  #Reset the timer
+  SECONDS=0
+
+  #Don't give it up until 30 seconds
 
 Review comment:
   I think it's fine. the value of sleep is independent as we check the elapsed time based on the $SLEEP environment variable. It will iterate at every 2 seconds until 30 seconds  (If I didn't miss something)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org