You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "yzeng1618 (via GitHub)" <gi...@apache.org> on 2026/01/23 01:18:22 UTC

[PR] [Feature][Iceberg] Support schema.partition_keys and ${partition_keys} placeholder [seatunnel]

yzeng1618 opened a new pull request, #10389:
URL: https://github.com/apache/seatunnel/pull/10389

   
   <!--
   
   Thank you for contributing to SeaTunnel! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   ## Contribution Checklist
     - Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/seatunnel/issues).
     - Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
     - Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
   -->
   
   ### Purpose of this pull request
   
   <!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
   
   This pull request implements apache/seatunnel#10379 by introducing schema.partition_keys for multi-table jobs and allowing Iceberg sink to inject per-table partition keys via placeholder ${partition_keys}.
   It also fixes partition key parsing in Iceberg sink to correctly handle Iceberg transform expressions containing commas (e.g. bucket(id, 16), truncate(col, 8)), avoiding incorrect splits.
   
   Example:
   
   - Source schema: partition_keys=["bucket(c_bigint, 16)","c_timestamp"]
   
   - Iceberg sink: iceberg.table.partition-keys="${partition_keys}"
   
   ### Does this PR introduce _any_ user-facing change?
   Yes.
   
   - New schema field: schema.partition_keys (List<String>).
   
   - New sink placeholder: ${partition_keys} for resolving per-table partition keys.
   
   - Iceberg sink now parses partition keys safely when expressions include commas inside parentheses.
   
   <!--
   Note that it means *any* user-facing change including all aspects such as the documentation fix.
   If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
   If possible, please also clarify if this is a user-facing change compared to the released SeaTunnel versions or within the unreleased branches such as dev.
   If no, write 'No'.
   If you are adding/modifying connector documents, please follow our new specifications: https://github.com/apache/seatunnel/issues/4544.
   -->
   
   
   ### How was this patch tested?
   
   - Unit tests:CatalogTableUtilTest,TablePlaceholderProcessorTest,IcebergSinkConfigTest
   
   - E2E test added :fake_to_iceberg_with_partition_keys_placeholder.conf
   
   
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   If you are adding E2E test cases, maybe refer to https://github.com/apache/seatunnel/blob/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-cdc-mysql-e2e/src/test/resources/mysqlcdc_to_mysql.conf, here is a good example.
   -->
   
   
   ### Check list
   
   * [ ] If any new Jar binary package adding in your PR, please add License Notice according
     [New License Guide](https://github.com/apache/seatunnel/blob/dev/docs/en/contribution/new-license.md)
   * [ * ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/seatunnel/tree/dev/docs
   * [ ] If necessary, please update `incompatible-changes.md` to describe the incompatibility caused by this PR.
   * [ ] If you are contributing the connector code, please check that the following files are updated:
     1. Update [plugin-mapping.properties](https://github.com/apache/seatunnel/blob/dev/plugin-mapping.properties) and add new connector information in it
     2. Update the pom file of [seatunnel-dist](https://github.com/apache/seatunnel/blob/dev/seatunnel-dist/pom.xml)
     3. Add ci label in [label-scope-conf](https://github.com/apache/seatunnel/blob/dev/.github/workflows/labeler/label-scope-conf.yml)
     4. Add e2e testcase in [seatunnel-e2e](https://github.com/apache/seatunnel/tree/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/)
     5. Update connector [plugin_config](https://github.com/apache/seatunnel/blob/dev/config/plugin_config)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Feature][Iceberg] Support schema.partition_keys and ${partition_keys} placeholder [seatunnel]

Posted by "yzeng1618 (via GitHub)" <gi...@apache.org>.
yzeng1618 commented on code in PR #10389:
URL: https://github.com/apache/seatunnel/pull/10389#discussion_r2719857396


##########
seatunnel-api/src/main/java/org/apache/seatunnel/api/sink/TablePlaceholderProcessor.java:
##########
@@ -190,6 +202,12 @@ public static ReadonlyConfig replaceTablePlaceholder(
                                         + "}")) {
                             strValue = replaceTableFieldNames(strValue, table.getTableSchema());
                             listValue = Arrays.asList(strValue.split(FIELD_DELIMITER));
+                        } else if (strValue.equals(
+                                "${"
+                                        + TablePlaceholder.REPLACE_PARTITION_KEYS_KEY
+                                                .getPlaceholder()
+                                        + "}")) {
+                            listValue = new ArrayList<>(table.getPartitionKeys());

Review Comment:
   The issues mentioned have been fixed.



##########
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-iceberg-e2e/src/test/java/org/apache/seatunnel/e2e/connector/iceberg/IcebergSinkIT.java:
##########
@@ -127,8 +154,13 @@ private List<Record> loadIcebergTable() {
         IcebergTableLoader tableLoader =
                 IcebergTableLoader.create(new IcebergSourceConfig(ReadonlyConfig.fromMap(configs)));
         tableLoader.open();
+        return tableLoader.loadTable();

Review Comment:
   The issues mentioned have been fixed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Feature][Iceberg] Support schema.partition_keys and ${partition_keys} placeholder [seatunnel]

Posted by "davidzollo (via GitHub)" <gi...@apache.org>.
davidzollo merged PR #10389:
URL: https://github.com/apache/seatunnel/pull/10389


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Feature][Iceberg] Support schema.partition_keys and ${partition_keys} placeholder [seatunnel]

Posted by "krutoileshii (via GitHub)" <gi...@apache.org>.
krutoileshii commented on PR #10389:
URL: https://github.com/apache/seatunnel/pull/10389#issuecomment-3793663157

   > > @yzeng1618 Awesome!. Didn't expect anyone to do this so quick.
   > > Do have a question, would it be beneficial to add one for bloom_filter columns like parquet_bloom_filter_columns or orc_bloom_filter_columns?
   > 
   > This is a good question. Bloom filter-related columns are more specific parameters at the file format/storage layer, rather than generic table metadata. This PR focuses on the generic schema.partition_keys and the ${partition_keys} placeholder.
   
   Agreed, just not sure there is a better place for it than the table schema config. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Feature][Iceberg] Support schema.partition_keys and ${partition_keys} placeholder [seatunnel]

Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #10389:
URL: https://github.com/apache/seatunnel/pull/10389#discussion_r2719396417


##########
seatunnel-api/src/main/java/org/apache/seatunnel/api/sink/TablePlaceholderProcessor.java:
##########
@@ -190,6 +202,12 @@ public static ReadonlyConfig replaceTablePlaceholder(
                                         + "}")) {
                             strValue = replaceTableFieldNames(strValue, table.getTableSchema());
                             listValue = Arrays.asList(strValue.split(FIELD_DELIMITER));
+                        } else if (strValue.equals(
+                                "${"
+                                        + TablePlaceholder.REPLACE_PARTITION_KEYS_KEY
+                                                .getPlaceholder()
+                                        + "}")) {
+                            listValue = new ArrayList<>(table.getPartitionKeys());

Review Comment:
   In the List-valued placeholder branch, `${partition_keys}` is always replaced with `table.getPartitionKeys()` (which can be an empty list when upstream schema doesn’t specify partition_keys). This is inconsistent with the String placeholder behavior (which leaves the placeholder unchanged when partition keys are empty) and with other placeholders like `${primary_key}`/`${unique_key}` (which remain unresolved when metadata is missing). Consider only performing this replacement when partition keys are non-empty, or otherwise leaving the placeholder as-is / honoring a default expression, to avoid silently converting a missing metadata value into an empty list.
   ```suggestion
                               List<String> partitionKeys = table.getPartitionKeys();
                               if (partitionKeys != null && !partitionKeys.isEmpty()) {
                                   listValue = new ArrayList<>(partitionKeys);
                               }
   ```



##########
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-iceberg-e2e/src/test/java/org/apache/seatunnel/e2e/connector/iceberg/IcebergSinkIT.java:
##########
@@ -127,8 +154,13 @@ private List<Record> loadIcebergTable() {
         IcebergTableLoader tableLoader =
                 IcebergTableLoader.create(new IcebergSourceConfig(ReadonlyConfig.fromMap(configs)));
         tableLoader.open();
+        return tableLoader.loadTable();

Review Comment:
   `loadIcebergTableObject()` opens an `IcebergTableLoader` (which implements `Closeable`) but never closes it. Over repeated calls/tests this can leak resources (catalog/file handles) inside the container JVM. Consider using try-with-resources around the loader (or closing it in a finally block) after `loadTable()` returns.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Feature][Iceberg] Support schema.partition_keys and ${partition_keys} placeholder [seatunnel]

Posted by "yzeng1618 (via GitHub)" <gi...@apache.org>.
yzeng1618 commented on PR #10389:
URL: https://github.com/apache/seatunnel/pull/10389#issuecomment-3793654725

   > @yzeng1618 Awesome!. Didn't expect anyone to do this so quick.
   > 
   > Do have a question, would it be beneficial to add one for bloom_filter columns like parquet_bloom_filter_columns or orc_bloom_filter_columns?
   
   This is a good question. Bloom filter-related columns are more specific parameters at the file format/storage layer, rather than generic table metadata. This PR focuses on the generic schema.partition_keys and the ${partition_keys} placeholder.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Feature][Iceberg] Support schema.partition_keys and ${partition_keys} placeholder [seatunnel]

Posted by "krutoileshii (via GitHub)" <gi...@apache.org>.
krutoileshii commented on PR #10389:
URL: https://github.com/apache/seatunnel/pull/10389#issuecomment-3793357768

   @yzeng1618 Awesome!. Didn't expect anyone to do this so quick.
   
   Do have a question, would it be beneficial to add one for bloom_filter columns like parquet_bloom_filter_columns or orc_bloom_filter_columns?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org