You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/28 07:26:42 UTC

[GitHub] [pulsar-site] lhotari commented on a diff in pull request #234: fix release shell and replace gh readonly token

lhotari commented on code in PR #234:
URL: https://github.com/apache/pulsar-site/pull/234#discussion_r982037690


##########
site2/tools/release-json-gen.sh:
##########
@@ -51,12 +51,12 @@ do
 done
 
 # gh auth login, ref: https://github.com/apache/pulsar-site/blob/760f7b47f437267a3c9d71d14c73e99ba32bd1ec/site2/website-next/scripts/release-notes.sh#L31-L33
-echo "$GH_TOKEN" > "$TOKEN_FILE"
+echo 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 > "$TOKEN_FILE"

Review Comment:
   @urfreespace you should never store tokens in git. Please make sure to invalidate this token immediately.  /Cc @Anonymitaet @tisonkun @codelipenghui 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org