You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openoffice.apache.org by GitBox <gi...@apache.org> on 2020/08/21 19:08:46 UTC

[GitHub] [openoffice] DonLewisFreeBSD opened a new pull request #92: AOO418 openssl upgrade

DonLewisFreeBSD opened a new pull request #92:
URL: https://github.com/apache/openoffice/pull/92


   Upgrade to openssl-1.0.2t.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org

Re: [GitHub] [openoffice] Pilot-Pirx commented on pull request #92: AOO418 openssl upgrade

Posted by Don Lewis <tr...@apache.org>.
On 21 Aug, Don Lewis wrote:
> On 22 Aug, Matthias Seidel wrote:
>> Am 21.08.20 um 23:55 schrieb Don Lewis:
>>> On 21 Aug, GitBox wrote:
>>>> Pilot-Pirx commented on pull request #92:
>>>> URL: https://github.com/apache/openoffice/pull/92#issuecomment-678517434
>>>>
>>>>
>>>>    Shouldn't that be 1.0.2t in /main/openssl/version.mk?
>>>>    (The same applies to trunks and AOO42X)
>>> Probably if it's actually used anywhere.
>> 
>> It was updated to 1.0.2h in the first step.
>> When updating to 1.0.2p and then to 1.0.2t the file was somehow forgotten.
>> 
>> I don't think that it is really used but just for conformity it should
>> reflect the actual version.
>> 
>> If there are no objections I would make the changes...
> 
> I'm wondering if version.mk is even included anywhere.  It gets
> delivered, so that would need to be fixed as well if we delete it the
> file.

If I remove main/openssl/version.mk and apply the following patch, I can
build trunk on debian:

diff --git a/main/openssl/prj/d.lst b/main/openssl/prj/d.lst
index 72065853d7..6b67f0fefc 100644
--- a/main/openssl/prj/d.lst
+++ b/main/openssl/prj/d.lst
@@ -1,6 +1,5 @@
 mkdir: %_DEST%\inc%_EXT%\external
 mkdir: %_DEST%\inc%_EXT%\external\openssl
-..\version.mk %_DEST%\inc%_EXT%\external\openssl\version.mk
 ..\%__SRC%\inc\*.h %_DEST%\inc%_EXT%\external\openssl
 ..\%__SRC%\lib\ssleay32.lib %_DEST%\lib%_EXT%\ssleay32.lib
 ..\%__SRC%\bin\ssleay32.dll %_DEST%\bin%_EXT%\ssleay32.dll


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org

Re: [GitHub] [openoffice] Pilot-Pirx commented on pull request #92: AOO418 openssl upgrade

Posted by Don Lewis <tr...@apache.org>.
On 22 Aug, Matthias Seidel wrote:
> Am 21.08.20 um 23:55 schrieb Don Lewis:
>> On 21 Aug, GitBox wrote:
>>> Pilot-Pirx commented on pull request #92:
>>> URL: https://github.com/apache/openoffice/pull/92#issuecomment-678517434
>>>
>>>
>>>    Shouldn't that be 1.0.2t in /main/openssl/version.mk?
>>>    (The same applies to trunks and AOO42X)
>> Probably if it's actually used anywhere.
> 
> It was updated to 1.0.2h in the first step.
> When updating to 1.0.2p and then to 1.0.2t the file was somehow forgotten.
> 
> I don't think that it is really used but just for conformity it should
> reflect the actual version.
> 
> If there are no objections I would make the changes...

I'm wondering if version.mk is even included anywhere.  It gets
delivered, so that would need to be fixed as well if we delete it the
file.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org

Re: [GitHub] [openoffice] Pilot-Pirx commented on pull request #92: AOO418 openssl upgrade

Posted by Matthias Seidel <ma...@hamburg.de>.
Am 21.08.20 um 23:55 schrieb Don Lewis:
> On 21 Aug, GitBox wrote:
>> Pilot-Pirx commented on pull request #92:
>> URL: https://github.com/apache/openoffice/pull/92#issuecomment-678517434
>>
>>
>>    Shouldn't that be 1.0.2t in /main/openssl/version.mk?
>>    (The same applies to trunks and AOO42X)
> Probably if it's actually used anywhere.

It was updated to 1.0.2h in the first step.
When updating to 1.0.2p and then to 1.0.2t the file was somehow forgotten.

I don't think that it is really used but just for conformity it should
reflect the actual version.

If there are no objections I would make the changes...

>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
> For additional commands, e-mail: dev-help@openoffice.apache.org
>

Re: [GitHub] [openoffice] Pilot-Pirx commented on pull request #92: AOO418 openssl upgrade

Posted by Don Lewis <tr...@apache.org>.
On 21 Aug, GitBox wrote:
> 
> Pilot-Pirx commented on pull request #92:
> URL: https://github.com/apache/openoffice/pull/92#issuecomment-678517434
> 
> 
>    Shouldn't that be 1.0.2t in /main/openssl/version.mk?
>    (The same applies to trunks and AOO42X)

Probably if it's actually used anywhere.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org

[GitHub] [openoffice] Pilot-Pirx commented on pull request #92: AOO418 openssl upgrade

Posted by GitBox <gi...@apache.org>.
Pilot-Pirx commented on pull request #92:
URL: https://github.com/apache/openoffice/pull/92#issuecomment-678517434


   Shouldn't that be 1.0.2t in /main/openssl/version.mk?
   (The same applies to trunks and AOO42X)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org

[GitHub] [openoffice] Pilot-Pirx edited a comment on pull request #92: AOO418 openssl upgrade

Posted by GitBox <gi...@apache.org>.
Pilot-Pirx edited a comment on pull request #92:
URL: https://github.com/apache/openoffice/pull/92#issuecomment-678517434


   Shouldn't that be 1.0.2t in /main/openssl/version.mk?
   (The same applies to trunk and AOO42X)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org

[GitHub] [openoffice] DonLewisFreeBSD merged pull request #92: AOO418 openssl upgrade

Posted by GitBox <gi...@apache.org>.
DonLewisFreeBSD merged pull request #92:
URL: https://github.com/apache/openoffice/pull/92


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org