You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by si...@apache.org on 2019/10/03 16:31:24 UTC
[pulsar] branch master updated: [pulsar-proxy] add debug log + fix
thread-factory name (#5302)
This is an automated email from the ASF dual-hosted git repository.
sijie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push:
new ab8db2d [pulsar-proxy] add debug log + fix thread-factory name (#5302)
ab8db2d is described below
commit ab8db2d48f1358ffab1a1df6b35a29bf858267ff
Author: Rajan Dhabalia <rd...@apache.org>
AuthorDate: Thu Oct 3 09:31:15 2019 -0700
[pulsar-proxy] add debug log + fix thread-factory name (#5302)
### Motivation
We are debugging issue where client is timing out lookup request and it helps to have debug log for successful lookup response. and fix thread-factory name for proxy.
---
.../java/org/apache/pulsar/proxy/server/LookupProxyHandler.java | 7 +++++--
.../src/main/java/org/apache/pulsar/proxy/server/ProxyService.java | 4 ++--
2 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/LookupProxyHandler.java b/pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/LookupProxyHandler.java
index 9e3893d..ef4fc07 100644
--- a/pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/LookupProxyHandler.java
+++ b/pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/LookupProxyHandler.java
@@ -27,7 +27,6 @@ import java.net.URISyntaxException;
import java.util.Optional;
import org.apache.commons.lang3.StringUtils;
-import org.apache.pulsar.common.api.proto.PulsarApi.CommandGetSchemaResponse;
import org.apache.pulsar.common.protocol.Commands;
import org.apache.pulsar.common.api.proto.PulsarApi.CommandGetTopicsOfNamespace;
import org.apache.pulsar.common.api.proto.PulsarApi.CommandGetSchema;
@@ -37,7 +36,6 @@ import org.apache.pulsar.common.api.proto.PulsarApi.CommandPartitionedTopicMetad
import org.apache.pulsar.common.api.proto.PulsarApi.ServerError;
import org.apache.pulsar.common.naming.TopicName;
import org.apache.pulsar.common.protocol.schema.BytesSchemaVersion;
-import org.apache.pulsar.common.schema.SchemaInfo;
import org.apache.pulsar.policies.data.loadbalancer.ServiceLookupData;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
@@ -172,6 +170,11 @@ public class LookupProxyHandler {
// client
// to use the appropriate target broker (and port) when it
// will connect back.
+ if (log.isDebugEnabled()) {
+ log.debug(
+ "Successfully perform lookup '{}' for topic '{}' with clientReq Id '{}' and lookup-broker {}",
+ addr, topic, clientRequestId, brokerUrl);
+ }
proxyConnection.ctx().writeAndFlush(Commands.newLookupResponse(brokerUrl, brokerUrl, true,
LookupType.Connect, clientRequestId, true /* this is coming from proxy */));
}
diff --git a/pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyService.java b/pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyService.java
index a634485..6aa163b 100644
--- a/pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyService.java
+++ b/pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/ProxyService.java
@@ -63,8 +63,8 @@ public class ProxyService implements Closeable {
private final EventLoopGroup acceptorGroup;
private final EventLoopGroup workerGroup;
- private final DefaultThreadFactory acceptorThreadFactory = new DefaultThreadFactory("pulsar-discovery-acceptor");
- private final DefaultThreadFactory workersThreadFactory = new DefaultThreadFactory("pulsar-discovery-io");
+ private final DefaultThreadFactory acceptorThreadFactory = new DefaultThreadFactory("pulsar-proxy-acceptor");
+ private final DefaultThreadFactory workersThreadFactory = new DefaultThreadFactory("pulsar-proxy-io");
private BrokerDiscoveryProvider discoveryProvider;