You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/07/24 13:47:35 UTC

[GitHub] [incubator-superset] dpgaspar opened a new pull request #7920: [log] Disable Log view when FAB security views are disabled

dpgaspar opened a new pull request #7920: [log] Disable Log view when FAB security views are disabled
URL: https://github.com/apache/incubator-superset/pull/7920
 
 
   ### CATEGORY
   
   Choose one
   
   - [ ] Bug Fix
   - [X] Enhancement (new features, refinement)
   - [X] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   When FAB's security views are disabled on the config, `LogModelView` still get's added and the menu is displaced. This change prevent's it.
   
   Took the chance to refactor and add the new `ModelRestApi` for the Log's. `LogRestApi` set's of permissions are the same as for the `LogModelView` so that we don't have new permissions being created.
   
   ### ADDITIONAL INFORMATION
   - [X] Changes UI (Optional)
   - [X] Introduces new feature or API
   
   ### REVIEWERS
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org