You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org> on 2010/05/11 01:59:29 UTC

[jira] Created: (HBASE-2528) ServerManager.ServerMonitor isn't daemonized

ServerManager.ServerMonitor isn't daemonized
--------------------------------------------

                 Key: HBASE-2528
                 URL: https://issues.apache.org/jira/browse/HBASE-2528
             Project: Hadoop HBase
          Issue Type: Improvement
            Reporter: Jean-Daniel Cryans
            Assignee: Jean-Daniel Cryans
             Fix For: 0.20.5, 0.21.0


ServerManager.ServerMonitor isn't daemonized, I probably accumulated an hour of waiting on that thread while shutting down the master over the past 2 years. Easy fix:

{code}
@@ -147,7 +148,9 @@
     this.minimumServerCount = c.getInt("hbase.regions.server.count.min", 0);
     this.serverMonitorThread = new ServerMonitor(master.metaRescanInterval,
       master.shutdownRequested);
-    this.serverMonitorThread.start();
+    String n = Thread.currentThread().getName();
+    Threads.setDaemonThreadRunning(this.serverMonitorThread,
+      n + ".serverMonitor");
{code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HBASE-2528) ServerManager.ServerMonitor isn't daemonized

Posted by "Jean-Daniel Cryans (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-2528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jean-Daniel Cryans resolved HBASE-2528.
---------------------------------------

    Resolution: Fixed

Small fix, committed to branch and trunk.

> ServerManager.ServerMonitor isn't daemonized
> --------------------------------------------
>
>                 Key: HBASE-2528
>                 URL: https://issues.apache.org/jira/browse/HBASE-2528
>             Project: Hadoop HBase
>          Issue Type: Improvement
>            Reporter: Jean-Daniel Cryans
>            Assignee: Jean-Daniel Cryans
>             Fix For: 0.20.5, 0.21.0
>
>
> ServerManager.ServerMonitor isn't daemonized, I probably accumulated an hour of waiting on that thread while shutting down the master over the past 2 years. Easy fix:
> {code}
> @@ -147,7 +148,9 @@
>      this.minimumServerCount = c.getInt("hbase.regions.server.count.min", 0);
>      this.serverMonitorThread = new ServerMonitor(master.metaRescanInterval,
>        master.shutdownRequested);
> -    this.serverMonitorThread.start();
> +    String n = Thread.currentThread().getName();
> +    Threads.setDaemonThreadRunning(this.serverMonitorThread,
> +      n + ".serverMonitor");
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.