You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/12 23:14:15 UTC
[GitHub] [spark] holdenk commented on a diff in pull request #36433: [SPARK-36462][K8S] Add the ability to selectively disable watching or polling
holdenk commented on code in PR #36433:
URL: https://github.com/apache/spark/pull/36433#discussion_r944931246
##########
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsWatchSnapshotSource.scala:
##########
@@ -38,19 +40,23 @@ import org.apache.spark.util.Utils
@DeveloperApi
class ExecutorPodsWatchSnapshotSource(
snapshotsStore: ExecutorPodsSnapshotsStore,
- kubernetesClient: KubernetesClient) extends Logging {
+ kubernetesClient: KubernetesClient,
+ conf: SparkConf) extends Logging {
Review Comment:
Sure :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org