You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/08/21 18:01:42 UTC

[GitHub] [incubator-mxnet] Zha0q1 opened a new pull request #18981: Add numpy large tensor test

Zha0q1 opened a new pull request #18981:
URL: https://github.com/apache/incubator-mxnet/pull/18981


   This is quite weird. The output is correct up until input shape (2, x) x-->2^26. Also when x=2^31 the op will trigger core dump. Needs to be fixed latter. This PR is test only (missed this in earlier pr)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] Zha0q1 commented on a change in pull request #18981: Add numpy large tensor test

Posted by GitBox <gi...@apache.org>.
Zha0q1 commented on a change in pull request #18981:
URL: https://github.com/apache/incubator-mxnet/pull/18981#discussion_r475001977



##########
File path: tests/nightly/test_np_large_array.py
##########
@@ -969,3 +969,18 @@ def test_save_load():
     B = np.array(npx.load('my_tensor'))
     assert B[0].shape == (2, INT_OVERFLOW)
     assert B[0][0][100] == 100
+
+@use_np
+@pytest.mark.skip(reason='foward gives wrong result on large tensors (~2**26); \
+    core dump on (2, INT_OVERFLOW)')

Review comment:
       We are working on creating tests for this week; from next Monday on we will fix the operators that have failed the tests so maybe by that time we can unskip it




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] sandeep-krishnamurthy commented on pull request #18981: Numpy Gather ND Large Tensor fix

Posted by GitBox <gi...@apache.org>.
sandeep-krishnamurthy commented on pull request #18981:
URL: https://github.com/apache/incubator-mxnet/pull/18981#issuecomment-681980235


   Thanks. Merging, as the tests are enabled and addresses Sheng's comment.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] sandeep-krishnamurthy merged pull request #18981: Numpy Gather ND Large Tensor fix

Posted by GitBox <gi...@apache.org>.
sandeep-krishnamurthy merged pull request #18981:
URL: https://github.com/apache/incubator-mxnet/pull/18981


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18981: Add numpy large tensor test

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18981:
URL: https://github.com/apache/incubator-mxnet/pull/18981#issuecomment-678417414


   Hey @Zha0q1 , Thanks for submitting the PR 
   All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands: 
   - To trigger all jobs: @mxnet-bot run ci [all] 
   - To trigger specific jobs: @mxnet-bot run ci [job1, job2] 
   *** 
   **CI supported jobs**: [windows-gpu, centos-gpu, unix-cpu, sanity, miscellaneous, centos-cpu, windows-cpu, clang, edge, website, unix-gpu]
   *** 
   _Note_: 
    Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin. 
   All CI tests must pass before the PR can be merged. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] szha commented on a change in pull request #18981: Add numpy large tensor test

Posted by GitBox <gi...@apache.org>.
szha commented on a change in pull request #18981:
URL: https://github.com/apache/incubator-mxnet/pull/18981#discussion_r475002533



##########
File path: tests/nightly/test_np_large_array.py
##########
@@ -969,3 +969,18 @@ def test_save_load():
     B = np.array(npx.load('my_tensor'))
     assert B[0].shape == (2, INT_OVERFLOW)
     assert B[0][0][100] == 100
+
+@use_np
+@pytest.mark.skip(reason='foward gives wrong result on large tensors (~2**26); \
+    core dump on (2, INT_OVERFLOW)')

Review comment:
       in that case feel free to convert this PR to draft.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18981: Add numpy large tensor test

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18981:
URL: https://github.com/apache/incubator-mxnet/pull/18981#issuecomment-678489506


   Jenkins CI successfully triggered : [unix-gpu]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] Zha0q1 commented on pull request #18981: Add numpy large tensor test

Posted by GitBox <gi...@apache.org>.
Zha0q1 commented on pull request #18981:
URL: https://github.com/apache/incubator-mxnet/pull/18981#issuecomment-678489461


   @mxnet-bot run ci [unix-gpu]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] szha commented on a change in pull request #18981: Add numpy large tensor test

Posted by GitBox <gi...@apache.org>.
szha commented on a change in pull request #18981:
URL: https://github.com/apache/incubator-mxnet/pull/18981#discussion_r475001462



##########
File path: tests/nightly/test_np_large_array.py
##########
@@ -969,3 +969,18 @@ def test_save_load():
     B = np.array(npx.load('my_tensor'))
     assert B[0].shape == (2, INT_OVERFLOW)
     assert B[0][0][100] == 100
+
+@use_np
+@pytest.mark.skip(reason='foward gives wrong result on large tensors (~2**26); \
+    core dump on (2, INT_OVERFLOW)')

Review comment:
       I don't think we should be adding a test that gets skipped by default.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org