You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by dtrodrigues <gi...@git.apache.org> on 2018/05/26 22:39:34 UTC
[GitHub] nifi-minifi-cpp pull request #345: MINIFICPP-512 - upgrade to librdkafka 0.1...
GitHub user dtrodrigues opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/345
MINIFICPP-512 - upgrade to librdkafka 0.11.4
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dtrodrigues/nifi-minifi-cpp MINIFICPP-512
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi-cpp/pull/345.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #345
----
commit 55e1f440d378595f1e59236e9d47f6dfbd315e75
Author: Dustin Rodrigues <du...@...>
Date: 2018-05-26T22:34:31Z
MINIFICPP-512 - upgrade to librdkafka 0.11.4
----
---
[GitHub] nifi-minifi-cpp pull request #345: MINIFICPP-512 - upgrade to librdkafka 0.1...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi-minifi-cpp/pull/345
---
[GitHub] nifi-minifi-cpp issue #345: MINIFICPP-512 - upgrade to librdkafka 0.11.4
Posted by phrocker <gi...@git.apache.org>.
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/345
@dtrodrigues We have an impending release. Once the final PR for that release version is merged I'll merge this in after that commit.
---
[GitHub] nifi-minifi-cpp issue #345: MINIFICPP-512 - upgrade to librdkafka 0.11.4
Posted by dtrodrigues <gi...@git.apache.org>.
Github user dtrodrigues commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/345
@phrocker I've removed tests and windows directories and updated CMakeLists.txt in librdkafka to not build the examples or tests.
---