You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zhengruifeng (via GitHub)" <gi...@apache.org> on 2026/08/20 05:08:04 UTC
[PR] [SPARK-58898][MLLIB] Use Identifiable for temporary ML column names [spark]
zhengruifeng opened a new pull request, #58151:
URL: https://github.com/apache/spark/pull/58151
### What changes were proposed in this pull request?
This PR replaces ad hoc UUID concatenation for Scala ML temporary and fallback column names
with `Identifiable.randomUID(prefix)`.
The updated paths cover classification/regression summary fallback output columns and
`OneVsRestModel` intermediate columns.
### Why are the changes needed?
Scala ML code already uses `Identifiable.randomUID` for collision-resistant generated names.
Using it in these remaining column-name paths keeps the Scala side consistent and avoids direct
`java.util.UUID` usage for temporary ML columns.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Manually checked with:
```
git diff --check
grep -rn -P "[^\x00-\x7F]" mllib/src/main/scala/org/apache/spark/ml/classification/OneVsRest.scala mllib/src/main/scala/org/apache/spark/ml/classification/Classifier.scala mllib/src/main/scala/org/apache/spark/ml/classification/ProbabilisticClassifier.scala mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
```
Unit tests were not run because this is a small internal refactor of generated column names.
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Codex (GPT-5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58898][ML] Use Identifiable for temporary ML column names [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #58151:
URL: https://github.com/apache/spark/pull/58151#issuecomment-5354684337
**Merge Summary:**
- merged into master https://github.com/apache/spark/commit/5254d42ab1a89cfc9f057b20849cdac2bd504729
- merged into branch-4.x https://github.com/apache/spark/commit/b7f47e143b7435a633731abddf525c0ff5b16678
*Posted by `merge_spark_pr.py`*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58898][ML] Use Identifiable for temporary ML column names [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng closed pull request #58151: [SPARK-58898][ML] Use Identifiable for temporary ML column names
URL: https://github.com/apache/spark/pull/58151
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org