You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "nodece (via GitHub)" <gi...@apache.org> on 2023/05/11 13:12:31 UTC
[GitHub] [pulsar] nodece opened a new pull request, #20305: [fix][build] Fix publish image script
nodece opened a new pull request, #20305:
URL: https://github.com/apache/pulsar/pull/20305
### Motivation
In the old version, we have multiple images:
- `pulsar:latest`
- `pulsar:VERSION`
- `pulsar-all:latest`
- `pulsar-all:VERSION`
- `apachepulsar/pulsar:latest`
- `apachepulsar/pulsar:VERSION`
- `apachepulsar/pulsar-all:latest`
- `apachepulsar/pulsar-all:VERSION`
After https://github.com/apache/pulsar/pull/19432 is merged, we only have the following images:
- `apachepulsar/pulsar:latest`
- `apachepulsar/pulsar:VERSION`
- `apachepulsar/pulsar-all:latest`
- `apachepulsar/pulsar-all:VERSION`
The `pulsar:latest` and `pulsar-all:latest` images are used in the `docker/publish.sh` script, #19432 breaks the publish script.
### Modifications
- Use `apachepulsar/pulsar:latest` instead of `pulsar:latest`
- Use `apachepulsar/pulsar-all:latest` instead of `pulsar-all:latest`
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on a diff in pull request #20305: [fix][build] Fix publish image script
Posted by "michaeljmarshall (via GitHub)" <gi...@apache.org>.
michaeljmarshall commented on code in PR #20305:
URL: https://github.com/apache/pulsar/pull/20305#discussion_r1192583945
##########
docker/publish.sh:
##########
@@ -62,11 +62,11 @@ set -x
# Fail if any of the subsequent commands fail
set -e
-docker tag pulsar:latest ${docker_registry_org}/pulsar:latest
-docker tag pulsar-all:latest ${docker_registry_org}/pulsar-all:latest
+docker tag apachepulsar/pulsar:latest ${docker_registry_org}/pulsar:latest
+docker tag apachepulsar/pulsar-all:latest ${docker_registry_org}/pulsar-all:latest
Review Comment:
I know your PR didn't change this. I just noticed it after reading your PR description and wanted to ask.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codecov-commenter commented on pull request #20305: [fix][build] Fix publish image script
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #20305:
URL: https://github.com/apache/pulsar/pull/20305#issuecomment-1545081489
## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/20305?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#20305](https://app.codecov.io/gh/apache/pulsar/pull/20305?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7208e11) into [master](https://app.codecov.io/gh/apache/pulsar/commit/b07f2a9b85a0f22b89fed5b51ee8625b00b7262e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b07f2a9) will **increase** coverage by `42.72%`.
> The diff coverage is `n/a`.
[](https://app.codecov.io/gh/apache/pulsar/pull/20305?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #20305 +/- ##
=============================================
+ Coverage 30.23% 72.96% +42.72%
- Complexity 295 31971 +31676
=============================================
Files 1689 1868 +179
Lines 129020 138601 +9581
Branches 14070 15240 +1170
=============================================
+ Hits 39013 101125 +62112
+ Misses 84148 29449 -54699
- Partials 5859 8027 +2168
```
| Flag | Coverage Δ | |
|---|---|---|
| inttests | `24.08% <ø> (-0.09%)` | :arrow_down: |
| systests | `24.98% <ø> (+0.01%)` | :arrow_up: |
| unittests | `72.24% <ø> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1490 files with indirect coverage changes](https://app.codecov.io/gh/apache/pulsar/pull/20305/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on a diff in pull request #20305: [fix][build] Fix publish image script
Posted by "michaeljmarshall (via GitHub)" <gi...@apache.org>.
michaeljmarshall commented on code in PR #20305:
URL: https://github.com/apache/pulsar/pull/20305#discussion_r1196920347
##########
docker/publish.sh:
##########
@@ -62,11 +62,11 @@ set -x
# Fail if any of the subsequent commands fail
set -e
-docker tag pulsar:latest ${docker_registry_org}/pulsar:latest
-docker tag pulsar-all:latest ${docker_registry_org}/pulsar-all:latest
+docker tag apachepulsar/pulsar:latest ${docker_registry_org}/pulsar:latest
+docker tag apachepulsar/pulsar-all:latest ${docker_registry_org}/pulsar-all:latest
Review Comment:
Thanks for sharing that reference. I reopened and commented on the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nodece commented on a diff in pull request #20305: [fix][build] Fix publish image script
Posted by "nodece (via GitHub)" <gi...@apache.org>.
nodece commented on code in PR #20305:
URL: https://github.com/apache/pulsar/pull/20305#discussion_r1192983151
##########
docker/publish.sh:
##########
@@ -62,11 +62,11 @@ set -x
# Fail if any of the subsequent commands fail
set -e
-docker tag pulsar:latest ${docker_registry_org}/pulsar:latest
-docker tag pulsar-all:latest ${docker_registry_org}/pulsar-all:latest
+docker tag apachepulsar/pulsar:latest ${docker_registry_org}/pulsar:latest
+docker tag apachepulsar/pulsar-all:latest ${docker_registry_org}/pulsar-all:latest
Review Comment:
> Do you know if this will override "latest" when we release older versions? For example, when we release 3.1.0, we wouldn't want some 3.0.x release to overwrite "latest" in my opinion.
I have never bumped the Pulsar, but I know we have this issue, see https://github.com/apache/pulsar/issues/19544
Perhaps we need to update the release document, and update the publish script.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nodece merged pull request #20305: [fix][build] Fix publish image script
Posted by "nodece (via GitHub)" <gi...@apache.org>.
nodece merged PR #20305:
URL: https://github.com/apache/pulsar/pull/20305
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nodece commented on pull request #20305: [fix][build] Fix publish image script
Posted by "nodece (via GitHub)" <gi...@apache.org>.
nodece commented on PR #20305:
URL: https://github.com/apache/pulsar/pull/20305#issuecomment-1543991388
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nodece commented on pull request #20305: [fix][build] Fix publish image script
Posted by "nodece (via GitHub)" <gi...@apache.org>.
nodece commented on PR #20305:
URL: https://github.com/apache/pulsar/pull/20305#issuecomment-1544979220
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on a diff in pull request #20305: [fix][build] Fix publish image script
Posted by "michaeljmarshall (via GitHub)" <gi...@apache.org>.
michaeljmarshall commented on code in PR #20305:
URL: https://github.com/apache/pulsar/pull/20305#discussion_r1192583633
##########
docker/publish.sh:
##########
@@ -62,11 +62,11 @@ set -x
# Fail if any of the subsequent commands fail
set -e
-docker tag pulsar:latest ${docker_registry_org}/pulsar:latest
-docker tag pulsar-all:latest ${docker_registry_org}/pulsar-all:latest
+docker tag apachepulsar/pulsar:latest ${docker_registry_org}/pulsar:latest
+docker tag apachepulsar/pulsar-all:latest ${docker_registry_org}/pulsar-all:latest
Review Comment:
Do you know if this will override "latest" when we release older versions? For example, when we release 3.1.0, we wouldn't want some 3.0.x release to overwrite "latest" in my opinion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org