You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@royale.apache.org by Yishay Weiss <yi...@apache.org> on 2021/09/05 10:04:26 UTC

Re: [royale-asjs] branch develop updated: Update defaults.css commented ProgressBar bead

@pashminakazi , I would like to revert this commit. It means we cannot use ProgressBar in our app. Please consider debugging the issue in your app and fixing the SDK in a way which does not remove functionality. If you are looking for a faster solution you can to use a custom component instead of the SDK's ProgressBar.

Please let me know your thoughts.

On 2020/12/18 11:03:36, pushminakazi@apache.org wrote: 
> This is an automated email from the ASF dual-hosted git repository.
> 
> pushminakazi pushed a commit to branch develop
> in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
> 
> 
> The following commit(s) were added to refs/heads/develop by this push:
>      new fa10fd6  Update defaults.css commented ProgressBar bead
> fa10fd6 is described below
> 
> commit fa10fd63e503b96e3b96fc504bfee662f0d18f4c
> Author: pashminakazi <42...@users.noreply.github.com>
> AuthorDate: Fri Dec 18 16:03:27 2020 +0500
> 
>     Update defaults.css commented ProgressBar bead
>     
>     I got an error while compiling my project MXRoyale default.css: mx.controls.beads.ProgressBarView is not defined
> ---
>  frameworks/projects/MXRoyale/src/main/resources/defaults.css | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/frameworks/projects/MXRoyale/src/main/resources/defaults.css b/frameworks/projects/MXRoyale/src/main/resources/defaults.css
> index 9a16916..600013e 100644
> --- a/frameworks/projects/MXRoyale/src/main/resources/defaults.css
> +++ b/frameworks/projects/MXRoyale/src/main/resources/defaults.css
> @@ -489,10 +489,10 @@ TabNavigator
>  	border: 1px solid #333333
>  }
>  
> -ProgressBar
> +/* ProgressBar
>  {
>  	IBeadView: ClassReference("mx.controls.beads.ProgressBarView");
> -}
> +} */
>  
>  TextInput
>  {
> 
> 

Re: [royale-asjs] branch develop updated: Update defaults.css commented ProgressBar bead

Posted by Harbs <ha...@gmail.com>.
It’s only used in “as” statements.

It might depend if compiled with ignore coercions. Not sure, but a thought...

Either way, it seems like it should be added to the manifest.

> On Sep 5, 2021, at 2:12 PM, Yishay Weiss <yi...@apache.org> wrote:
> 
> It is, but it works for me nonetheless, perhaps because it is imported by ProgressBar which does exist in the manifest?
> 
> On 2021/09/05 10:23:34, Harbs <ha...@gmail.com> wrote: 
>> Is ProgressBarView missing from the MXRoyale manifest?
>> 
>>> On Sep 5, 2021, at 1:04 PM, Yishay Weiss <yi...@apache.org> wrote:
>>> 
>>> @pashminakazi , I would like to revert this commit. It means we cannot use ProgressBar in our app. Please consider debugging the issue in your app and fixing the SDK in a way which does not remove functionality. If you are looking for a faster solution you can to use a custom component instead of the SDK's ProgressBar.
>>> 
>>> Please let me know your thoughts.
>>> 
>>> On 2020/12/18 11:03:36, pushminakazi@apache.org wrote: 
>>>> This is an automated email from the ASF dual-hosted git repository.
>>>> 
>>>> pushminakazi pushed a commit to branch develop
>>>> in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
>>>> 
>>>> 
>>>> The following commit(s) were added to refs/heads/develop by this push:
>>>>    new fa10fd6  Update defaults.css commented ProgressBar bead
>>>> fa10fd6 is described below
>>>> 
>>>> commit fa10fd63e503b96e3b96fc504bfee662f0d18f4c
>>>> Author: pashminakazi <42...@users.noreply.github.com>
>>>> AuthorDate: Fri Dec 18 16:03:27 2020 +0500
>>>> 
>>>>   Update defaults.css commented ProgressBar bead
>>>> 
>>>>   I got an error while compiling my project MXRoyale default.css: mx.controls.beads.ProgressBarView is not defined
>>>> ---
>>>> frameworks/projects/MXRoyale/src/main/resources/defaults.css | 4 ++--
>>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>> 
>>>> diff --git a/frameworks/projects/MXRoyale/src/main/resources/defaults.css b/frameworks/projects/MXRoyale/src/main/resources/defaults.css
>>>> index 9a16916..600013e 100644
>>>> --- a/frameworks/projects/MXRoyale/src/main/resources/defaults.css
>>>> +++ b/frameworks/projects/MXRoyale/src/main/resources/defaults.css
>>>> @@ -489,10 +489,10 @@ TabNavigator
>>>> 	border: 1px solid #333333
>>>> }
>>>> 
>>>> -ProgressBar
>>>> +/* ProgressBar
>>>> {
>>>> 	IBeadView: ClassReference("mx.controls.beads.ProgressBarView");
>>>> -}
>>>> +} */
>>>> 
>>>> TextInput
>>>> {
>>>> 
>>>> 
>> 
>> 


Re: [royale-asjs] branch develop updated: Update defaults.css commented ProgressBar bead

Posted by Yishay Weiss <yi...@apache.org>.
It is, but it works for me nonetheless, perhaps because it is imported by ProgressBar which does exist in the manifest?

On 2021/09/05 10:23:34, Harbs <ha...@gmail.com> wrote: 
> Is ProgressBarView missing from the MXRoyale manifest?
> 
> > On Sep 5, 2021, at 1:04 PM, Yishay Weiss <yi...@apache.org> wrote:
> > 
> > @pashminakazi , I would like to revert this commit. It means we cannot use ProgressBar in our app. Please consider debugging the issue in your app and fixing the SDK in a way which does not remove functionality. If you are looking for a faster solution you can to use a custom component instead of the SDK's ProgressBar.
> > 
> > Please let me know your thoughts.
> > 
> > On 2020/12/18 11:03:36, pushminakazi@apache.org wrote: 
> >> This is an automated email from the ASF dual-hosted git repository.
> >> 
> >> pushminakazi pushed a commit to branch develop
> >> in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
> >> 
> >> 
> >> The following commit(s) were added to refs/heads/develop by this push:
> >>     new fa10fd6  Update defaults.css commented ProgressBar bead
> >> fa10fd6 is described below
> >> 
> >> commit fa10fd63e503b96e3b96fc504bfee662f0d18f4c
> >> Author: pashminakazi <42...@users.noreply.github.com>
> >> AuthorDate: Fri Dec 18 16:03:27 2020 +0500
> >> 
> >>    Update defaults.css commented ProgressBar bead
> >> 
> >>    I got an error while compiling my project MXRoyale default.css: mx.controls.beads.ProgressBarView is not defined
> >> ---
> >> frameworks/projects/MXRoyale/src/main/resources/defaults.css | 4 ++--
> >> 1 file changed, 2 insertions(+), 2 deletions(-)
> >> 
> >> diff --git a/frameworks/projects/MXRoyale/src/main/resources/defaults.css b/frameworks/projects/MXRoyale/src/main/resources/defaults.css
> >> index 9a16916..600013e 100644
> >> --- a/frameworks/projects/MXRoyale/src/main/resources/defaults.css
> >> +++ b/frameworks/projects/MXRoyale/src/main/resources/defaults.css
> >> @@ -489,10 +489,10 @@ TabNavigator
> >> 	border: 1px solid #333333
> >> }
> >> 
> >> -ProgressBar
> >> +/* ProgressBar
> >> {
> >> 	IBeadView: ClassReference("mx.controls.beads.ProgressBarView");
> >> -}
> >> +} */
> >> 
> >> TextInput
> >> {
> >> 
> >> 
> 
> 

Re: [royale-asjs] branch develop updated: Update defaults.css commented ProgressBar bead

Posted by Harbs <ha...@gmail.com>.
Is ProgressBarView missing from the MXRoyale manifest?

> On Sep 5, 2021, at 1:04 PM, Yishay Weiss <yi...@apache.org> wrote:
> 
> @pashminakazi , I would like to revert this commit. It means we cannot use ProgressBar in our app. Please consider debugging the issue in your app and fixing the SDK in a way which does not remove functionality. If you are looking for a faster solution you can to use a custom component instead of the SDK's ProgressBar.
> 
> Please let me know your thoughts.
> 
> On 2020/12/18 11:03:36, pushminakazi@apache.org wrote: 
>> This is an automated email from the ASF dual-hosted git repository.
>> 
>> pushminakazi pushed a commit to branch develop
>> in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
>> 
>> 
>> The following commit(s) were added to refs/heads/develop by this push:
>>     new fa10fd6  Update defaults.css commented ProgressBar bead
>> fa10fd6 is described below
>> 
>> commit fa10fd63e503b96e3b96fc504bfee662f0d18f4c
>> Author: pashminakazi <42...@users.noreply.github.com>
>> AuthorDate: Fri Dec 18 16:03:27 2020 +0500
>> 
>>    Update defaults.css commented ProgressBar bead
>> 
>>    I got an error while compiling my project MXRoyale default.css: mx.controls.beads.ProgressBarView is not defined
>> ---
>> frameworks/projects/MXRoyale/src/main/resources/defaults.css | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>> 
>> diff --git a/frameworks/projects/MXRoyale/src/main/resources/defaults.css b/frameworks/projects/MXRoyale/src/main/resources/defaults.css
>> index 9a16916..600013e 100644
>> --- a/frameworks/projects/MXRoyale/src/main/resources/defaults.css
>> +++ b/frameworks/projects/MXRoyale/src/main/resources/defaults.css
>> @@ -489,10 +489,10 @@ TabNavigator
>> 	border: 1px solid #333333
>> }
>> 
>> -ProgressBar
>> +/* ProgressBar
>> {
>> 	IBeadView: ClassReference("mx.controls.beads.ProgressBarView");
>> -}
>> +} */
>> 
>> TextInput
>> {
>> 
>>