You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/11 19:59:25 UTC

[GitHub] [flink-benchmarks] pnowojski commented on pull request #7: [FLINK-20612][runtime] Add benchmarks for scheduler

pnowojski commented on pull request #7:
URL: https://github.com/apache/flink-benchmarks/pull/7#issuecomment-758188459


   > Would you mind if I reach out to you for how to configure the jenkins after the pull request is well prepared?
   
   Sure, we can do that afterwards.
   
   > 2. Yes, the names are long-winded and fulfilled with duplicated words. It seems that the batch and streaming modes in buildTopology and scheduling can be easily merged. But for the batch and streaming modes in deploying and failover, they have different Setup methods, and it seems a bit of tricky to merge them. I'm still working on this.
   
   If it's easier to have the code in separate classes that's fine by me. We just need short, unique and descriptive names of the `@Benchmark` methods, as they are being used in the WebUI.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org