You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Lars Eberle (JIRA)" <ji...@apache.org> on 2017/10/16 12:05:00 UTC

[jira] [Updated] (WICKET-6481) NullPointerException in MountedMapper

     [ https://issues.apache.org/jira/browse/WICKET-6481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lars Eberle updated WICKET-6481:
--------------------------------
    Attachment: quick.tar.gz

Hi [~bitstorm],

I tried the SNAPSHOT release, this changed the Exception to:

{noformat}
13:43:16,667-[http-nio-8080-exec-3] ERROR -faultExceptionMapper-Unexpected error occurred
java.lang.IllegalArgumentException: Argument 'pageClass' may not be null.
	at org.apache.wicket.util.lang.Args.notNull(Args.java:41)
	at org.apache.wicket.core.request.mapper.AbstractBookmarkableMapper$UrlInfo.<init>(AbstractBookmarkableMapper.java:90)
	at org.apache.wicket.core.request.mapper.AbstractBookmarkableMapper.mapHandler(AbstractBookmarkableMapper.java:410)
	at org.apache.wicket.request.mapper.CompoundRequestMapper.mapHandler(CompoundRequestMapper.java:210)
	at org.apache.wicket.request.cycle.RequestCycle.mapUrlFor(RequestCycle.java:449)
	at org.apache.wicket.request.handler.render.WebPageRenderer.respond(WebPageRenderer.java:186)
	at org.apache.wicket.core.request.handler.RenderPageRequestHandler.respond(RenderPageRequestHandler.java:202)
	at org.apache.wicket.request.cycle.RequestCycle$HandlerExecutor.respond(RequestCycle.java:912)
	at org.apache.wicket.request.RequestHandlerExecutor.execute(RequestHandlerExecutor.java:65)
	at org.apache.wicket.request.cycle.RequestCycle.execute(RequestCycle.java:283)
	at org.apache.wicket.request.cycle.RequestCycle.processRequest(RequestCycle.java:253)
	at org.apache.wicket.request.cycle.RequestCycle.processRequestAndDetach(RequestCycle.java:221)
	at org.apache.wicket.protocol.http.WicketFilter.processRequestCycle(WicketFilter.java:262)
	at org.apache.wicket.protocol.http.WicketFilter.processRequest(WicketFilter.java:204)
	at org.apache.wicket.protocol.http.WicketFilter.doFilter(WicketFilter.java:286)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166)
	at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:199)
	at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:96)
	at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:475)
	at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:140)
	at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:80)
	at org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:651)
	at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:87)
	at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:342)
	at org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:498)
	at org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:66)
	at org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:796)
	at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1374)
	at org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
	at java.lang.Thread.run(Thread.java:748)
13:43:16,848-[http-nio-8080-exec-3] INFO  -RequestLogger       -startTime="2017-10-16 11:43:16,658",duration=189,url="http://localhost:8080/blok/page/home?1&keep=true",event={handler=RenderPageRequestHandler,data={pageId=1,pageParameters={null},renderCount=null}},response={handler=RenderPageRequestHandler,data={pageClass=de.bps.blok.page.simple.ErrorPage,pageId=null,pageParameters={},renderCount=null}},sessionid="null",sessionsize=1305,activerequests=0,maxmem=3493M,total=569M,used=140M
{noformat}

Also I found the time to convert my project to a simple quickstart by removing all but the base page components. The problem still exists. Here are the key facts to start this up with my environment:
# extract [^quick.tar.gz]
# _Import existing project_ (we use Eclipse Oxygen)
# create a tomcat 9.0.1 server (we use Java 8u144)
# deploy module _quick_ to that server, default settings are sufficient
# start the server
# call http://localhost:8080/blok/page/home?1 in your browser
# this should give you sth. like _Base Simple! Error! Base again _
# check the console, you should find the stacktrace above
# http://localhost:8080/blok/page/home (no page version) should work

> NullPointerException in MountedMapper
> -------------------------------------
>
>                 Key: WICKET-6481
>                 URL: https://issues.apache.org/jira/browse/WICKET-6481
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 8.0.0-M7
>         Environment: Linux 4.9.0-3-amd64 #1 SMP Debian 4.9.30-2+deb9u5 (2017-09-19) x86_64 GNU/Linux
> Java 8u144
> Tomcat 9.0.1
>            Reporter: Lars Eberle
>            Assignee: Andrea Del Bene
>         Attachments: quick.tar.gz
>
>
> In case users open bookmarked deep links (including page version) or the page currently displayed expired, in some cases there are NPEs in the MountedMapper:
> {noformat}
> 09:48:55,229-[ajp-nio-8154-exec-6] ERROR -ErrorPage           - java.lang.NullPointerException
> 	at org.apache.wicket.core.request.mapper.MountedMapper.checkPageClass(MountedMapper.java:256)
> 	at org.apache.wicket.core.request.mapper.AbstractBookmarkableMapper.mapHandler(AbstractBookmarkableMapper.java:400)
> 	at org.apache.wicket.core.request.mapper.MountedMapper.mapHandler(MountedMapper.java:154)
> 	at org.apache.wicket.request.mapper.CompoundRequestMapper.mapHandler(CompoundRequestMapper.java:210)
> 	at org.apache.wicket.request.cycle.RequestCycle.mapUrlFor(RequestCycle.java:449)
> 	at org.apache.wicket.request.handler.render.WebPageRenderer.respond(WebPageRenderer.java:186)
> 	at org.apache.wicket.core.request.handler.RenderPageRequestHandler.respond(RenderPageRequestHandler.java:202)
> 	at org.apache.wicket.request.cycle.RequestCycle$HandlerExecutor.respond(RequestCycle.java:912)
> 	at org.apache.wicket.request.RequestHandlerExecutor.execute(RequestHandlerExecutor.java:65)
> 	at org.apache.wicket.request.cycle.RequestCycle.execute(RequestCycle.java:283)
> 	at org.apache.wicket.request.cycle.RequestCycle.processRequest(RequestCycle.java:253)
> 	at org.apache.wicket.request.cycle.RequestCycle.processRequestAndDetach(RequestCycle.java:221)
> 	at org.apache.wicket.protocol.http.WicketFilter.processRequestCycle(WicketFilter.java:262)
> 	at org.apache.wicket.protocol.http.WicketFilter.processRequest(WicketFilter.java:204)
> 	at org.apache.wicket.protocol.http.WicketFilter.doFilter(WicketFilter.java:286)
> 	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:239)
> 	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
> 	at org.springframework.orm.hibernate3.support.OpenSessionInViewFilter.doFilterInternal(OpenSessionInViewFilter.java:230)
> 	at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:106)
> 	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:239)
> 	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
> 	at de.bps.blok.utils.NoJSessionIdInUrlFilter.doFilter(NoJSessionIdInUrlFilter.java:44)
> 	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:239)
> 	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
> 	at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:219)
> 	at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:106)
> 	at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:502)
> 	at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:142)
> 	at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:79)
> 	at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:88)
> 	at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:518)
> 	at org.apache.coyote.ajp.AbstractAjpProcessor.process(AbstractAjpProcessor.java:844)
> 	at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:668)
> 	at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1527)
> 	at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1484)
> 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> 	at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
> 	at java.lang.Thread.run(Thread.java:745)
> {noformat}
> Reason seems to be in PageProvider.getPageClass(). This may return null if hasPageInstance() returns false. In that case a NPE is thrown as shown in the stacktrace.
> *Example:*
> Mounting:
> {code:java}
> mount(new MountedMapper("page/${page}", BlokPage.class));
> {code}
> Request logger:
> {noformat}
> 09:48:55,246-[ajp-nio-8154-exec-6] INFO  -RequestLogger       -startTime="2017-10-05 07:48:55,093",duration=153,url="https://server/path/page/home?1",event={handler=RenderPageRequestHandler,data={pageId=1,pageParameters={null},renderCount=null}},response={handler=RenderPageRequestHandler,data={pageClass=de.bps.blok.page.simple.ErrorPage,pageId=0,pageParameters={},renderCount=0}},sessionid="A5527CCEAEE7334A805F9EF09D30A7BB",sessionsize=2710,sessioninfo={;page/home?1},sessionstart="2017-10-05 07:48:55,231",requests=2,totaltime=153,activerequests=0,maxmem=2147M,total=1073M,used=198M
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)