You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Maxim Khutornenko <ma...@apache.org> on 2014/05/21 02:22:46 UTC
Review Request 21741: Adding grouping for the sla commands.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21741/
-----------------------------------------------------------
Review request for Aurora, Mark Chu-Carroll and Brian Wickman.
Bugs: AURORA-441
https://issues.apache.org/jira/browse/AURORA-441
Repository: aurora
Description
-------
Moved grouping functionality from maintenance into base and added grouping support for the sla commands.
Diffs
-----
src/main/python/apache/aurora/admin/host_maintenance.py 16c18bc563c61e37055a8ad81082d60d1662afb2
src/main/python/apache/aurora/client/api/sla.py a20b5d46221981740e0b7d5f0958516560928b54
src/main/python/apache/aurora/client/base.py 13730fd98e36377376e498f414dfb317d5b3b114
src/main/python/apache/aurora/client/commands/admin.py 16e73ba5ed88878302bc2a8a7f2af2a284ccbf02
src/main/python/apache/aurora/client/commands/maintenance.py 68d63a12bb92bb2f50ae45363513892ad9bbb1ff
src/test/python/apache/aurora/admin/test_host_maintenance.py 18bf6223adb6b64cc76c2810abc317ef063e16e2
src/test/python/apache/aurora/client/api/test_sla.py 86b6775e51cab1214a6cae01145f19f08cc74499
src/test/python/apache/aurora/client/commands/test_admin_sla.py df007f2e0de70cd6c3295119d7ef3877cfce036d
Diff: https://reviews.apache.org/r/21741/diff/
Testing
-------
./pants src/test/python:all
Thanks,
Maxim Khutornenko
Re: Review Request 21741: Adding grouping for the sla commands.
Posted by Maxim Khutornenko <ma...@apache.org>.
> On May 27, 2014, 6:32 p.m., Joe Smith wrote:
> > src/main/python/apache/aurora/client/api/sla.py, line 203
> > <https://reviews.apache.org/r/21741/diff/3/?file=588596#file588596line203>
> >
> > In practice, we operate on only a single grouping, and it'd be kind of nice to specify this only once as opposed to each time we invoke this method.. though I'm not sure how to do that cleanly (especially when we call this method once via the command line)
> >
> > (so not a blocker to ship unless we can think of a clean way to improve this api)
There are two different use cases for it: the existing admin command line and the future perform_host_maintenance one. While a single grouping is definitely true for the maintenance case, it may be not for the command line (as you noticed). So, have to support both here.
> On May 27, 2014, 6:32 p.m., Joe Smith wrote:
> > src/test/python/apache/aurora/client/api/test_sla.py, line 56
> > <https://reviews.apache.org/r/21741/diff/3/?file=588601#file588601line56>
> >
> > add a double newline? (unless this passes check style, in which case ignore me)
Bad rebasing. Done.
- Maxim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21741/#review44015
-----------------------------------------------------------
On May 23, 2014, 1:12 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21741/
> -----------------------------------------------------------
>
> (Updated May 23, 2014, 1:12 a.m.)
>
>
> Review request for Aurora, Joe Smith, Mark Chu-Carroll, and Brian Wickman.
>
>
> Bugs: AURORA-441
> https://issues.apache.org/jira/browse/AURORA-441
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Moved grouping functionality from maintenance into base and added grouping support for the sla commands.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/admin/host_maintenance.py 1890f80ca7981af020ab12957879795bd86b6327
> src/main/python/apache/aurora/client/api/sla.py 0738db89969a0d2ac69637913031828cbf2e1c73
> src/main/python/apache/aurora/client/base.py cc08c18b1c4e664ca38efccca7f6d96a070479ba
> src/main/python/apache/aurora/client/commands/admin.py 16e73ba5ed88878302bc2a8a7f2af2a284ccbf02
> src/main/python/apache/aurora/client/commands/maintenance.py d020e4c36594d717537d5e8e10588e1e05e0d5db
> src/test/python/apache/aurora/admin/test_host_maintenance.py 8c766385fc091f066a77cda2941aa11cc9a64d46
> src/test/python/apache/aurora/client/api/test_sla.py 02b36d5cd3322f6f03f1d6d525745faf2513f065
> src/test/python/apache/aurora/client/commands/test_admin_sla.py df007f2e0de70cd6c3295119d7ef3877cfce036d
>
> Diff: https://reviews.apache.org/r/21741/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python:all
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 21741: Adding grouping for the sla commands.
Posted by Joe Smith <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21741/#review44015
-----------------------------------------------------------
Ship it!
thanks!
src/main/python/apache/aurora/client/api/sla.py
<https://reviews.apache.org/r/21741/#comment78261>
In practice, we operate on only a single grouping, and it'd be kind of nice to specify this only once as opposed to each time we invoke this method.. though I'm not sure how to do that cleanly (especially when we call this method once via the command line)
(so not a blocker to ship unless we can think of a clean way to improve this api)
src/test/python/apache/aurora/client/api/test_sla.py
<https://reviews.apache.org/r/21741/#comment78258>
add a double newline? (unless this passes check style, in which case ignore me)
- Joe Smith
On May 22, 2014, 6:12 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21741/
> -----------------------------------------------------------
>
> (Updated May 22, 2014, 6:12 p.m.)
>
>
> Review request for Aurora, Joe Smith, Mark Chu-Carroll, and Brian Wickman.
>
>
> Bugs: AURORA-441
> https://issues.apache.org/jira/browse/AURORA-441
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Moved grouping functionality from maintenance into base and added grouping support for the sla commands.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/admin/host_maintenance.py 1890f80ca7981af020ab12957879795bd86b6327
> src/main/python/apache/aurora/client/api/sla.py 0738db89969a0d2ac69637913031828cbf2e1c73
> src/main/python/apache/aurora/client/base.py cc08c18b1c4e664ca38efccca7f6d96a070479ba
> src/main/python/apache/aurora/client/commands/admin.py 16e73ba5ed88878302bc2a8a7f2af2a284ccbf02
> src/main/python/apache/aurora/client/commands/maintenance.py d020e4c36594d717537d5e8e10588e1e05e0d5db
> src/test/python/apache/aurora/admin/test_host_maintenance.py 8c766385fc091f066a77cda2941aa11cc9a64d46
> src/test/python/apache/aurora/client/api/test_sla.py 02b36d5cd3322f6f03f1d6d525745faf2513f065
> src/test/python/apache/aurora/client/commands/test_admin_sla.py df007f2e0de70cd6c3295119d7ef3877cfce036d
>
> Diff: https://reviews.apache.org/r/21741/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python:all
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 21741: Adding grouping for the sla commands.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21741/#review43980
-----------------------------------------------------------
Ping Mark, Joe.
- Maxim Khutornenko
On May 23, 2014, 1:12 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21741/
> -----------------------------------------------------------
>
> (Updated May 23, 2014, 1:12 a.m.)
>
>
> Review request for Aurora, Joe Smith, Mark Chu-Carroll, and Brian Wickman.
>
>
> Bugs: AURORA-441
> https://issues.apache.org/jira/browse/AURORA-441
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Moved grouping functionality from maintenance into base and added grouping support for the sla commands.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/admin/host_maintenance.py 1890f80ca7981af020ab12957879795bd86b6327
> src/main/python/apache/aurora/client/api/sla.py 0738db89969a0d2ac69637913031828cbf2e1c73
> src/main/python/apache/aurora/client/base.py cc08c18b1c4e664ca38efccca7f6d96a070479ba
> src/main/python/apache/aurora/client/commands/admin.py 16e73ba5ed88878302bc2a8a7f2af2a284ccbf02
> src/main/python/apache/aurora/client/commands/maintenance.py d020e4c36594d717537d5e8e10588e1e05e0d5db
> src/test/python/apache/aurora/admin/test_host_maintenance.py 8c766385fc091f066a77cda2941aa11cc9a64d46
> src/test/python/apache/aurora/client/api/test_sla.py 02b36d5cd3322f6f03f1d6d525745faf2513f065
> src/test/python/apache/aurora/client/commands/test_admin_sla.py df007f2e0de70cd6c3295119d7ef3877cfce036d
>
> Diff: https://reviews.apache.org/r/21741/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python:all
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 21741: Adding grouping for the sla commands.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21741/
-----------------------------------------------------------
(Updated May 28, 2014, 12:54 a.m.)
Review request for Aurora, Joe Smith, Mark Chu-Carroll, and Brian Wickman.
Changes
-------
CR comments and rebasing.
Bugs: AURORA-441
https://issues.apache.org/jira/browse/AURORA-441
Repository: aurora
Description
-------
Moved grouping functionality from maintenance into base and added grouping support for the sla commands.
Diffs (updated)
-----
src/main/python/apache/aurora/admin/host_maintenance.py 15c2b571f5322ac5867ad456dc1594dd205a3558
src/main/python/apache/aurora/client/api/sla.py ce48cb07dcebf61aa1952b133a3cbffba0472fdc
src/main/python/apache/aurora/client/base.py 1f41ef05fafe5f5d73969d1453afd0dda0121927
src/main/python/apache/aurora/client/commands/admin.py 4bf5735f1364ea1bed5387aabd08a845fa2390ee
src/main/python/apache/aurora/client/commands/maintenance.py 72bde47a9d3bed0c219cad53c34fb2b1dfc130a7
src/test/python/apache/aurora/admin/test_host_maintenance.py 2713bfe393edd386e7d3a4e919c6efb87e5bc8ea
src/test/python/apache/aurora/client/api/test_sla.py f9490b4dcc2ec051d68720e79afebfde982a79c5
src/test/python/apache/aurora/client/commands/test_admin_sla.py d5b5dffcacc26e8e89dec61ba0da43f5ee84575b
Diff: https://reviews.apache.org/r/21741/diff/
Testing
-------
./pants src/test/python:all
Thanks,
Maxim Khutornenko
Re: Review Request 21741: Adding grouping for the sla commands.
Posted by Mark Chu-Carroll <mc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21741/#review43983
-----------------------------------------------------------
Ship it!
Ship It!
- Mark Chu-Carroll
On May 22, 2014, 9:12 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21741/
> -----------------------------------------------------------
>
> (Updated May 22, 2014, 9:12 p.m.)
>
>
> Review request for Aurora, Joe Smith, Mark Chu-Carroll, and Brian Wickman.
>
>
> Bugs: AURORA-441
> https://issues.apache.org/jira/browse/AURORA-441
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Moved grouping functionality from maintenance into base and added grouping support for the sla commands.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/admin/host_maintenance.py 1890f80ca7981af020ab12957879795bd86b6327
> src/main/python/apache/aurora/client/api/sla.py 0738db89969a0d2ac69637913031828cbf2e1c73
> src/main/python/apache/aurora/client/base.py cc08c18b1c4e664ca38efccca7f6d96a070479ba
> src/main/python/apache/aurora/client/commands/admin.py 16e73ba5ed88878302bc2a8a7f2af2a284ccbf02
> src/main/python/apache/aurora/client/commands/maintenance.py d020e4c36594d717537d5e8e10588e1e05e0d5db
> src/test/python/apache/aurora/admin/test_host_maintenance.py 8c766385fc091f066a77cda2941aa11cc9a64d46
> src/test/python/apache/aurora/client/api/test_sla.py 02b36d5cd3322f6f03f1d6d525745faf2513f065
> src/test/python/apache/aurora/client/commands/test_admin_sla.py df007f2e0de70cd6c3295119d7ef3877cfce036d
>
> Diff: https://reviews.apache.org/r/21741/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python:all
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 21741: Adding grouping for the sla commands.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21741/
-----------------------------------------------------------
(Updated May 23, 2014, 1:12 a.m.)
Review request for Aurora, Joe Smith, Mark Chu-Carroll, and Brian Wickman.
Changes
-------
Rebased.
Bugs: AURORA-441
https://issues.apache.org/jira/browse/AURORA-441
Repository: aurora
Description
-------
Moved grouping functionality from maintenance into base and added grouping support for the sla commands.
Diffs (updated)
-----
src/main/python/apache/aurora/admin/host_maintenance.py 1890f80ca7981af020ab12957879795bd86b6327
src/main/python/apache/aurora/client/api/sla.py 0738db89969a0d2ac69637913031828cbf2e1c73
src/main/python/apache/aurora/client/base.py cc08c18b1c4e664ca38efccca7f6d96a070479ba
src/main/python/apache/aurora/client/commands/admin.py 16e73ba5ed88878302bc2a8a7f2af2a284ccbf02
src/main/python/apache/aurora/client/commands/maintenance.py d020e4c36594d717537d5e8e10588e1e05e0d5db
src/test/python/apache/aurora/admin/test_host_maintenance.py 8c766385fc091f066a77cda2941aa11cc9a64d46
src/test/python/apache/aurora/client/api/test_sla.py 02b36d5cd3322f6f03f1d6d525745faf2513f065
src/test/python/apache/aurora/client/commands/test_admin_sla.py df007f2e0de70cd6c3295119d7ef3877cfce036d
Diff: https://reviews.apache.org/r/21741/diff/
Testing
-------
./pants src/test/python:all
Thanks,
Maxim Khutornenko
Re: Review Request 21741: Adding grouping for the sla commands.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21741/
-----------------------------------------------------------
(Updated May 22, 2014, 7:23 p.m.)
Review request for Aurora, Joe Smith, Mark Chu-Carroll, and Brian Wickman.
Changes
-------
CR comments.
Bugs: AURORA-441
https://issues.apache.org/jira/browse/AURORA-441
Repository: aurora
Description
-------
Moved grouping functionality from maintenance into base and added grouping support for the sla commands.
Diffs (updated)
-----
src/main/python/apache/aurora/admin/host_maintenance.py 16c18bc563c61e37055a8ad81082d60d1662afb2
src/main/python/apache/aurora/client/api/sla.py a20b5d46221981740e0b7d5f0958516560928b54
src/main/python/apache/aurora/client/base.py 13730fd98e36377376e498f414dfb317d5b3b114
src/main/python/apache/aurora/client/commands/admin.py 16e73ba5ed88878302bc2a8a7f2af2a284ccbf02
src/main/python/apache/aurora/client/commands/maintenance.py 68d63a12bb92bb2f50ae45363513892ad9bbb1ff
src/test/python/apache/aurora/admin/test_host_maintenance.py 18bf6223adb6b64cc76c2810abc317ef063e16e2
src/test/python/apache/aurora/client/api/test_sla.py 86b6775e51cab1214a6cae01145f19f08cc74499
src/test/python/apache/aurora/client/commands/test_admin_sla.py df007f2e0de70cd6c3295119d7ef3877cfce036d
Diff: https://reviews.apache.org/r/21741/diff/
Testing
-------
./pants src/test/python:all
Thanks,
Maxim Khutornenko
Re: Review Request 21741: Adding grouping for the sla commands.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21741/#review43724
-----------------------------------------------------------
Ping.
- Maxim Khutornenko
On May 21, 2014, 12:24 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21741/
> -----------------------------------------------------------
>
> (Updated May 21, 2014, 12:24 a.m.)
>
>
> Review request for Aurora, Joe Smith, Mark Chu-Carroll, and Brian Wickman.
>
>
> Bugs: AURORA-441
> https://issues.apache.org/jira/browse/AURORA-441
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Moved grouping functionality from maintenance into base and added grouping support for the sla commands.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/admin/host_maintenance.py 16c18bc563c61e37055a8ad81082d60d1662afb2
> src/main/python/apache/aurora/client/api/sla.py a20b5d46221981740e0b7d5f0958516560928b54
> src/main/python/apache/aurora/client/base.py 13730fd98e36377376e498f414dfb317d5b3b114
> src/main/python/apache/aurora/client/commands/admin.py 16e73ba5ed88878302bc2a8a7f2af2a284ccbf02
> src/main/python/apache/aurora/client/commands/maintenance.py 68d63a12bb92bb2f50ae45363513892ad9bbb1ff
> src/test/python/apache/aurora/admin/test_host_maintenance.py 18bf6223adb6b64cc76c2810abc317ef063e16e2
> src/test/python/apache/aurora/client/api/test_sla.py 86b6775e51cab1214a6cae01145f19f08cc74499
> src/test/python/apache/aurora/client/commands/test_admin_sla.py df007f2e0de70cd6c3295119d7ef3877cfce036d
>
> Diff: https://reviews.apache.org/r/21741/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python:all
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 21741: Adding grouping for the sla commands.
Posted by Maxim Khutornenko <ma...@apache.org>.
> On May 22, 2014, 4:22 p.m., Brian Wickman wrote:
> > src/main/python/apache/aurora/client/base.py, line 118
> > <https://reviews.apache.org/r/21741/diff/1/?file=585847#file585847line118>
> >
> > can you also add register_grouping() that associates a name with a function? this way it's explicit and not monkeypatched.
Good idea. Done.
> On May 22, 2014, 4:22 p.m., Brian Wickman wrote:
> > src/main/python/apache/aurora/client/base.py, line 123
> > <https://reviews.apache.org/r/21741/diff/1/?file=585847#file585847line123>
> >
> > It would be helpful to also print out GROUPING_FUNCTIONS.keys()
Done.
- Maxim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21741/#review43728
-----------------------------------------------------------
On May 21, 2014, 12:24 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21741/
> -----------------------------------------------------------
>
> (Updated May 21, 2014, 12:24 a.m.)
>
>
> Review request for Aurora, Joe Smith, Mark Chu-Carroll, and Brian Wickman.
>
>
> Bugs: AURORA-441
> https://issues.apache.org/jira/browse/AURORA-441
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Moved grouping functionality from maintenance into base and added grouping support for the sla commands.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/admin/host_maintenance.py 16c18bc563c61e37055a8ad81082d60d1662afb2
> src/main/python/apache/aurora/client/api/sla.py a20b5d46221981740e0b7d5f0958516560928b54
> src/main/python/apache/aurora/client/base.py 13730fd98e36377376e498f414dfb317d5b3b114
> src/main/python/apache/aurora/client/commands/admin.py 16e73ba5ed88878302bc2a8a7f2af2a284ccbf02
> src/main/python/apache/aurora/client/commands/maintenance.py 68d63a12bb92bb2f50ae45363513892ad9bbb1ff
> src/test/python/apache/aurora/admin/test_host_maintenance.py 18bf6223adb6b64cc76c2810abc317ef063e16e2
> src/test/python/apache/aurora/client/api/test_sla.py 86b6775e51cab1214a6cae01145f19f08cc74499
> src/test/python/apache/aurora/client/commands/test_admin_sla.py df007f2e0de70cd6c3295119d7ef3877cfce036d
>
> Diff: https://reviews.apache.org/r/21741/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python:all
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 21741: Adding grouping for the sla commands.
Posted by Brian Wickman <wi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21741/#review43728
-----------------------------------------------------------
Ship it!
src/main/python/apache/aurora/client/base.py
<https://reviews.apache.org/r/21741/#comment78011>
can you also add register_grouping() that associates a name with a function? this way it's explicit and not monkeypatched.
src/main/python/apache/aurora/client/base.py
<https://reviews.apache.org/r/21741/#comment78010>
It would be helpful to also print out GROUPING_FUNCTIONS.keys()
- Brian Wickman
On May 21, 2014, 12:24 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21741/
> -----------------------------------------------------------
>
> (Updated May 21, 2014, 12:24 a.m.)
>
>
> Review request for Aurora, Joe Smith, Mark Chu-Carroll, and Brian Wickman.
>
>
> Bugs: AURORA-441
> https://issues.apache.org/jira/browse/AURORA-441
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Moved grouping functionality from maintenance into base and added grouping support for the sla commands.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/admin/host_maintenance.py 16c18bc563c61e37055a8ad81082d60d1662afb2
> src/main/python/apache/aurora/client/api/sla.py a20b5d46221981740e0b7d5f0958516560928b54
> src/main/python/apache/aurora/client/base.py 13730fd98e36377376e498f414dfb317d5b3b114
> src/main/python/apache/aurora/client/commands/admin.py 16e73ba5ed88878302bc2a8a7f2af2a284ccbf02
> src/main/python/apache/aurora/client/commands/maintenance.py 68d63a12bb92bb2f50ae45363513892ad9bbb1ff
> src/test/python/apache/aurora/admin/test_host_maintenance.py 18bf6223adb6b64cc76c2810abc317ef063e16e2
> src/test/python/apache/aurora/client/api/test_sla.py 86b6775e51cab1214a6cae01145f19f08cc74499
> src/test/python/apache/aurora/client/commands/test_admin_sla.py df007f2e0de70cd6c3295119d7ef3877cfce036d
>
> Diff: https://reviews.apache.org/r/21741/diff/
>
>
> Testing
> -------
>
> ./pants src/test/python:all
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 21741: Adding grouping for the sla commands.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21741/
-----------------------------------------------------------
(Updated May 21, 2014, 12:24 a.m.)
Review request for Aurora, Joe Smith, Mark Chu-Carroll, and Brian Wickman.
Changes
-------
+ jsmith
Bugs: AURORA-441
https://issues.apache.org/jira/browse/AURORA-441
Repository: aurora
Description
-------
Moved grouping functionality from maintenance into base and added grouping support for the sla commands.
Diffs
-----
src/main/python/apache/aurora/admin/host_maintenance.py 16c18bc563c61e37055a8ad81082d60d1662afb2
src/main/python/apache/aurora/client/api/sla.py a20b5d46221981740e0b7d5f0958516560928b54
src/main/python/apache/aurora/client/base.py 13730fd98e36377376e498f414dfb317d5b3b114
src/main/python/apache/aurora/client/commands/admin.py 16e73ba5ed88878302bc2a8a7f2af2a284ccbf02
src/main/python/apache/aurora/client/commands/maintenance.py 68d63a12bb92bb2f50ae45363513892ad9bbb1ff
src/test/python/apache/aurora/admin/test_host_maintenance.py 18bf6223adb6b64cc76c2810abc317ef063e16e2
src/test/python/apache/aurora/client/api/test_sla.py 86b6775e51cab1214a6cae01145f19f08cc74499
src/test/python/apache/aurora/client/commands/test_admin_sla.py df007f2e0de70cd6c3295119d7ef3877cfce036d
Diff: https://reviews.apache.org/r/21741/diff/
Testing
-------
./pants src/test/python:all
Thanks,
Maxim Khutornenko