You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by bhaisaab <gi...@git.apache.org> on 2015/12/10 11:17:32 UTC
[GitHub] cloudstack pull request: ui/quota: Make the quota UI plugin icon g...
GitHub user bhaisaab opened a pull request:
https://github.com/apache/cloudstack/pull/1208
ui/quota: Make the quota UI plugin icon gray
Makes the quota ui plugin icon gray, based on comment at:
https://github.com/apache/cloudstack/pull/768#issuecomment-163364606
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shapeblue/cloudstack master-quota-greyicon
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1208.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1208
----
commit 16d84aa506983c87fc0a59efb47394549d6defcd
Author: Rohit Yadav <ro...@shapeblue.com>
Date: 2015-12-10T10:12:53Z
ui/quota: Make the quota UI plugin icon gray
Makes the quota ui plugin icon gray, based on comment at:
https://github.com/apache/cloudstack/pull/768#issuecomment-163364606
Signed-off-by: Rohit Yadav <ro...@shapeblue.com>
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: ui/quota: Make the quota UI plugin icon g...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1208#issuecomment-163566614
cc @remibergsma @DaanHoogland
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: ui/quota: Make the quota UI plugin icon g...
Posted by borisroman <gi...@git.apache.org>.
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1208#issuecomment-163568069
@wilderrodrigues @remibergsma @DaanHoogland LGTM :+1:
Better styling this way.
No unit or integration tests run. Though in this case I don't think it's necessary.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: ui/quota: Make the quota UI plugin icon g...
Posted by wilderrodrigues <gi...@git.apache.org>.
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1208#issuecomment-163570500
I don't think it is. :D
Would be nice to see a review from a colour-blind person though. :D
LGTM
Cheers,
Wilder
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: ui/quota: Make the quota UI plugin icon g...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1208#issuecomment-163624151
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: ui/quota: Make the quota UI plugin icon g...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1208
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: ui/quota: Make the quota UI plugin icon g...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1208#issuecomment-163574449
I like angry fruit salads, how about a grey icon that colours all up on hovering?
serious? ok, i'm fine with both.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---