You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "ajantha-bhat (via GitHub)" <gi...@apache.org> on 2023/05/02 09:55:00 UTC
[GitHub] [iceberg] ajantha-bhat opened a new pull request, #7498: Arrow: Fix errorprone warnings
ajantha-bhat opened a new pull request, #7498:
URL: https://github.com/apache/iceberg/pull/7498
<img width="852" alt="Screenshot 2023-05-02 at 1 13 22 PM" src="https://user-images.githubusercontent.com/5889404/235636129-33c00e7a-3402-43b6-b2f3-d547af765bf2.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] nastra merged pull request #7498: Arrow: Fix errorprone warnings
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra merged PR #7498:
URL: https://github.com/apache/iceberg/pull/7498
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] ajantha-bhat commented on pull request #7498: Arrow: Fix errorprone warnings
Posted by "ajantha-bhat (via GitHub)" <gi...@apache.org>.
ajantha-bhat commented on PR #7498:
URL: https://github.com/apache/iceberg/pull/7498#issuecomment-1534587895
Re-trrigering the build due to
> Could not resolve org.antlr:antlr4:4.8.
> Could not get resource 'https://repo.maven.apache.org/maven2/org/antlr/antlr4/4.8/antlr4-4.8.pom'.
> Could not GET 'https://repo.maven.apache.org/maven2/org/antlr/antlr4/4.8/antlr4-4.8.pom'.
> repo.maven.apache.org
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] ajantha-bhat commented on pull request #7498: Arrow: Fix errorprone warnings
Posted by "ajantha-bhat (via GitHub)" <gi...@apache.org>.
ajantha-bhat commented on PR #7498:
URL: https://github.com/apache/iceberg/pull/7498#issuecomment-1531195462
cc: @nastra, @Fokko
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] nastra commented on a diff in pull request #7498: Arrow: Fix errorprone warnings
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on code in PR #7498:
URL: https://github.com/apache/iceberg/pull/7498#discussion_r1182452157
##########
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/ColumnVector.java:
##########
@@ -56,12 +56,12 @@ public class ColumnVector implements AutoCloseable {
this.accessor = getVectorAccessor(vectorHolder);
}
- /** @return the potentially dict-encoded {@link FieldVector}. */
+ /** Returns the potentially dict-encoded {@link FieldVector}. */
Review Comment:
I think it would be better to have a summary and keep the `@return`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] ajantha-bhat closed pull request #7498: Arrow: Fix errorprone warnings
Posted by "ajantha-bhat (via GitHub)" <gi...@apache.org>.
ajantha-bhat closed pull request #7498: Arrow: Fix errorprone warnings
URL: https://github.com/apache/iceberg/pull/7498
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] ajantha-bhat commented on pull request #7498: Arrow: Fix errorprone warnings
Posted by "ajantha-bhat (via GitHub)" <gi...@apache.org>.
ajantha-bhat commented on PR #7498:
URL: https://github.com/apache/iceberg/pull/7498#issuecomment-1537783238
I think it is ready for merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] nastra commented on pull request #7498: Arrow: Fix errorprone warnings
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on PR #7498:
URL: https://github.com/apache/iceberg/pull/7498#issuecomment-1537810766
thanks for fixing this @ajantha-bhat
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org