You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/13 10:38:10 UTC

[GitHub] [spark] wangyum commented on a change in pull request #31822: [SPARK-34728][SQL] Remove all SQLConf.get if extends from Rule

wangyum commented on a change in pull request #31822:
URL: https://github.com/apache/spark/pull/31822#discussion_r593734245



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/dynamicpruning/PartitionPruning.scala
##########
@@ -97,7 +96,7 @@ object PartitionPruning extends Rule[LogicalPlan] with PredicateHelper {
           filteringPlan,
           joinKeys,
           index,
-          SQLConf.get.dynamicPartitionPruningReuseBroadcastOnly || !hasBenefit),
+          ç.dynamicPartitionPruningReuseBroadcastOnly || !hasBenefit),

Review comment:
       typo?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org