You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/12/15 03:05:47 UTC

[GitHub] [incubator-yunikorn-scheduler-interface] wilfred-s opened a new pull request #29: [YUNIKORN-2] interface changes for gang

wilfred-s opened a new pull request #29:
URL: https://github.com/apache/incubator-yunikorn-scheduler-interface/pull/29


   Changes for teh scheduler interface based on the detailed design
   documentation for gang scheduling.
   - AddApplication update
   - AllocationAsk update
   - refactor AllocationRelease Response and Request


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-yunikorn-scheduler-interface] yangwwei commented on a change in pull request #29: [YUNIKORN-2] interface changes for gang

Posted by GitBox <gi...@apache.org>.
yangwwei commented on a change in pull request #29:
URL: https://github.com/apache/incubator-yunikorn-scheduler-interface/pull/29#discussion_r543029016



##########
File path: scheduler-interface-spec.md
##########
@@ -437,6 +442,8 @@ message AddApplicationRequest {
   // Execution timeout: How long this application can be in a running state
   // 0 or negative value means never expire.
   int64 executionTimeoutMilliSeconds = 6;
+  // The total amount of resources gang placeholders will request
+  Resource placeholderAsk = 7;

Review comment:
       why we need this?
   is this a placeholder for future enhancement, e.g headroom check at queue level?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-yunikorn-scheduler-interface] wilfred-s commented on pull request #29: [YUNIKORN-2] interface changes for gang

Posted by GitBox <gi...@apache.org>.
wilfred-s commented on pull request #29:
URL: https://github.com/apache/incubator-yunikorn-scheduler-interface/pull/29#issuecomment-745310219


   If we push this in a branch we have extra work on merging in the other repos. We need to point to a new commit for the SI after we merge this. While we can now prepare all changes including the go.mod changes in the other repos and not have to think about the SI merge first which would then be followed by dependency fixes in the other repos.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-yunikorn-scheduler-interface] wilfred-s commented on a change in pull request #29: [YUNIKORN-2] interface changes for gang

Posted by GitBox <gi...@apache.org>.
wilfred-s commented on a change in pull request #29:
URL: https://github.com/apache/incubator-yunikorn-scheduler-interface/pull/29#discussion_r543105659



##########
File path: scheduler-interface-spec.md
##########
@@ -437,6 +442,8 @@ message AddApplicationRequest {
   // Execution timeout: How long this application can be in a running state
   // 0 or negative value means never expire.
   int64 executionTimeoutMilliSeconds = 6;
+  // The total amount of resources gang placeholders will request
+  Resource placeholderAsk = 7;

Review comment:
       It is to make sure that the whole gang fits in the queue, this was already in the design. If the gang does not fit in the queue quota the application will be rejected.
   Use case supported: gang total request is 100GB. queue quota is 50 GB. That case we can never allocate the gang, not even in an empty queue and the app will be rejected on submit.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-yunikorn-scheduler-interface] yangwwei commented on pull request #29: [YUNIKORN-2] interface changes for gang

Posted by GitBox <gi...@apache.org>.
yangwwei commented on pull request #29:
URL: https://github.com/apache/incubator-yunikorn-scheduler-interface/pull/29#issuecomment-745038290


   Can we use a sub task under YUNIKORN-2 to track this?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-yunikorn-scheduler-interface] wilfred-s closed pull request #29: [YUNIKORN-2] interface changes for gang

Posted by GitBox <gi...@apache.org>.
wilfred-s closed pull request #29:
URL: https://github.com/apache/incubator-yunikorn-scheduler-interface/pull/29


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-yunikorn-scheduler-interface] yangwwei commented on a change in pull request #29: [YUNIKORN-2] interface changes for gang

Posted by GitBox <gi...@apache.org>.
yangwwei commented on a change in pull request #29:
URL: https://github.com/apache/incubator-yunikorn-scheduler-interface/pull/29#discussion_r543117463



##########
File path: scheduler-interface-spec.md
##########
@@ -437,6 +442,8 @@ message AddApplicationRequest {
   // Execution timeout: How long this application can be in a running state
   // 0 or negative value means never expire.
   int64 executionTimeoutMilliSeconds = 6;
+  // The total amount of resources gang placeholders will request
+  Resource placeholderAsk = 7;

Review comment:
       Got it, I recall it now. 
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-yunikorn-scheduler-interface] yangwwei removed a comment on pull request #29: [YUNIKORN-2] interface changes for gang

Posted by GitBox <gi...@apache.org>.
yangwwei removed a comment on pull request #29:
URL: https://github.com/apache/incubator-yunikorn-scheduler-interface/pull/29#issuecomment-745038290


   Can we use a sub task under YUNIKORN-2 to track this?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org